Commit Graph

7722 Commits

Author SHA1 Message Date
Jonas Jenwald
f15d5c8cfe Rename the presentation_mode.js file and adjust the function names
Also moves the |fullscreenchange| event listeners into PDFPresentationMode.
2015-04-21 16:28:48 +02:00
Jonas Jenwald
e7fd5b4d4d Refactor the options passed to |PresentationMode.initialize| and clean-up some code in viewer.js and presentation_mode.js
This patch:
 - Passes in a reference to the current PDFThumbnailViewer, which is used to ensure that the current thumbnail becomes visible when exiting PresentationMode.

 - Changes the way that the event listeners for the contextmenu items are defined, to avoid passing in a reference to the SecondaryToolbar.

 - Ensures that |supportsFullscreen| always returns a boolean.
   Currently `supportsFullscreen` will, when the browser supports the fullscreen API, return e.g. `function mozRequestFullScreen()` instead of `true`.

 - Simplifies the |click| handler code when PresentationMode is active.
   This code has been obsolete ever since PR 2919 landed.

 - Removes hack used to workaround a bug in WebKit browsers, which caused |mousemove| events to be fired when the cursor changed.
   This was fixed close to a year ago, see http://code.google.com/p/chromium/issues/detail?id=103041.
2015-04-21 16:27:41 +02:00
Jonas Jenwald
95b2ec124b Move the PresentationMode-specific scrollWheel code from PDFViewerApplication 2015-04-21 16:08:37 +02:00
Jonas Jenwald
2dc1af8028 Break dependencies between PresentationMode and other code, and add PresentationMode related utility methods to PDFViewer
This patch:
 - Adds a couple of utility methods to `PDFViewer` to enable checking `presentationModeState` without cumbersome comparisons.

 - Disentangles `PresentationMode` from `PDFHistory` and `HandTool`, by adding event listeners for `presentationmodechanged` to both of them.

 - Adds a utility function to `PDFViewerApplication` for requesting PresentationMode.

 - Prevents initialization of `PresentationMode` if the browser does not support the fullscreen API.
2015-04-21 16:02:32 +02:00
Brendan Dahl
846eb967cc Merge pull request #5655 from Snuffleupagus/issue-5644
Avoid getting stuck in empty nodes in the Pages tree when calling |Catalog_getPageDict| (issue 5644)
2015-04-20 11:46:27 -07:00
Jonas Jenwald
c47d60f865 Merge pull request #5951 from arai-a/bug1156287
Bug 1156287 - Do not extract unreachable code after return
2015-04-20 17:46:11 +02:00
Yury Delendik
ebd6ce33b5 Merge pull request #5917 from Snuffleupagus/bug-1148192-review-comments
Address review comments from Bug 1148192 - Update pdf.js to version 1.1.24
2015-04-20 10:23:52 -05:00
arai
5c4e3c31b8 Bug 1156287 - Do not extract unreachable code after return 2015-04-21 00:22:45 +09:00
Tim van der Meij
180a5a2746 Merge pull request #5945 from marco-c/use_int32array
Use Int32Array instead of Uint32Array in FlateStream
2015-04-17 20:37:23 +02:00
Tim van der Meij
62c3db0bf5 Merge pull request #5944 from marco-c/better_error_message_if_browser_path_doesnt_exist
Fail with a more informative error message if the browser executable pat...
2015-04-17 20:21:50 +02:00
Marco Castelluccio
1bd952f897 Use Int32Array instead of Uint32Array in FlateStream 2015-04-17 16:33:04 +02:00
Marco Castelluccio
fbae39983c Fail with a more informative error message if the browser executable path doesn't exist 2015-04-17 16:12:13 +02:00
Brendan Dahl
63aaf1b969 Merge pull request #5923 from Snuffleupagus/bug-911034
Don't map glyphs to certain problematic General Punctuation Unicode locations (bug 911034)
2015-04-15 14:31:54 -07:00
Jonas Jenwald
cadbb81fb9 Merge pull request #5937 from gettalong/patch-1
Crypt filter EFF key should have StmF value as default, not StrF
2015-04-15 13:02:05 +02:00
Jonas Jenwald
cba36bc37e Merge pull request #5936 from arfon/master
Update .gitattributes to fix GitHub file type detection for JavaScript.
2015-04-14 16:48:44 +02:00
Arfon Smith
15edae56e5 Update .gitattributes to fix GitHub file type detection for JavaScript. 2015-04-14 09:28:55 -05:00
Thomas Leitner
3ebc85e55f Crypt filter EFF key should have StmF value as default, not StrF
This fixes the problem.
2015-04-13 21:27:32 +02:00
Tim van der Meij
e4e9a2adea Merge pull request #5926 from browtayl/1018932
prevent viewer from zooming on cmd+mousewheel (bug 1018932)
2015-04-13 20:57:23 +02:00
Tim van der Meij
dbcc3a77fa Merge pull request #5933 from Snuffleupagus/viewer-comment-cleanup
Remove commented out code from viewer.html
2015-04-13 20:18:05 +02:00
Jonas Jenwald
bc0d55bf43 Remove commented out code from viewer.html
The line that this patch removes has been commented out since 2012 (!), see commit c8a6a9ba00.

Also, since the patch is trivial, I'm fixing the formatting of a comment to stop [GitHub from marking it with a red color](https://github.com/mozilla/pdf.js/blob/master/web/viewer.html#L394) (and IE from complaining).
2015-04-13 12:44:05 +02:00
Taylor Brown
34d3b96b52 prevent viewer from zooming on cmd+mousewheel 2015-04-10 15:08:32 -07:00
Jonas Jenwald
fda858ae33 Don't map glyphs to certain problematic General Punctuation Unicode locations (bug 911034)
Fixes the remaining missing characters in https://bugzilla.mozilla.org/show_bug.cgi?id=911034.

For reference, see http://www.unicode.org/charts/PDF/U2000.pdf (and also http://en.wikipedia.org/wiki/General_Punctuation_%28Unicode_block%29).
2015-04-09 17:27:03 +02:00
Jonas Jenwald
a54ec673c5 Move the checks for problematic Unicode locations from |adjustMapping| to a separate helper function 2015-04-09 12:56:29 +02:00
Jonas Jenwald
1d6fae231e Merge pull request #5912 from timvandermeij/shelljs
Remove ShellJS copy and use the NPM version
2015-04-07 20:24:16 +02:00
Jonas Jenwald
9f63fa4b07 Address review comments from Bug 1148192 - Update pdf.js to version 1.1.24
See https://bugzilla.mozilla.org/show_bug.cgi?id=1148192#c3.
2015-04-06 16:26:23 +02:00
Tim van der Meij
1c8305cf1a Remove unreachable jshint installation code
The previous commit implements a check for ShellJS and otherwise prompts the user to run "npm install". New clones of the codebase will need "npm install" for ShellJS and therefore automatically install jshint. Existing clones of the codebase will also need "npm install" again since ShellJS needs to be installed using NPM as it is not in the "external" folder anymore. Since everyone will get this prompt and install everything automatically, we will never reach this code path anymore.

This patch makes #5908 obsolete and reduces code complexity for the lint target. Thanks to @Snuffleupagus for noticing this!
2015-04-05 15:48:59 +02:00
Tim van der Meij
70b6eb09a8 Remove ShellJS copy and use the NPM version
There is no need to have a copy of ShellJS in the repository as it is also available on NPM. The NPM version is also much newer. This way we do not have to update this anymore and let NPM do that automatically.
2015-04-05 15:47:25 +02:00
Tim van der Meij
89cf072026 Merge pull request #5913 from Snuffleupagus/b2g-stub-DownloadManager
[B2G] Stub the |DownloadManager| to avoid error
2015-04-05 14:06:08 +02:00
Tim van der Meij
cfb03fc111 Merge pull request #5914 from petercpg/master
Bug 1151303 - [zh-TW] Translation update proposed for browser/pdfviewer/...
2015-04-05 14:02:45 +02:00
Peter Pin-Guang Chen
67b19cfe8a Bug 1151303 - [zh-TW] Translation update proposed for browser/pdfviewer/viewer.properties:document_properties_mb 2015-04-05 19:08:38 +08:00
Jonas Jenwald
48242abe72 [B2G] Stub the |DownloadManager| to avoid error
After the refactoring in PR 5678, the B2G viewer now prints the following in the console:
```
ReferenceError: DownloadManager is not defined
```

This will obviously not matter once the B2G viewer is replaced with the new components-based one. But until that happens, I think it makes sense to just stub the class to suppress the error.
2015-04-04 21:26:33 +02:00
Jonas Jenwald
d156007804 Import l10n 2015-04-04 17:57:54 +02:00
Jonas Jenwald
b85a51d072 Merge pull request #5908 from timvandermeij/read-package-json
Read jshint version from package.json
2015-04-04 17:37:13 +02:00
Tim van der Meij
25299904da Read jshint version from package.json 2015-04-04 16:24:33 +02:00
Tim van der Meij
ba8a4f2b3e Merge pull request #5911 from Snuffleupagus/test-worker-comments
Remove commented out code about |disableWorker| in the test suite
2015-04-04 14:46:13 +02:00
Tim van der Meij
3bae62eda1 Merge pull request #5906 from pietroalbini/patch-1
Fixed a small typo in the italian translation
2015-04-04 14:32:04 +02:00
Jonas Jenwald
36ac67583f Remove commented out code about |disableWorker| in the test suite
Since the tests have run with workers enabled for a long time, these comments are no longer relevant.
2015-04-04 13:32:44 +02:00
Jonas Jenwald
0434569798 Merge pull request #5907 from timvandermeij/browser-manifests
Provide only one browser manifest example
2015-04-04 12:18:09 +02:00
Pietro Albini
1da99feef3 Fixed a small typo in the italian translation
In "document_properties_mb", {{size_mb}} was instead {{size_kb}}.
2015-04-03 21:24:34 +02:00
Tim van der Meij
50573b82a3 Provide only one browser manifest example 2015-04-03 21:21:54 +02:00
Tim van der Meij
32cc021f31 Merge pull request #5899 from neves/master
add missing pt-BR page_scale_percent property
2015-04-02 20:35:21 +02:00
Marcos Neves
47b2e9355f add missing pt-BR page_scale_percent property 2015-04-01 23:57:07 -03:00
Tim van der Meij
01f1761a8b Merge pull request #5881 from mbbaig/master
Added the data-page-number dom attribute to the page rendered in the browser
2015-04-01 20:57:07 +02:00
Tim van der Meij
a7e6f6d4d0 Merge pull request #5895 from Snuffleupagus/viewer-pref-init-refactor
Re-factor and clean-up some preference related code in viewer.js
2015-04-01 20:54:19 +02:00
Jonas Jenwald
e5c4819601 Small refactoring of the code that calls |PDFViewerApplication.setInitialView|
This is a minor cleanup, to avoid an unnecessary `Promise.all` and to simplify catching |ViewHistory| errors.
2015-03-31 20:35:00 +02:00
Jonas Jenwald
6091e7bd6b Move the code that resets the history state when the |showPreviousViewOnLoad| preference is set to |false|
Since this code is *only* necessary if/when the history is actually enabled, this patch refactors it to actually reflect that.
2015-03-31 18:12:15 +02:00
Jonas Jenwald
03497eabd5 Move fetching of the |defaultZoomValue| preference value to |PDFViewerApplication.initialize|
For consistency, this preference should be placed amongst the others. The current position is purely for "historical" reasons, since it was one of the first preferences that was added to the code.
2015-03-31 15:33:21 +02:00
Jonas Jenwald
a931885ddd Merge pull request #5886 from andrewdacenko/patch-1
Restrict logging of errors with verbosity level
2015-03-30 13:25:52 +02:00
Andrew Dacenko
bdde3d6622 Restrict logging of errors with verbosity level 2015-03-28 21:44:41 +02:00
Tim van der Meij
3821b2d6aa Merge pull request #5888 from Snuffleupagus/documentProperties-parseDate-comment
Remove reference to GNUpdf from comment in |DocumentProperties.parseDate|
2015-03-28 15:23:49 +01:00