calixteman
cef2ac99e5
Merge pull request #15298 from calixteman/ink_min_size
...
[Editor] Ensure an ink editor has the minimal required size after having been pasted
2022-08-10 10:27:37 +02:00
calixteman
3eb11fafca
Merge pull request #15297 from calixteman/check_pointer_down
...
[Editor] Avoid creation of an editor on "wrong" clicks
2022-08-10 10:27:12 +02:00
Calixte Denizet
63361dcfc7
[Editor] Ensure an ink editor has the minimal required size after having been pasted
2022-08-10 10:15:23 +02:00
Jonas Jenwald
fa48e90e3c
Merge pull request #15296 from Snuffleupagus/toolbars-reset
...
Move the `reset`-calls to occur last in the toolbar-constructors
2022-08-10 10:14:23 +02:00
Calixte Denizet
71ca249d2b
[Editor] Avoid creation of an editor on "wrong" clicks
2022-08-10 10:05:04 +02:00
Jonas Jenwald
047522a34a
Move the reset
-calls to occur last in the toolbar-constructors
...
By invoking the `reset` methods *last* in the `Toolbar`/`SecondaryToolbar`-constructors, we ensure that the "toolbarreset"/"secondarytoolbarreset"-events are actually handle when the viewer loads. Note that previously those events were dispatched *before* the relevant event-listeners had been attached.
With this small change we can avoid inconsistent initial toolbar-state, specifically in the case when the viewer is *reloaded* (since Firefox keeps the HTML-state on "soft" reloads).
2022-08-09 22:39:38 +02:00
Jonas Jenwald
2b0b8cd665
Add more private properties/methods in web/toolbar.js
2022-08-09 22:39:07 +02:00
calixteman
0079ce4ad0
Merge pull request #15295 from calixteman/disable_editing
...
[Editing] Disable buttons until the first page is rendered
2022-08-09 21:47:21 +02:00
Calixte Denizet
fbce8786d0
[Editing] Disable buttons until the first page is rendered
2022-08-09 20:35:35 +02:00
calixteman
589f72e325
Merge pull request #15290 from calixteman/ots_issue
...
Fix OTS issue with empty index (#15289 )
2022-08-08 23:36:52 +02:00
Calixte Denizet
04f78c935c
Fix OTS issue with empty index ( #15289 )
2022-08-08 22:56:26 +02:00
Jonas Jenwald
40f9f7e909
Merge pull request #15287 from calixteman/inserthtml
...
[Editor] Remove use of innerHtml
2022-08-07 14:37:39 +02:00
Calixte Denizet
5e0ddfb0e6
[Editor] Remove use of innerHtml
2022-08-07 13:39:41 +02:00
Tim van der Meij
2363fc0e5e
Merge pull request #15284 from Snuffleupagus/update-packages
...
Update packages and translations
2022-08-07 12:42:03 +02:00
Jonas Jenwald
38cf588eee
Update l10n files
2022-08-07 10:22:40 +02:00
Jonas Jenwald
887e893fc8
Update npm packages
2022-08-07 10:20:21 +02:00
Tim van der Meij
2a84a3078b
Merge pull request #15283 from Snuffleupagus/sort-PopupAnnotation
...
[api-minor] Sort PopupAnnotations already on the worker-thread (PR 11535 follow-up)
2022-08-06 15:07:09 +02:00
Tim van der Meij
d55903764e
Merge pull request #15281 from Snuffleupagus/getTransform
...
Remove `mozCurrentTransform`/`mozCurrentTransformInverse` usage
2022-08-06 14:34:03 +02:00
Jonas Jenwald
358a0607fe
Remove mozCurrentTransform
/mozCurrentTransformInverse
usage
...
These canvas-context properties are Mozilla-specific, and has obviously never been implemented anywhere else. Currently they are in the process of being removed, see [bug 1782651](https://bugzilla.mozilla.org/show_bug.cgi?id=1782651 ) and [bug 1294360](https://bugzilla.mozilla.org/show_bug.cgi?id=1294360 ), which in practice means that in e.g. Firefox Nightly the `addContextCurrentTransform`-function is now being used in the *built-in* PDF Viewer (which was obviously never intended).
We should thus be able to replace these Mozilla-specific properties with `CanvasRenderingContext2D.getTransform()`, which is available in all browsers that we currently support: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/getTransform#browser_compatibility
2022-08-06 14:24:57 +02:00
Tim van der Meij
0ebd1daf30
Merge pull request #15261 from Snuffleupagus/issue-15260
...
Don't include `images/toolbarButton-editorInk.svg` in the `gulp components` build (issue 15260)
2022-08-06 14:17:55 +02:00
Tim van der Meij
70bcaf63ba
Merge pull request #15282 from Snuffleupagus/prefer-spread
...
Enable the ESLint `prefer-spread` rule
2022-08-06 14:12:25 +02:00
Jonas Jenwald
876a02a504
[api-minor] Sort PopupAnnotations already on the worker-thread (PR 11535 follow-up)
...
By doing this in the worker-thread this code will only need to run *once*, whereas currently re-rendering of a page forces this to be repeated (e.g. after it's been scrolled out-of-view and then back into view again).
2022-08-06 11:42:45 +02:00
Jonas Jenwald
f6db7975c5
Enable the ESLint prefer-spread
rule
...
Note that in a couple of spots the argument could be `undefined` and there we simply disable the rule instead.
Please refer to https://eslint.org/docs/latest/rules/prefer-spread
2022-08-06 10:17:00 +02:00
Jonas Jenwald
d6d4653d80
Merge pull request #15275 from calixteman/textbox
...
[Editor] Remove some a11y properties only useful when a FreeText editor is edited
2022-08-05 09:36:56 +02:00
Calixte Denizet
fce83f8656
[Editor] Remove some a11y properties only useful when a FreeText editor is edited
2022-08-04 15:28:25 +02:00
calixteman
e88c90e898
Merge pull request #15274 from calixteman/missing_annotation
...
[Editor] A pasted FreeText editor was missing when printing/saving
2022-08-04 13:10:23 +02:00
Calixte Denizet
3c8d8f0d02
[Editor] A pasted FreeText editor was missing when printing/saving
...
When a FreeText editor is pasted then it hasn't an editorDiv yet when added
to the layer, hence it's empty.
So this patch just move the call to addToAnnotationStorage to ensure we've
what we need.
2022-08-04 13:00:45 +02:00
calixteman
b985eaa98c
Merge pull request #15267 from calixteman/freetext_a11y
...
[Annotation] Add a div containing the text of a FreeText annotation (bug 1780375)
2022-08-04 11:49:29 +02:00
Calixte Denizet
31155740c3
[Annotation] Add a div containing the text of a FreeText annotation (bug 1780375)
...
An annotation doesn't have to be in the text flow, hence it's likely a bad idea
to insert its text in the text layer. But the text must be visible from a screen
reader point of view so it must somewhere in the DOM.
So with this patch, the text from a FreeText annotation is extracted and added in
a div in its HTML counterpart, and with the patch #15237 the text should be visible
and positioned relatively to the text flow.
2022-08-04 11:14:05 +02:00
Jonas Jenwald
5ad8bbe8cb
Merge pull request #15271 from calixteman/null_field
...
Skip unknown fields when calculating a value in using AFSimple_Calculate
2022-08-04 10:11:46 +02:00
Calixte Denizet
6916fabd51
Skip unknown fields when calculating a value in using AFSimple_Calculate
2022-08-03 23:40:09 +02:00
calixteman
8bad06f158
Merge pull request #15268 from calixteman/bug1777693
...
Fix a typo in firefox print service (bug 1777693)
2022-08-03 18:02:18 +02:00
Calixte Denizet
6c9e538f56
Fix a typo in firefox print service (bug 1777693)
2022-08-03 17:25:01 +02:00
Jonas Jenwald
4f6cd05a53
Merge pull request #15264 from calixteman/editing_telemetry
...
[Editor] Add some telemetry to know how often the editing features are used (bug 1782254)
2022-08-03 11:28:08 +02:00
Calixte Denizet
94f57e5dd7
[Editor] Add some telemetry to know how often the editing features are used (bug 1782254)
2022-08-03 09:54:27 +02:00
Jonas Jenwald
159f853e06
Merge pull request #15263 from Snuffleupagus/issue-15262
...
Always set a border-radius for RadioButton annotations (issue 15262)
2022-08-02 15:35:36 +02:00
Jonas Jenwald
899fc29eef
Always set a border-radius for RadioButton annotations (issue 15262)
2022-08-02 13:58:20 +02:00
Jonas Jenwald
44f77c9e82
Don't include images/toolbarButton-editorInk.svg
in the gulp components
build (issue 15260)
...
Given that this image is intended specifically for the default viewer, we simply use the CSS preprocessor to remove the image reference in the `gulp components` build.
Considering that the issue only affects a CSS file, I don't believe that replacing the *just released* PDF.js version is actually necessary here.
2022-08-02 10:26:46 +02:00
Jonas Jenwald
803e7af595
Merge pull request #15253 from Snuffleupagus/update-Safari-compat
...
[api-minor] Update the minimum supported Safari version
2022-07-31 18:33:47 +02:00
Jonas Jenwald
ad11cea33c
[api-minor] Update the minimum supported Safari version
...
The Ink-editor uses `ResizeObserver`, which is supported in all reasonably modern browsers; see https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#browser_compatibility
With the exception of Safari, `ResizeObserver` is thus available in all of the browsers that the PDF.js library currently support. Rather than trying to e.g. add a polyfill, let's just bump the compatibility (slightly) to Safari 13.1 instead; see https://en.wikipedia.org/wiki/Safari_version_history#Safari_13
2022-07-31 17:40:26 +02:00
Tim van der Meij
f9c593d66c
Merge pull request #15251 from Snuffleupagus/thumbnail-setImage-small
...
Ignore too small page-canvases in `PDFThumbnailView.setImage`
2022-07-31 14:29:15 +02:00
Tim van der Meij
7798252285
Merge pull request #15252 from timvandermeij/bump
...
Bump versions in `pdfjs.config`
2022-07-31 14:22:21 +02:00
Tim van der Meij
91e6830ec4
Bump versions in pdfjs.config
2022-07-31 14:16:06 +02:00
Jonas Jenwald
5b50a50559
Ignore too small page-canvases in PDFThumbnailView.setImage
...
It doesn't make sense to use a page-canvas that's *smaller* than the resulting thumbnail, since that causes the image to be upscaled which results in a blurry thumbnail. Note that this doesn't normally happen, unless a very small zoom-level is used in the viewer.
2022-07-31 13:59:56 +02:00
Tim van der Meij
b8aa9c6221
Merge pull request #15246 from Snuffleupagus/thumbnail-setImage-improvements
...
[api-minor] Improve `thumbnail` handling in documents that contain interactive forms
2022-07-31 11:42:55 +02:00
Tim van der Meij
77b3489987
Merge pull request #15247 from Snuffleupagus/css-more-cleanup
...
Misc. small CSS cleanup
2022-07-31 11:23:16 +02:00
Jonas Jenwald
37d77f29f7
Merge pull request #15248 from Snuffleupagus/update-l10n
...
Update l10n files
2022-07-31 10:25:40 +02:00
Jonas Jenwald
635bd12050
Update l10n files
2022-07-31 10:23:00 +02:00
Jonas Jenwald
7543a91086
[Firefox] Remove a couple of webkit
CSS rules related to editing
...
Thanks to the CSS preprocessor, we can get rid of a couple of unnecessary CSS rules in the Firefox PDF Viewer.
2022-07-30 20:07:44 +02:00
Jonas Jenwald
4a38949886
Remove unnecessary color
CSS property
...
This property is first of all unused, and secondly it contained a static value which means that it'd not have worked correctly in light/dark themes.
2022-07-30 19:53:34 +02:00