Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #15274 from calixteman/missing_annotation

Browse Source 
[Editor] A pasted FreeText editor was missing when printing/saving
This commit is contained in:
calixteman 2022-08-04 13:10:23 +02:00 committed by GitHub
commit e88c90e898
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/display/editor/annotation_editor_layer.js
View File

@ -426,7 +426,6 @@ class AnnotationEditorLayer {
*/
add(editor) {
this.#changeParent(editor);
this.addToAnnotationStorage(editor);
this.#uiManager.addEditor(editor);
this.attach(editor);
@ -438,6 +437,7 @@ class AnnotationEditorLayer {
this.moveDivInDOM(editor);
editor.onceAdded();
this.addToAnnotationStorage(editor);
}
/**

21
test/integration/freetext_editor_spec.js
View File

@ -32,6 +32,11 @@ describe("Editor", () => {
await closePages(pages);
});
const countStorageEntries = async page =>
page.evaluate(
() => window.PDFViewerApplication.pdfDocument.annotationStorage.size
);
it("must write a string in a FreeText editor", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
@ -64,6 +69,10 @@ describe("Editor", () => {
editorRect.y + 2 * editorRect.height
);
expect(await countStorageEntries(page))
.withContext(`In ${browserName}`)
.toEqual(1);
const content = await page.$eval(`${editorPrefix}0`, el =>
el.innerText.trimEnd()
);
@ -94,6 +103,10 @@ describe("Editor", () => {
await page.keyboard.press("v");
await page.keyboard.up("Control");
expect(await countStorageEntries(page))
.withContext(`In ${browserName}`)
.toEqual(2);
const content = await page.$eval(`${editorPrefix}0`, el =>
el.innerText.trimEnd()
);
@ -114,6 +127,10 @@ describe("Editor", () => {
await page.keyboard.press("v");
await page.keyboard.up("Control");
expect(await countStorageEntries(page))
.withContext(`In ${browserName}`)
.toEqual(3);
pastedContent = await page.$eval(`${editorPrefix}2`, el =>
el.innerText.trimEnd()
);
@ -142,6 +159,10 @@ describe("Editor", () => {
expect(hasEditor).withContext(`In ${browserName}`).toEqual(false);
}
expect(await countStorageEntries(page))
.withContext(`In ${browserName}`)
.toEqual(0);
})
);
});