e0ae157582
The `getPageSizeInches` method was implemented on `PDFDocumentProxy`, which seems conceptually wrong since the size property isn't global to the document but rather specific to each page. Hence the method is moved into `PDFPageProxy`, as `get pageSizeInches` instead to address this. Despite the fact that new API functionality was implemented, no unit-tests were added. To prevent issues later on, we should *always* ensure that new functionality has at least some test-coverage; something that this patch also takes care of. The new `PDFDocumentProperties._parsePageSize` method seemed unnecessary convoluted. Furthermore, in the "no data provided"-case it even returned incorrect data (an array, rather than the expected object). Finally, the fallback strings didn't actually agree with the `en-US` locale. This inconsistency doesn't look too great, and it's thus addressed here as well. |
||
|---|---|---|
| .. | ||
| chromium | ||
| features | ||
| font | ||
| pdfs | ||
| resources | ||
| stats | ||
| ttx | ||
| unit | ||
| .eslintrc | ||
| .gitignore | ||
| annotation_layer_builder_overrides.css | ||
| downloadutils.js | ||
| driver.js | ||
| test_manifest.json | ||
| test_slave.html | ||
| test.js | ||
| testutils.js | ||
| text_layer_test.css | ||
| webbrowser.js | ||
| webserver.js | ||