Tim van der Meij
|
72ecbec49d
|
Merge pull request #6292 from Snuffleupagus/issue-6287
Fix various shading pattern regressions (issue 6287)
|
2015-07-31 22:26:01 +02:00 |
|
Jonas Jenwald
|
1d65daf5e5
|
Correctly access colorSpace.numComps in MeshStreamReader (issue 6287)
This regressed in f750e35224.
|
2015-07-31 18:00:58 +02:00 |
|
Jonas Jenwald
|
7fe2442a18
|
Ensure that we don't use the same typed array for both coords and colors in Mesh figures (issue 6287)
This regressed in 1e8d70af98.
|
2015-07-31 18:00:23 +02:00 |
|
Jonas Jenwald
|
55bc98a8b0
|
Rename PatternType to ShadingType to avoid confusion
The current name is somewhat confusing, since the specification calls it `ShadingType`, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.4044105 and http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.3882826.
The real problem, however, is that there is actually another property called `PatternType`, which makes the current code very confusing, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.1850929.
Since `ShadingType` is only relevant for shading patterns (i.e. `PatternType === 2`), and *not* for tiling patterns (i.e `PatternType === 1`), this patch should help reduce confusion when reading the code.
|
2015-07-30 20:03:45 +02:00 |
|
Yury Delendik
|
35474628e3
|
Merge pull request #5449 from CodingFabian/preferParamsOverArguments
Use 3 param method for converting r,g,b into css string.
|
2014-12-08 15:23:12 -06:00 |
|
Fabian Lange
|
ceffeab1de
|
Use 3 param method for converting r,g,b into css string.
This avoids creation of temporary arrays to pass them into the util
method. Also using "arguments" is more expensive then passing in 3
parameters.
|
2014-12-05 19:25:02 +01:00 |
|
Jonas Jenwald
|
78d0d269dc
|
Fallback to the |Dummy| Pattern when we fail to parse a Shading Pattern (issue 5509)
|
2014-11-30 21:21:45 +01:00 |
|
Yury Delendik
|
f750e35224
|
Optimizes functions to not create arrays
|
2014-08-04 11:23:11 -05:00 |
|
Jonas Jenwald
|
ee371fe6b2
|
Add strict equalities in src/core/pattern.js
|
2014-08-01 21:56:04 +02:00 |
|
Rob Wu
|
2e97c0d085
|
Remove some unused variables from src/
Only obviously useless, local variables have been removed.
|
2014-04-15 17:10:23 +02:00 |
|
Tim van der Meij
|
df91acf239
|
Fixes lint warning W004 in src/core
|
2014-04-11 00:41:08 +02:00 |
|
Yury Delendik
|
1e8d70af98
|
Prescales shading pattern packed data indices
|
2014-04-03 08:34:20 -05:00 |
|
Yury Delendik
|
561683d2e9
|
Dynamically determines how to split patch into triangles
|
2014-01-29 10:39:06 -06:00 |
|
Yury Delendik
|
a583c319a1
|
Implements shading types 4-7
|
2014-01-27 20:35:51 -06:00 |
|
Yury Delendik
|
bf432a37bb
|
Refactors shared/pattern.js into core/ and display/
|
2014-01-25 12:18:22 -06:00 |
|