Brendan Dahl
4824baf31c
Merge pull request #5905 from timvandermeij/specialpowers
...
Remove SpecialPowers addon
2015-04-27 10:36:54 -07:00
Tim van der Meij
080ab204d6
Merge pull request #5953 from Snuffleupagus/issue-3498
...
Remove no longer needed hacks that enable spacebar scrolling in Firefox (issue 3498)
2015-04-27 19:10:49 +02:00
Tim van der Meij
c91f736db7
Merge pull request #5966 from Snuffleupagus/lint-viewer-preprocesser-code
...
Enable linting of Firefox specific code in viewer.js
2015-04-27 18:59:55 +02:00
Jonas Jenwald
5c47a7f596
Merge pull request #5959 from timvandermeij/document-properties-class
...
Refactor document properties overlay
2015-04-27 16:29:26 +02:00
Jonas Jenwald
dfecfca266
Merge pull request #5809 from Snuffleupagus/issue-5801
...
Attempt to infer if a CMap file actually contains just a standard Identity-H/Identity-V map
2015-04-27 16:19:30 +02:00
Tim van der Meij
6abf3d6ba3
Simplify document properties field logic
...
This patch:
- Simplifies the way fields are passed to the document properties overlay
- Simplifies the way fields are filled internally in the document properties overlay
- Avoids passing a document properties reference to the secondary toolbar
2015-04-27 15:25:40 +02:00
Jonas Jenwald
91ce16bc1d
Enable linting of Firefox specific code in viewer.js
...
- This patch uncomments a large portion of the Firefox specific code in viewer.js, by using a preprocessor "trick", to enable linting. Doing this actually uncovered some issues, e.g. variables defined multiple times.
- This patch also fixes a spelling error, `adobe pdfwritter` -> `abobe pdfwriter`, in the `KNOWN_GENERATORS` list used when reporting telemetry data in Firefox.
*Please note:* there's still some Firefox specific code that is commented out, but it's usually just one (or two) lines of code. Hence the risk that errors creep in should be much lower, compared to entire code-blocks.
2015-04-26 19:52:09 +02:00
Tim van der Meij
1a5de56675
Group public/private methods and add comments
...
This patch:
- Puts public methods at the top of the file
- Puts private methods below the public methods and marks them with an underscore
- Adds JSDoc comments to the class
- Adds setDocumentAndUrl to avoid having to handle that in `viewer.js`
2015-04-26 15:50:28 +02:00
Tim van der Meij
2bbe872ee8
Merge pull request #5963 from CodingFabian/enhance-bug-reporting-guide
...
Clarify bug reporting with regards to providing a pdf
2015-04-26 15:15:53 +02:00
Jonas Jenwald
760222cf0b
Handle the Encoding being a dictionary in PartialEvaluator_preEvaluateFont (bug 1157493)
...
*This is a regression from PR 4423.*
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1157493 .
2015-04-25 16:48:14 +02:00
Fabian Lange
2175b87dbe
Clarify bug reporting with regards to providing a pdf
2015-04-25 14:42:37 +02:00
Jonas Jenwald
4a022bc40a
Add a reduced test-case for issue 5801
2015-04-25 11:28:33 +02:00
Jonas Jenwald
7c7d05e7a3
Attempt to infer if a CMap file actually contains just a standard Identity-H
/Identity-V
map
2015-04-25 11:28:33 +02:00
Tim van der Meij
48b2f6d023
Merge pull request #5756 from Snuffleupagus/issue-5751
...
Guess CIDFontType0 subtype based on font file contents (issue 5751)
2015-04-24 23:50:07 +02:00
Tim van der Meij
7cf440c560
Refactor PDFDocumentProperties to be more class-like
2015-04-24 20:47:38 +02:00
Tim van der Meij
ca8f842d87
Rename DocumentProperties to PDFDocumentProperties
2015-04-24 20:35:11 +02:00
Jonas Jenwald
b1c4b85d4f
Change |pages| to be a "private" property of |PDFViewer|
...
As suggested by yurydelendik: http://logs.glob.uno/?c=mozilla%23pdfjs&s=30+Sep+2014&e=30+Sep+2014&h=4150#c26119 , this patch renames `pages` -> `_pages` to indicate that it's a "private" property.
Accessing pages from outside `PDFViewer` should instead be done by using `getPageView`.
2015-04-21 22:40:11 +02:00
Jonas Jenwald
10f134bcc2
Remove no longer needed hacks that enable spacebar scrolling in Firefox (issue 3498)
...
Now that [bug 915962](https://bugzilla.mozilla.org/show_bug.cgi?id=915962 ) has landed, we no longer need any hacks to enable <kbd>spacebar</kbd> scrolling in Firefox.
Fixes 3498.
2015-04-21 22:26:50 +02:00
Tim van der Meij
71ab5e5ac5
Merge pull request #5699 from Snuffleupagus/presentationMode-refactor
...
Refactor the Presentation Mode code
2015-04-21 21:58:59 +02:00
Jonas Jenwald
601bd4a930
Preface all "fullscreen" CSS rules with a |pdfPresentationMode| class, and add it to the |viewerContainer| while Presentation Mode is active
2015-04-21 16:28:50 +02:00
Jonas Jenwald
4211df63eb
Refactor PDFPresentationMode to be more class-like
2015-04-21 16:28:50 +02:00
Jonas Jenwald
4edee12e92
Re-ordering the PDFPresentationMode code so that the "public" functions are placed towards the top of the file
2015-04-21 16:28:49 +02:00
Jonas Jenwald
d5089f42fa
Initial refactoring of the PDFPresentationMode code
...
Noteworthy changes:
- Adds JSDoc comments to PDFPresentationMode.
- Removes a couple of, no longer necessary, helper functions.
2015-04-21 16:28:49 +02:00
Jonas Jenwald
f15d5c8cfe
Rename the presentation_mode.js file and adjust the function names
...
Also moves the |fullscreenchange| event listeners into PDFPresentationMode.
2015-04-21 16:28:48 +02:00
Jonas Jenwald
e7fd5b4d4d
Refactor the options passed to |PresentationMode.initialize| and clean-up some code in viewer.js and presentation_mode.js
...
This patch:
- Passes in a reference to the current PDFThumbnailViewer, which is used to ensure that the current thumbnail becomes visible when exiting PresentationMode.
- Changes the way that the event listeners for the contextmenu items are defined, to avoid passing in a reference to the SecondaryToolbar.
- Ensures that |supportsFullscreen| always returns a boolean.
Currently `supportsFullscreen` will, when the browser supports the fullscreen API, return e.g. `function mozRequestFullScreen()` instead of `true`.
- Simplifies the |click| handler code when PresentationMode is active.
This code has been obsolete ever since PR 2919 landed.
- Removes hack used to workaround a bug in WebKit browsers, which caused |mousemove| events to be fired when the cursor changed.
This was fixed close to a year ago, see http://code.google.com/p/chromium/issues/detail?id=103041 .
2015-04-21 16:27:41 +02:00
Jonas Jenwald
95b2ec124b
Move the PresentationMode-specific scrollWheel code from PDFViewerApplication
2015-04-21 16:08:37 +02:00
Jonas Jenwald
2dc1af8028
Break dependencies between PresentationMode and other code, and add PresentationMode related utility methods to PDFViewer
...
This patch:
- Adds a couple of utility methods to `PDFViewer` to enable checking `presentationModeState` without cumbersome comparisons.
- Disentangles `PresentationMode` from `PDFHistory` and `HandTool`, by adding event listeners for `presentationmodechanged` to both of them.
- Adds a utility function to `PDFViewerApplication` for requesting PresentationMode.
- Prevents initialization of `PresentationMode` if the browser does not support the fullscreen API.
2015-04-21 16:02:32 +02:00
Brendan Dahl
846eb967cc
Merge pull request #5655 from Snuffleupagus/issue-5644
...
Avoid getting stuck in empty nodes in the Pages tree when calling |Catalog_getPageDict| (issue 5644)
2015-04-20 11:46:27 -07:00
Jonas Jenwald
c47d60f865
Merge pull request #5951 from arai-a/bug1156287
...
Bug 1156287 - Do not extract unreachable code after return
2015-04-20 17:46:11 +02:00
Yury Delendik
ebd6ce33b5
Merge pull request #5917 from Snuffleupagus/bug-1148192-review-comments
...
Address review comments from Bug 1148192 - Update pdf.js to version 1.1.24
2015-04-20 10:23:52 -05:00
arai
5c4e3c31b8
Bug 1156287 - Do not extract unreachable code after return
2015-04-21 00:22:45 +09:00
Jordan Thoms
d0ea772fc6
Fix error reading concatenated pdfs
2015-04-18 20:56:07 +12:00
Tim van der Meij
180a5a2746
Merge pull request #5945 from marco-c/use_int32array
...
Use Int32Array instead of Uint32Array in FlateStream
2015-04-17 20:37:23 +02:00
Jonas Jenwald
4c2ad3bc7b
Ensure that entries in the Differences array of Type1 fonts are either numbers or names
...
This patch is yet another installment in the (never ending) series of bugs in PDF files with non-embedded fonts.
Fixes http://www.int.washington.edu/talks/WorkShops/int_08_37W/People/Franz_M/Franz.pdf .
2015-04-17 20:32:27 +02:00
Tim van der Meij
62c3db0bf5
Merge pull request #5944 from marco-c/better_error_message_if_browser_path_doesnt_exist
...
Fail with a more informative error message if the browser executable pat...
2015-04-17 20:21:50 +02:00
Marco Castelluccio
1bd952f897
Use Int32Array instead of Uint32Array in FlateStream
2015-04-17 16:33:04 +02:00
Marco Castelluccio
fbae39983c
Fail with a more informative error message if the browser executable path doesn't exist
2015-04-17 16:12:13 +02:00
Brendan Dahl
63aaf1b969
Merge pull request #5923 from Snuffleupagus/bug-911034
...
Don't map glyphs to certain problematic General Punctuation Unicode locations (bug 911034)
2015-04-15 14:31:54 -07:00
Jonas Jenwald
cadbb81fb9
Merge pull request #5937 from gettalong/patch-1
...
Crypt filter EFF key should have StmF value as default, not StrF
2015-04-15 13:02:05 +02:00
Jonas Jenwald
cba36bc37e
Merge pull request #5936 from arfon/master
...
Update .gitattributes to fix GitHub file type detection for JavaScript.
2015-04-14 16:48:44 +02:00
Arfon Smith
15edae56e5
Update .gitattributes to fix GitHub file type detection for JavaScript.
2015-04-14 09:28:55 -05:00
Thomas Leitner
3ebc85e55f
Crypt filter EFF key should have StmF value as default, not StrF
...
This fixes the problem.
2015-04-13 21:27:32 +02:00
Tim van der Meij
e4e9a2adea
Merge pull request #5926 from browtayl/1018932
...
prevent viewer from zooming on cmd+mousewheel (bug 1018932)
2015-04-13 20:57:23 +02:00
Tim van der Meij
dbcc3a77fa
Merge pull request #5933 from Snuffleupagus/viewer-comment-cleanup
...
Remove commented out code from viewer.html
2015-04-13 20:18:05 +02:00
Jonas Jenwald
bc0d55bf43
Remove commented out code from viewer.html
...
The line that this patch removes has been commented out since 2012 (!), see commit c8a6a9ba00
.
Also, since the patch is trivial, I'm fixing the formatting of a comment to stop [GitHub from marking it with a red color](https://github.com/mozilla/pdf.js/blob/master/web/viewer.html#L394 ) (and IE from complaining).
2015-04-13 12:44:05 +02:00
Taylor Brown
34d3b96b52
prevent viewer from zooming on cmd+mousewheel
2015-04-10 15:08:32 -07:00
Jonas Jenwald
fda858ae33
Don't map glyphs to certain problematic General Punctuation Unicode locations (bug 911034)
...
Fixes the remaining missing characters in https://bugzilla.mozilla.org/show_bug.cgi?id=911034 .
For reference, see http://www.unicode.org/charts/PDF/U2000.pdf (and also http://en.wikipedia.org/wiki/General_Punctuation_%28Unicode_block%29 ).
2015-04-09 17:27:03 +02:00
Jonas Jenwald
a54ec673c5
Move the checks for problematic Unicode locations from |adjustMapping| to a separate helper function
2015-04-09 12:56:29 +02:00
Jonas Jenwald
1d6fae231e
Merge pull request #5912 from timvandermeij/shelljs
...
Remove ShellJS copy and use the NPM version
2015-04-07 20:24:16 +02:00
Jonas Jenwald
9f63fa4b07
Address review comments from Bug 1148192 - Update pdf.js to version 1.1.24
...
See https://bugzilla.mozilla.org/show_bug.cgi?id=1148192#c3 .
2015-04-06 16:26:23 +02:00