Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
18,154 Commits 1 Branch 80 Tags 254 MiB
89bb0c9e66
Commit Graph

18154 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Calixte Denizet
050093c9f5 [Editor] Tweak the save flow in the alt-text dialog 
When the user edit an existing alt-text and remove it, we want to be able
to save this state and consequently remove the done state from the
alt-text button.
Remove the button from its parent when the editor is removed: it should
help to save few Kb of memory.
 2023-09-22 17:10:20 +02:00
calixteman
3f859f76e6
Merge pull request #17010 from calixteman/alt_text_mask_1 
[Editor] Darken the toolbar when the alt-text dialog is opened
 2023-09-22 13:34:57 +02:00
Jonas Jenwald
eff7ed580d
Merge pull request #17009 from Snuffleupagus/altText-label-clicks 
[Editor] Make the altText dialog labels part of telemetry (PR 16987 follow-up)
 2023-09-22 13:26:57 +02:00
Calixte Denizet
0237e2eb2b [Editor] Darken the toolbar when the alt-text dialog is opened 
It aims to fix the issue spotted in:
https://github.com/mozilla/pdf.js/pull/17002#issuecomment-1730962273
 2023-09-22 13:11:37 +02:00
Jonas Jenwald
ee5b8bcf9e [Editor] Make the altText dialog labels part of telemetry (PR 16987 follow-up) 
Radio-buttons can also be toggled by clicking on their associated `label`-elements, and not only the `input`-elements itself, however it seems that "pointerdown" event listeners don't cover that case.
Hence it's possible that telemetry could miss certain cases of a mouse being used, and the easiest solution seem to be to instead use "click" event listeners and just ignore keyboard-based events.
 2023-09-22 12:26:03 +02:00
calixteman
2fc8ab3477
Merge pull request #17002 from calixteman/alt_text_mask 
[Editor] Avoid to darken the current editor when opening the alt-text dialog
 2023-09-22 12:17:21 +02:00
Jonas Jenwald
edb83ffec2
Merge pull request #17004 from Snuffleupagus/dialog-disable-zooming 
Prevent wheel/touch zooming in the viewer when a dialog is open
 2023-09-22 09:19:19 +02:00
Jonas Jenwald
988222d7de
Merge pull request #17003 from Snuffleupagus/issue-17000 
Restore the `collectFields` parameter in the Annotation code (issue 17000)
 2023-09-22 09:11:52 +02:00
Calixte Denizet
6545551e76 [Editor] Avoid to darken the current editor when opening the alt-text dialog 2023-09-21 20:44:53 +02:00
Jonas Jenwald
9b21f17b03 Prevent wheel/touch zooming in the viewer when a dialog is open 2023-09-21 20:08:08 +02:00
Jonas Jenwald
4cedc12341 Restore the collectFields parameter in the Annotation code (issue 17000) 
Rather than trying to be "clever" here, and possibly affect code readability negatively, let's just restore the `collectFields` parameter to address the unneeded parsing that now happens when printing new Annotations.
 2023-09-21 19:49:31 +02:00
Jonas Jenwald
e9f707ce3f
Merge pull request #16999 from Snuffleupagus/issue-16994 
[GeckoView] Exclude `annotation_editor_layer_builder.css` in the build (issue 16994)
 2023-09-21 19:26:50 +02:00
Jonas Jenwald
5711d0f95d [GeckoView] Exclude annotation_editor_layer_builder.css in the build (issue 16994) 
Given the limitations of the old pre-processor that's used for CSS/HTML files, this unfortunately isn't as "easy" to implement as it is for JavaScript code.
Since this is the first case where we've wanted to do conditional CSS imports, rather than trying to completely re-write the pre-processor, this patch settles for handling it explicitly in the `expandCssImports` function.
 2023-09-21 15:51:33 +02:00
calixteman
a7894a4d7b
Merge pull request #16993 from Snuffleupagus/gv-no-AltTextManager 
[GeckoView] Avoid bundling the `AltTextManager` class, since it's unused
 2023-09-21 14:19:51 +02:00
calixteman
9de432ba7a
Merge pull request #16998 from calixteman/fix_css_linter_issue_1 
Make one of the m-c linters happy
 2023-09-21 14:14:56 +02:00
Calixte Denizet
61c77c7d8b Make one of the m-c linters happy 2023-09-21 14:09:48 +02:00
calixteman
b002d16f04
Merge pull request #16996 from Snuffleupagus/issue-16995 
Enable the Stylelint `declaration-block-no-duplicate-properties` rule (issue 16995)
 2023-09-21 13:52:54 +02:00
Jonas Jenwald
80e691d2ad Enable the Stylelint declaration-block-no-duplicate-properties rule (issue 16995) 
Please refer to https://stylelint.io/user-guide/rules/declaration-block-no-duplicate-properties
 2023-09-21 13:42:05 +02:00
Jonas Jenwald
e2b7896826 [GeckoView] Avoid bundling the AltTextManager class, since it's unused 2023-09-21 12:51:34 +02:00
calixteman
561aea530b
Merge pull request #16991 from Snuffleupagus/alt_text_edit-boolean 
Ensure that all "alt_text_*" save-telemetry values are boolean (PR 16987 follow-up)
 2023-09-21 11:04:06 +02:00
calixteman
237b8ce4a8
Merge pull request #16988 from calixteman/alt_text_dialog_others 
[Editor] Tweak few values after review from UX
 2023-09-21 11:03:19 +02:00
calixteman
67ddabcbc2
Merge pull request #16990 from calixteman/alt_text_aria_label 
[Editor] Add an aria-label to the alt-text button depending on its state
 2023-09-21 10:56:25 +02:00
Calixte Denizet
b5d18006a7 [Editor] Tweak few values after review from UX 2023-09-21 10:52:58 +02:00
Jonas Jenwald
5660cdfe68 Ensure that all "alt_text_*" save-telemetry values are boolean (PR 16987 follow-up) 
Looking at the save-telemetry values they're all boolean *except* for "alt_text_edit" in one instance, since `this.#previousAltText` may be an empty string (looking at the `editAltText` method) and this value may thus become an empty string as well.
 2023-09-21 08:36:41 +02:00
Jonas Jenwald
34506f8874
Merge pull request #16989 from Snuffleupagus/more-reporttelemetry-event 
Use the new "reporttelemetry" event in more viewer components
 2023-09-20 22:06:14 +02:00
Calixte Denizet
c90ea2314e [Editor] Add an aria-label to the alt-text button depending on its state 2023-09-20 21:56:16 +02:00
Jonas Jenwald
fe60db27b1 Use the new "reporttelemetry" event in more viewer components 
By utilizing the recently added "reporttelemetry" event, we can avoid having to manually pass in `externalServices` to a number of viewer components.
 2023-09-20 20:18:10 +02:00
calixteman
f2d75d9221
Merge pull request #16985 from calixteman/btn_bg 
[Editor] Change the colors for the disabled Save button in alt text dialoag in HCM
 2023-09-20 19:03:01 +02:00
Calixte Denizet
7d0bf376d0 [Editor] Change the colors for the disabled Save button in alt text dialoag in HCM 2023-09-20 18:58:31 +02:00
calixteman
67646387c8
Merge pull request #16986 from calixteman/alt_text_contents 
[Editor] Change some strings in the alt-text dialog
 2023-09-20 18:52:37 +02:00
Calixte Denizet
9a677d0d4d [Editor] Change some strings in the alt-text dialog 2023-09-20 18:44:56 +02:00
calixteman
0317d3e168
Merge pull request #16987 from calixteman/alt_text_telemetry 
[Editor] Add more telemetry for the 'add image' feature (bug 1853960)
 2023-09-20 17:34:59 +02:00
Calixte Denizet
0a278ef0bc [Editor] Add more telemetry for the 'add image' feature (bug 1853960) 2023-09-20 17:23:23 +02:00
calixteman
b80e0d881d
Merge pull request #16984 from Snuffleupagus/altText-close 
Don't try to close the `altText` dialog if it's not open (PR 16977 follow-up)
 2023-09-20 11:14:28 +02:00
calixteman
b7fa4fb0f7
Merge pull request #16983 from calixteman/alt_text_tooltip 
[Editor] Add a tooltip showing the alt text when hovering the alt-text button (bug 1844952)
 2023-09-20 11:00:31 +02:00
Calixte Denizet
7952a36384 [Editor] Add a tooltip showing the alt text when hovering the alt-text button (bug 1844952) 2023-09-20 10:50:28 +02:00
Jonas Jenwald
21c55b56bf Don't try to close the altText dialog if it's not open (PR 16977 follow-up) 
When closing a document in the viewer, e.g. by running `PDFViewerApplication.close()` in the console, the `AltTextManager.#finish` method currently throws *unless* the `altText` dialog is actually open.
Similar to e.g. the PasswordPrompt, we should thus only attempt to close the `altText` dialog when it's open.
 2023-09-20 07:59:46 +02:00
calixteman
8d326e5e30
Merge pull request #16982 from calixteman/alt_text_rm_copy_listeners 
[Editor] Remove copy/paste listener when alt text dialog is displayed
 2023-09-19 22:52:49 +02:00
Calixte Denizet
c162b004ce [Editor] Remove copy/paste listener when alt text dialog is displayed 2023-09-19 22:41:47 +02:00
calixteman
54f6264d5b
Merge pull request #16977 from calixteman/add_alt_text 
[Editor] Allow the user to add and save an alt-text for images (bug 1844952)
 2023-09-19 21:59:59 +02:00
Calixte Denizet
c12049db07 [Editor] Allow the user to add and save an alt-text for images (bug 1844952) 2023-09-19 21:46:48 +02:00
Jonas Jenwald
29a48f9479
Merge pull request #16981 from Snuffleupagus/optionalContent-type-missing 
Ignore optional content with missing /Type-entries
 2023-09-19 15:15:00 +02:00
Jonas Jenwald
0ac8f33e13 Ignore optional content with missing /Type-entries 
In the rare situation that an optional content dictionary lacks a /Type-entry we currently throw, which may prevent e.g. Form XObjects from rendering completely.

Fixes https://bugs.ghostscript.com/show_bug.cgi?id=707147
 2023-09-19 14:11:03 +02:00
calixteman
daae6589b6
Merge pull request #16979 from calixteman/alt_text_change_str1 
[Editor] Update alt text dialog description
 2023-09-19 10:36:50 +02:00
calixteman
b9469c2059
Merge pull request #16980 from calixteman/rounded_resizers 
[Editor] Make the border of the resizers slightly rounded
 2023-09-19 10:12:11 +02:00
Calixte Denizet
f7870c04ae [Editor] Make the border of the resizers slightly rounded 
It's a part of the UX specifications. There's a drawing issue in Firefox
(see bug https://bugzilla.mozilla.org/1853288) but setting the
background-clip property to content-box seems to be a good workaround.
 2023-09-19 09:57:00 +02:00
Calixte Denizet
0df9d1d934 [Editor] Update alt text dialog description 2023-09-19 09:27:43 +02:00
calixteman
5ac40b71c0
Merge pull request #16952 from calixteman/alt_text_window 
[Editor] Add a dialog box in order to get alt-text data (bug 1844952)
 2023-09-18 21:49:33 +02:00
Calixte Denizet
df0da86b64 [Editor] Add a dialog box in order to get alt-text data (bug 1844952) 
Implement the specifications provided by UX for light, dark and HCM modes.
 2023-09-18 21:42:52 +02:00
calixteman
c0ed7fff2c
Merge pull request #16975 from calixteman/alt_text_fix_icon_dims 
[Editor] Use the same height as in the svg for icons for the alt-text button
 2023-09-18 19:53:48 +02:00