Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #17009 from Snuffleupagus/altText-label-clicks

Browse Source 
[Editor] Make the altText dialog labels part of telemetry (PR 16987 follow-up)
This commit is contained in:
Jonas Jenwald 2023-09-22 13:26:57 +02:00 committed by GitHub
commit eff7ed580d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
web/alt_text_manager.js
View File

@ -20,7 +20,7 @@ class AltTextManager {
#boundSetPosition = this.#setPosition.bind(this);
#boundPointerDown = this.#pointerDown.bind(this);
#boundOnClick = this.#onClick.bind(this);
#currentEditor = null;
@ -133,7 +133,7 @@ class AltTextManager {
this.#hasUsedPointer = false;
for (const element of this._elements) {
element.addEventListener("pointerdown", this.#boundPointerDown);
element.addEventListener("click", this.#boundOnClick);
}
const { altText, decorative } = editor.altTextData;
@ -243,7 +243,7 @@ class AltTextManager {
}
#close() {
this.#removePointerDownListeners();
this.#removeOnClickListeners();
this.#uiManager?.addEditListeners();
this.#eventBus._off("resize", this.#boundSetPosition);
this.#currentEditor = null;
@ -283,14 +283,17 @@ class AltTextManager {
this.#finish();
}
#pointerDown() {
#onClick(evt) {
if (evt.detail === 0) {
return; // The keyboard was used.
}
this.#hasUsedPointer = true;
this.#removePointerDownListeners();
this.#removeOnClickListeners();
}
#removePointerDownListeners() {
#removeOnClickListeners() {
for (const element of this._elements) {
element.removeEventListener("pointerdown", this.#boundPointerDown);
element.removeEventListener("click", this.#boundOnClick);
}
}