Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,603 Commits 1 Branch 80 Tags 254 MiB
3d18c76a53
Commit Graph

14603 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Brendan Dahl
3d18c76a53
Merge pull request #13881 from calixteman/bug_1723734 
XFA - Elements under an area must be bound (bug 1723734)
 2021-08-06 11:56:58 -07:00
Calixte Denizet
328383ea7a XFA - Elements under an area must be bound (bug 1723734) 
- aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1723734.
 2021-08-06 20:20:19 +02:00
calixteman
98e893b84f
Merge pull request #13880 from eltociear/patch-5 
Fix typo in cff_parser_spec.js
 2021-08-06 19:31:52 +02:00
Brendan Dahl
d7e1a419c2
Merge pull request #13873 from brendandahl/xfa-heading 
XFA - Support aria heading and table structure. (bug 1723421) (bug 1723425)
 2021-08-06 09:54:47 -07:00
Ikko Ashimine
23236f1b0b
Fix typo in cff_parser_spec.js 
shoudn't -> shouldn't
 2021-08-06 19:30:36 +09:00
Brendan Dahl
a38d1122d8 XFA - Support aria heading and table structure. (bug 1723421) (bug 1723425) 
https://bugzilla.mozilla.org/show_bug.cgi?id=1723421
https://bugzilla.mozilla.org/show_bug.cgi?id=1723425
 2021-08-05 15:25:04 -07:00
Tim van der Meij
849bab973c
Merge pull request #13874 from Snuffleupagus/components-annotation-zoom-factor 
Update the Annotation `--zoom-factor` CSS variable when `PDFPageView` is used standalone (PR 13868 follow-up)
 2021-08-05 22:28:51 +02:00
Tim van der Meij
8292076af9
Merge pull request #13869 from Snuffleupagus/test-resources-lint 
Enable linting in the `test/resources/` folder, and fix the "Remote property injection" warning (issue 13862)
 2021-08-05 22:17:26 +02:00
calixteman
834e475e1d
Merge pull request #13875 from calixteman/xfa_focus 
Annotation & XFA: Add focus outlines on different fields (bug 1723615, bug 1718528)
 2021-08-05 20:09:00 +02:00
Calixte Denizet
fef939d347 Annotation & XFA: Add focus outlines on different fields (bug 1723615, bug 1718528) 
- set a default tabindex to be sure they'll be taken into account in the TAB cycle (https://bugzilla.mozilla.org/show_bug.cgi?id=1723615).
  - show default outline when fields are focused (it was an a11y bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1718528).
 2021-08-05 13:33:46 +02:00
Jonas Jenwald
561faa7c94 Update the Annotation --zoom-factor CSS variable when PDFPageView is used standalone (PR 13868 follow-up) 
Without this patch, when using `PDFPageView` directly[1] this CSS variable won't be updated and consequently things won't work as intended.
This is purposely implemented such that when a `PDFPageView`-instance is part of a viewer, we don't repeatedly set the CSS variable for every single page.

---
[1] See e.g. the "pageviewer" example in the `examples/components/` folder.
 2021-08-05 11:43:43 +02:00
Jonas Jenwald
4ad65c8b9c
Merge pull request #13868 from calixteman/zoom_select 
Annotation & XFA: Scale the font size in choicelist using zoom factor (bug 1715996)
 2021-08-05 10:45:13 +02:00
Calixte Denizet
71a100a4d0 Annotation & XFA: Scale the font size in choicelist using zoom factor (bug 1715996) 
- this is an accessibility issue which could be painful for some people with visual disabilities.
 2021-08-04 20:36:04 +02:00
Jonas Jenwald
39663e730e Change the hashParameters function to return a Map rather than an Object (issue 13862) 
This patch (basically) mirrors the implementation in PR 13831, to get rid of the "Remote property injection" warning.
 2021-08-04 15:17:13 +02:00
Jonas Jenwald
5dfdfbc70b Fix *some* of the remaining linting issues in test/resources/reftest-analyzer.js 
Given that issue 13862 tracks updating/modernizing the code, this patch purposely limits the scope of the changes. In particular, the following things are still left to address:
 - The ESLint `no-undef` errors; for now the rule is simply disabled globally in this file.
 - A couple of unused variables are commented out for now, but could perhaps just be removed.
 2021-08-04 14:14:04 +02:00
Jonas Jenwald
92300965a4 Fix *most* linting/formatting issues in the test/resources/ folder 
These changes were done automatically, by using the `gulp lint --fix` command.
 2021-08-04 13:59:21 +02:00
Jonas Jenwald
99aa747a1d Include the test/resources/ folder when running ESLint/Stylelint 
Also, update the `.stylelintignore` file to agree with the `.eslintignore` file since the configurations had (unintentionally) diverged.
 2021-08-04 13:50:44 +02:00
calixteman
52ef63f1fe
Merge pull request #13856 from calixteman/xfa_layout_rounding 
XFA - Avoid to put something in very small areas
 2021-08-04 10:09:13 +02:00
Brendan Dahl
2cef6d8796
Merge pull request #13864 from brendandahl/xfa-alt-text 
[XFA] Add alt text for images. (bug 1723418)
 2021-08-03 18:42:31 -07:00
Brendan Dahl
3e003245b1 [XFA] Add alt text for images. (bug 1723418) 
Not many XFA PDFs have alt text.

Some examples:
bug1723422.pdf
xfa_bug1718670_1.pdf
xfa_issue13611.pdf
xfa_issue13633.pdf
xfa_issue13634.pdf
 2021-08-03 17:18:58 -07:00
Brendan Dahl
6cf1ee3251
Merge pull request #13858 from brendandahl/xfa-aria-label 
Add aria-labels to XFA form elements. (bug 1723422)
 2021-08-03 17:18:08 -07:00
Brendan Dahl
6ea56f35ab Add aria-labels to XFA form elements. (bug 1723422) 2021-08-03 15:58:33 -07:00
Tim van der Meij
b317e9311d
Merge pull request #13846 from Snuffleupagus/test-xfa 
Add a special `gulp xfatest` command, to limit the ref-tests to only XFA-documents (issue 13744)
 2021-08-03 23:47:30 +02:00
Jonas Jenwald
844319cdb0 Add a special gulp xfatest command, to limit the ref-tests to only XFA-documents (issue 13744) 
The new command is a *variation* of the standard `gulp test` command and will run all unit/font/integration-tests just as normal, while *only* running ref-tests for XFA-documents to speed up development.
Given that we currently have (some) unit-tests for XFA-documents, and that we may also (in the future) want to add integration-tests, it thus makes sense to run all test-suites in my opinion.

*Please note:* Once this patch has landed, I'll submit a follow-up patch to https://github.com/mozilla/botio-files-pdfjs such that we can also run the new command on the bots.
 2021-08-03 23:41:10 +02:00
Tim van der Meij
85be62c684
Merge pull request #13854 from Snuffleupagus/issue-13851 
Prevent breaking errors when an optional content group is undefined (issue 13851)
 2021-08-03 23:34:34 +02:00
Tim van der Meij
ad90fe90ed
Merge pull request #13848 from Snuffleupagus/rm-lgtm 
Remove the LGTM configuration and inline disable comments (issue 13829)
 2021-08-03 23:13:05 +02:00
Tim van der Meij
892af51269
Merge pull request #13859 from Snuffleupagus/refactor-EOF 
Remove the `isEOF` helper function and slightly re-factor `EOF`
 2021-08-03 23:11:10 +02:00
Jonas Jenwald
ad702d7088
Merge pull request #13860 from mozilla/dependabot/npm_and_yarn/tar-4.4.15 
Bump tar from 4.4.8 to 4.4.15
 2021-08-03 22:20:32 +02:00
dependabot[bot]
81a6ade590
Bump tar from 4.4.8 to 4.4.15 
Bumps [tar](https://github.com/npm/node-tar) from 4.4.8 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v4.4.8...v4.4.15)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-08-03 19:41:11 +00:00
Jonas Jenwald
766299016f Remove the isEOF helper function and slightly re-factor EOF 
Given how trivial the `isEOF` function is, we can simply inline the check at the various call-sites and remove the function (which ought to be ever so slightly more efficient as well).
Furthermore, this patch also changes the `EOF` primitive itself to a `Symbol` instead of an Object since that has the nice benefit of making it unclonable (thus preventing *accidentally* trying to send `EOF` from the worker-thread).
 2021-08-03 20:19:32 +02:00
Calixte Denizet
be1ee155d1 XFA - Avoid to put something in very small areas 
- it aims to fix #13855.
 2021-08-03 17:05:29 +02:00
calixteman
0b95d698d8
Merge pull request #13852 from calixteman/xfa_print_1 
XFA - Page can be too small when printing (bug 1723705)
 2021-08-03 16:28:26 +02:00
Jonas Jenwald
d5e14d3dc3 Prevent breaking errors when an optional content group is undefined (issue 13851) 
In the referenced PDF document *most* of the form `/Form` XObjects don't have an `/OC` entry, which thus causes the runtime failure during rendering.
 2021-08-03 15:59:29 +02:00
Calixte Denizet
19309c1f28 XFA - Page can be too small when printing (bug 1723705) 2021-08-03 15:07:33 +02:00
Jonas Jenwald
d5302315ce
Merge pull request #13847 from Snuffleupagus/issue-13835 
Remove useless assignment of `availableSpace` in the `src/core/xfa/template.js` file (issue 13829, 13835)
 2021-08-03 11:49:01 +02:00
Jonas Jenwald
8fef8630fe Remove the LGTM configuration and inline disable comments (issue 13829) 
Given that the GitHub Advanced Security workflow now covers everything that LGTM does, but generally faster and with better GitHub-integration, there's no longer much point in also running LGTM separately.
As a follow-up to this patch, we should also disable/remove the LGTM-integration from the PDF.js repository.
 2021-08-03 11:14:49 +02:00
Jonas Jenwald
705d1cfad3 Remove useless assignment of availableSpace in the src/core/xfa/template.js file (issue 13829, 13835) 2021-08-03 10:58:57 +02:00
Jonas Jenwald
01fd0f59b7
Merge pull request #13842 from Rob--W/text-selection-br 
Visually hide br in text selections
 2021-08-01 21:30:53 +02:00
Jonas Jenwald
bcdf006a71
Merge pull request #13841 from Rob--W/crx-viewerCssTheme 
Allow customization of theme in Chrome extension + set default theme
 2021-08-01 20:32:56 +02:00
Rob Wu
1eeb153688 Visually hide br in text selections 
Fixes #13840
 2021-08-01 19:42:05 +02:00
Rob Wu
a51b4a9cb0 [CRX] Use dark theme by default in Chrome extension 
Default to the dark theme for consistency with the previous version of the
published extension (was 12ff252751).
 2021-08-01 19:37:49 +02:00
Rob Wu
867150e4f0 [CRX] Add option to customize Theme in options UI 
The `viewerCssTheme` option was not rendered because its entry in
`preferences_schema.json` did not have a `title`.

The order of keys in `preferences_schema.json` determines the order of the
rendered preferences in the options UI. Since `viewerCssTheme` affects the UI
very significantly, I have moved the option to the top.
 2021-08-01 18:54:49 +02:00
Tim van der Meij
4cdac66663
Merge pull request #13839 from Snuffleupagus/issue-13838 
Fix a broken regular expression in the `docId` unit-test (issue 13838, PR 13813 follow-up)
 2021-08-01 18:40:32 +02:00
Jonas Jenwald
16a09eaed8 Fix a broken regular expression in the docId unit-test (issue 13838, PR 13813 follow-up) 
The current regular expression contains a typo, leading to intermittent test-failures for certain `docId`s; sorry about that!
 2021-08-01 15:18:25 +02:00
Tim van der Meij
273cea8675
Merge pull request #13837 from timvandermeij/unit-test-query-string 
Implement unit tests for the `parseQueryString` utility function
 2021-08-01 14:26:33 +02:00
Tim van der Meij
d1c0f8f91c
Implement unit tests for the parseQueryString utility function 
Now that these unit tests are in place, we also take the opportunity to
slightly modernize the code itself by using a `for ... of` loop.
 2021-08-01 14:14:33 +02:00
Tim van der Meij
449f941b7b
Merge pull request #13831 from Snuffleupagus/parseQueryString-Map 
Change the `parseQueryString` function to return a `Map` rather than an Object (issue 13829)
 2021-08-01 12:21:43 +02:00
Jonas Jenwald
1ea8cfa2f2
Merge pull request #13836 from timvandermeij/cmaps 
Fix inefficient regular expressions in `external/cmapscompress/parse.js`
 2021-08-01 12:20:51 +02:00
Tim van der Meij
0d84f57cfa
Fix inefficient regular expressions in external/cmapscompress/parse.js 
The only purpose, according to the README and existing files, is to
parse an integer from those lines, so (\d+) is sufficient for that. This
avoids potential exponential backtracking as flagged by CodeQL. I have
compared the output of the script with and without these changes and the
resulting files are the same.
 2021-08-01 12:12:42 +02:00
Jonas Jenwald
4483cba724
Merge pull request #13833 from tamuratak/add_peer_dep_meta_for_worker_loader 
Make worker-loader optional as peerDependencies. Close #13825.
 2021-08-01 11:28:59 +02:00