Jonas Jenwald
3c78ff5fb0
[api-minor] Implement basic support for OptionalContent Usage dicts (issue 5764, bug 1826783)
...
The following are some highlights of this patch:
- In the Worker we only extract a *subset* of the potential contents of the `Usage` dictionary, to avoid having to implement/test a bunch of code that'd be completely unused in the viewer.
- In order to still allow the user to *manually* override the default visible layers in the viewer, the viewable/printable state is purposely *not* enforced during initialization in the `OptionalContentConfig` constructor.
- Printing will now always use the *default* visible layers, rather than using the same state as the viewer (as was the case previously).
This ensures that the printing-output will correctly take the `Usage` dictionary into account, and in practice toggling of visible layers rarely seem to be necessary except in the viewer itself (if at all).[1]
---
[1] In the unlikely case that it'd ever be deemed necessary to support fine-grained control of optional content visibility during printing, some new (additional) UI would likely be needed to support that case.
2024-03-12 13:18:15 +01:00
calixteman
e647311a89
Merge pull request #17788 from calixteman/bug1881743
...
[Editor] Improve the accessibility of the highlight editor (bug 1881743)
2024-03-11 21:57:11 +01:00
Calixte Denizet
f676c2c0c8
[Editor] Improve the accessibility of the highlight editor (bug 1881743)
2024-03-11 14:21:43 +01:00
Jonas Jenwald
b14f696071
Merge pull request #17711 from Snuffleupagus/importl10n-Fetch-API
...
Use the Fetch API to download the l10n files
2024-03-08 11:51:34 +01:00
Jonas Jenwald
ea4b55a0e6
Update l10n files
2024-03-08 10:09:51 +01:00
Jonas Jenwald
2b407990e2
Use the Fetch API to download the l10n files
...
Given that the Fetch API is supported since Node.js 18 we should be able to use it when downloading l10n files, which allows us to simplify the code and to make it fully `async`.
2024-03-08 10:08:15 +01:00
calixteman
fb9e438442
Merge pull request #17781 from calixteman/stamp_altext_button_cp
...
[Editor] Make sure the alt-text button is there when pasting an image from an other tab
2024-03-07 21:44:53 +01:00
calixteman
406018934a
Merge pull request #17778 from calixteman/highlight_show_all
...
[Editor] Add a toggle button to show/hide all the highlights (bug 1867740)
2024-03-07 18:49:09 +01:00
Calixte Denizet
0f8dda1af0
[Editor] Make sure the alt-text button is there when pasting an image from an other tab
2024-03-07 18:24:34 +01:00
Calixte Denizet
39aeea3e94
[Editor] Add a toggle button to show/hide all the highlights (bug 1867740)
2024-03-07 13:16:59 +01:00
calixteman
6bb6ce6a5d
Merge pull request #17767 from calixteman/automation_win_listener
...
In the m-c automation, give the possibility to remove window listeners when a test ended
2024-03-06 14:39:58 +01:00
Calixte Denizet
6d0835dc52
In the m-c automation, give the possibility to remove window listeners when a test ended
...
The goal is to avoid to have some exceptions in the logs when a test finished.
2024-03-06 14:21:57 +01:00
calixteman
9ee4c6528d
Merge pull request #17776 from calixteman/bug1883609
...
[Annotations] Widget annotations must be in front of the other ones (bug 1883609)
2024-03-06 10:53:11 +01:00
Calixte Denizet
4e1b96c781
[Annotations] Widget annotations must be in front of the other ones (bug 1883609)
2024-03-05 19:04:58 +01:00
calixteman
f634cb533c
Merge pull request #17775 from calixteman/bug1883632
...
[Editor] Let a free highlight be clipped when its bounding box exceeds the page limits (bug 1883632)
2024-03-05 17:14:48 +01:00
Calixte Denizet
bd5875d066
[Editor] Let a free highlight be clipped when its bounding box exceeds the page limits (bug 1883632)
2024-03-05 16:47:07 +01:00
calixteman
f1272ee435
Merge pull request #17771 from calixteman/bug1832519
...
[GeckoView] Remove the open-in-app button (bug 1832519)
2024-03-05 14:11:12 +01:00
calixteman
b447a62fea
Merge pull request #17772 from calixteman/reporttelemetry
...
Don't stringify data for telemetry
2024-03-05 12:54:24 +01:00
Calixte Denizet
ba3e559583
Don't stringify data for telemetry
2024-03-04 20:17:47 +01:00
Calixte Denizet
3cb58f84a2
[GeckoView] Remove the open-in-app button (bug 1832519)
2024-03-04 19:32:12 +01:00
calixteman
c451b6d684
Merge pull request #17764 from calixteman/telemetry_null_stats
...
[Editor] Use a null instead of an empty stats object when sending the telemetry
2024-03-04 19:16:57 +01:00
calixteman
a55f976e2e
Merge pull request #17766 from calixteman/escape_color_picker
...
[Editor] Unselect highlight editor when pressing Escape when the focus is on the color picker without a dropdown menu
2024-03-04 19:16:34 +01:00
calixteman
7c9d3af85b
Merge pull request #17768 from calixteman/bug1883394
...
[Editor] Set the creation method for free highlights to 'main_toolbar' (bug 1883394)
2024-03-04 19:16:15 +01:00
Calixte Denizet
ecb4262b13
[Editor] Set the creation method for free highlights to 'main_toolbar' (bug 1883394)
2024-03-04 16:58:50 +01:00
Calixte Denizet
1859412507
[Editor] Unselect highlight editor when pressing Escape when the focus is on the color picker without a dropdown menu
2024-03-04 16:32:09 +01:00
Calixte Denizet
d096dc79b2
[Editor] Use a null instead of an empty stats object when sending the telemetry
2024-03-04 10:18:24 +01:00
Jonas Jenwald
dd3adc84db
Merge pull request #17761 from Snuffleupagus/thicknessPicker-disabled
...
[Editor] Indicate if the highlight-thickness slider is disabled
2024-03-01 17:01:05 +01:00
Jonas Jenwald
e781b553cb
[Editor] Reduce a bit of CSS duplication for the highlight-thickness "indicators"
2024-03-01 16:18:39 +01:00
Jonas Jenwald
c7e7122e25
[Editor] Indicate if the highlight-thickness slider is disabled
...
The fact that the highlight-thickness can only be changed in "free" mode isn't really obvious visually in the toolbar, so attempt to provide at least some indication of the `disabled`-state by "dimming" the slider.
2024-03-01 16:18:31 +01:00
calixteman
29c493d36b
Merge pull request #17760 from calixteman/fix_quadpoints
...
[Editor] Fix the quadpoints value when serializing an highlight annotation
2024-03-01 13:08:44 +01:00
Calixte Denizet
30101cbb31
[Editor] Fix the quadpoints value when serializing an highlight annotation
...
The coordinates of each point in a box are in the page coordinates system.
2024-03-01 11:36:16 +01:00
Jonas Jenwald
61036383b5
Merge pull request #17710 from Snuffleupagus/pr-17277-followup
...
Simplify the `XMLHttpRequest`-branch in the `fetchData` helper function (PR 17277 follow-up)
2024-03-01 10:23:02 +01:00
calixteman
8f75e34b6f
Merge pull request #17757 from calixteman/bug1881219
...
[Editor] Enable the thickness input when no editors are selected (bug 1881219)
2024-02-29 23:26:49 +01:00
Calixte Denizet
7af90bb8bc
[Editor] Enable the thickness input when no editors are selected (bug 1881219)
2024-02-29 23:05:33 +01:00
calixteman
c409121251
Merge pull request #17756 from calixteman/bug1882248
...
[Editor] Make the delete button clickable with the space key (bug 1882248)
2024-02-29 19:57:57 +01:00
Calixte Denizet
f52bf2836f
[Editor] Make the delete button clickable with the space key (bug 1882248)
2024-02-29 19:05:38 +01:00
calixteman
7cc34cf4a7
Merge pull request #17755 from calixteman/bug1881684
...
[Editor] Add the possibility to move the caret with the keyboard once an highlight has been made (bug 1881684)
2024-02-29 18:38:17 +01:00
Calixte Denizet
a9f47e87d5
[Editor] Add the possibility to move the caret with the keyboard once an highlight has been made (bug 1881684)
2024-02-29 18:18:13 +01:00
Jonas Jenwald
9600c48d4f
Merge pull request #17750 from Snuffleupagus/pr-17748-followup
...
Inline the `HighlightEditor.#telemetryType` getter at its only call-site (PR 17748 follow-up)
2024-02-29 10:34:37 +01:00
Jonas Jenwald
a92b38e71c
Inline the HighlightEditor.#telemetryType getter at its only call-site (PR 17748 follow-up)
2024-02-28 20:47:01 +01:00
calixteman
9fe15d4a01
Merge pull request #17748 from calixteman/highlight_telemetry_followup
...
[Editor] Count the colors used when highlighting whatever the highlight kind is
2024-02-28 20:00:15 +01:00
Calixte Denizet
3a7e638fce
[Editor] Count the colors used when highlighting whatever the highlight kind is
2024-02-28 18:24:24 +01:00
calixteman
07abd647f4
Merge pull request #17737 from calixteman/highlight_telemetry
...
[Editor] Add some telemetry for the highlight feature (bug 1866437)
2024-02-28 15:20:57 +01:00
Calixte Denizet
65342d2bee
[Editor] Add some telemetry for the highlight feature (bug 1866437)
2024-02-28 10:17:11 +01:00
calixteman
b1a04fc184
Merge pull request #17738 from calixteman/issue17730
...
Always add links in the annotation layer
2024-02-28 09:34:10 +01:00
Calixte Denizet
e0b843d991
Always add links in the annotation layer
...
Fixes #17730 .
2024-02-27 22:48:08 +01:00
calixteman
06aef89502
Merge pull request #17733 from calixteman/puppeteer_22_1_0
...
Update puppeteer to 22.3.0
2024-02-27 13:46:30 +01:00
Calixte Denizet
5e7941afbf
Update puppeteer to 22.3.0
2024-02-27 12:19:54 +01:00
calixteman
e42b114e80
Merge pull request #17724 from calixteman/issue17707
...
Avoid to have to wait to zoom after scrolling
2024-02-26 11:05:10 +01:00
Calixte Denizet
9e042e7acc
Avoid to have to wait to zoom after scrolling
...
Allow to zoom with the wheel once the scrolling is finished.
It's now possible to know that thanks to the scrollend event.
Fixes #17707 .
2024-02-25 21:40:48 +01:00
