Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the unused skipCount parameter from Catalog.getPageDict (PR 14311 follow-up)

Browse Source 
This was added in PR 14311, but given that I completely missed to update the `PDFDocument.getPage` signature accordingly it's completely unused.
Given that things work just as fine as-is, let's simply remove that optional parameter for now; sorry about the churn here!
This commit is contained in:
Jonas Jenwald 2021-11-29 22:25:31 +01:00
parent d9e0de8515
commit e045cd4520
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/catalog.js
View File

@ -1085,7 +1085,7 @@ class Catalog {
}); });
} }
getPageDict(pageIndex, skipCount = false) { getPageDict(pageIndex) {
const capability = createPromiseCapability(); const capability = createPromiseCapability();
const nodesToVisit = [this._catDict.getRaw("Pages")]; const nodesToVisit = [this._catDict.getRaw("Pages")];
const visitedNodes = new RefSet(); const visitedNodes = new RefSet();
@ -1153,7 +1153,7 @@ class Catalog {
throw ex; throw ex;
} }
} }
if (Number.isInteger(count) && count >= 0 && !skipCount) { if (Number.isInteger(count) && count >= 0) {
// Cache the Kids count, since it can reduce redundant lookups in // Cache the Kids count, since it can reduce redundant lookups in
// documents where all nodes are found at *one* level of the tree. // documents where all nodes are found at *one* level of the tree.
const objId = currentNode.objId; const objId = currentNode.objId;

2
src/core/document.js
View File

@ -1388,7 +1388,7 @@ class PDFDocument {
let pageIndex = 1; // The first page was already loaded. let pageIndex = 1; // The first page was already loaded.
while (true) { while (true) {
try { try {
await this.getPage(pageIndex, /* skipCount = */ true); await this.getPage(pageIndex);
} catch (reasonLoop) { } catch (reasonLoop) {
if (reasonLoop instanceof PageDictMissingException) { if (reasonLoop instanceof PageDictMissingException) {
break; break;