From e045cd4520da512b53bb94e6d7376d7566cc9387 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Mon, 29 Nov 2021 22:25:31 +0100 Subject: [PATCH] Remove the unused `skipCount` parameter from `Catalog.getPageDict` (PR 14311 follow-up) This was added in PR 14311, but given that I completely missed to update the `PDFDocument.getPage` signature accordingly it's completely unused. Given that things work just as fine as-is, let's simply remove that optional parameter for now; sorry about the churn here! --- src/core/catalog.js | 4 ++-- src/core/document.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/catalog.js b/src/core/catalog.js index a5355ad57..9a19e45e9 100644 --- a/src/core/catalog.js +++ b/src/core/catalog.js @@ -1085,7 +1085,7 @@ class Catalog { }); } - getPageDict(pageIndex, skipCount = false) { + getPageDict(pageIndex) { const capability = createPromiseCapability(); const nodesToVisit = [this._catDict.getRaw("Pages")]; const visitedNodes = new RefSet(); @@ -1153,7 +1153,7 @@ class Catalog { throw ex; } } - if (Number.isInteger(count) && count >= 0 && !skipCount) { + if (Number.isInteger(count) && count >= 0) { // Cache the Kids count, since it can reduce redundant lookups in // documents where all nodes are found at *one* level of the tree. const objId = currentNode.objId; diff --git a/src/core/document.js b/src/core/document.js index bc33b1952..21607253a 100644 --- a/src/core/document.js +++ b/src/core/document.js @@ -1388,7 +1388,7 @@ class PDFDocument { let pageIndex = 1; // The first page was already loaded. while (true) { try { - await this.getPage(pageIndex, /* skipCount = */ true); + await this.getPage(pageIndex); } catch (reasonLoop) { if (reasonLoop instanceof PageDictMissingException) { break;