Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some minor issues/nits detected by JetBrains' WebStorm inspector.

Browse Source
This commit is contained in:
gigaherz 2012-08-07 17:00:42 +02:00
parent 5d95782ea1
commit a114d13308
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
web/viewer.js
View File

@ -177,7 +177,7 @@ var Settings = (function SettingsClosure() {
else if (isLocalStorageEnabled) else if (isLocalStorageEnabled)
database = localStorage.getItem('database') || '{}'; database = localStorage.getItem('database') || '{}';
else else
return false; return;
database = JSON.parse(database); database = JSON.parse(database);
if (!('files' in database)) if (!('files' in database))
@ -351,8 +351,8 @@ var PDFView = {
set page(val) { set page(val) {
var pages = this.pages; var pages = this.pages;
var input = document.getElementById('pageNumber'); var input = document.getElementById('pageNumber');
if (!(0 < val && val <= pages.length)) {
var event = document.createEvent('UIEvents'); var event = document.createEvent('UIEvents');
if (!(0 < val && val <= pages.length)) {
event.initUIEvent('pagechange', false, false, window, 0); event.initUIEvent('pagechange', false, false, window, 0);
event.pageNumber = this.page; event.pageNumber = this.page;
window.dispatchEvent(event); window.dispatchEvent(event);
@ -361,7 +361,6 @@ var PDFView = {
pages[val - 1].updateStats(); pages[val - 1].updateStats();
currentPageNumber = val; currentPageNumber = val;
var event = document.createEvent('UIEvents');
event.initUIEvent('pagechange', false, false, window, 0); event.initUIEvent('pagechange', false, false, window, 0);
event.pageNumber = val; event.pageNumber = val;
window.dispatchEvent(event); window.dispatchEvent(event);
@ -487,7 +486,7 @@ var PDFView = {
noData // Error ocurred try downloading with just the url. noData // Error ocurred try downloading with just the url.
); );
} else { } else {
url += '#pdfjs.action=download', '_parent'; url += '#pdfjs.action=download';
window.open(url, '_parent'); window.open(url, '_parent');
} }
}, },
@ -795,7 +794,7 @@ var PDFView = {
// 2 if last scrolled up page before the visible pages // 2 if last scrolled up page before the visible pages
var numVisible = visibleViews.length; var numVisible = visibleViews.length;
if (numVisible === 0) { if (numVisible === 0) {
info('No visible views.'); //info('No visible views.');
return false; return false;
} }
for (var i = 0; i < numVisible; ++i) { for (var i = 0; i < numVisible; ++i) {
@ -944,7 +943,6 @@ var PDFView = {
} else { } else {
this.page = pageNumber; // simple page this.page = pageNumber; // simple page
} }
return;
} }
} else if (/^\d+$/.test(hash)) // page number } else if (/^\d+$/.test(hash)) // page number
this.page = hash; this.page = hash;
@ -1015,7 +1013,7 @@ var PDFView = {
extractPageText(pageIndex + 1); extractPageText(pageIndex + 1);
} }
); );
}; }
extractPageText(0); extractPageText(0);
}, },
@ -1701,13 +1699,13 @@ var CustomStyle = (function CustomStyleClosure() {
//if all fails then set to undefined //if all fails then set to undefined
return (_cache[propName] = 'undefined'); return (_cache[propName] = 'undefined');
} };
CustomStyle.setProp = function set(propName, element, str) { CustomStyle.setProp = function set(propName, element, str) {
var prop = this.getProp(propName); var prop = this.getProp(propName);
if (prop != 'undefined') if (prop != 'undefined')
element.style[prop] = str; element.style[prop] = str;
} };
return CustomStyle; return CustomStyle;
})(); })();
@ -1776,7 +1774,7 @@ var TextLayerBuilder = function textLayerBuilder(textLayerDiv) {
// Resume rendering // Resume rendering
renderTimer = setInterval(renderTextLayer, renderInterval); renderTimer = setInterval(renderTextLayer, renderInterval);
}, resumeInterval); }, resumeInterval);
}; // textLayerOnScroll } // textLayerOnScroll
window.addEventListener('scroll', textLayerOnScroll, false); window.addEventListener('scroll', textLayerOnScroll, false);
}; // endLayout }; // endLayout