From a114d13308dea037045ac00a5491901c7c5ce0c7 Mon Sep 17 00:00:00 2001
From: gigaherz <gigaherz@gmail.com>
Date: Tue, 7 Aug 2012 17:00:42 +0200
Subject: [PATCH] Fix some minor issues/nits detected by JetBrains' WebStorm
 inspector.

---
 web/viewer.js | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/web/viewer.js b/web/viewer.js
index 40102852b..237c082db 100644
--- a/web/viewer.js
+++ b/web/viewer.js
@@ -177,7 +177,7 @@ var Settings = (function SettingsClosure() {
     else if (isLocalStorageEnabled)
       database = localStorage.getItem('database') || '{}';
     else
-      return false;
+      return;
 
     database = JSON.parse(database);
     if (!('files' in database))
@@ -351,8 +351,8 @@ var PDFView = {
   set page(val) {
     var pages = this.pages;
     var input = document.getElementById('pageNumber');
+    var event = document.createEvent('UIEvents');
     if (!(0 < val && val <= pages.length)) {
-      var event = document.createEvent('UIEvents');
       event.initUIEvent('pagechange', false, false, window, 0);
       event.pageNumber = this.page;
       window.dispatchEvent(event);
@@ -361,7 +361,6 @@ var PDFView = {
 
     pages[val - 1].updateStats();
     currentPageNumber = val;
-    var event = document.createEvent('UIEvents');
     event.initUIEvent('pagechange', false, false, window, 0);
     event.pageNumber = val;
     window.dispatchEvent(event);
@@ -487,7 +486,7 @@ var PDFView = {
         noData // Error ocurred try downloading with just the url.
       );
     } else {
-      url += '#pdfjs.action=download', '_parent';
+      url += '#pdfjs.action=download';
       window.open(url, '_parent');
     }
   },
@@ -795,7 +794,7 @@ var PDFView = {
     // 2 if last scrolled up page before the visible pages
     var numVisible = visibleViews.length;
     if (numVisible === 0) {
-      info('No visible views.');
+      //info('No visible views.');
       return false;
     }
     for (var i = 0; i < numVisible; ++i) {
@@ -944,7 +943,6 @@ var PDFView = {
         } else {
           this.page = pageNumber; // simple page
         }
-        return;
       }
     } else if (/^\d+$/.test(hash)) // page number
       this.page = hash;
@@ -1015,7 +1013,7 @@ var PDFView = {
             extractPageText(pageIndex + 1);
         }
       );
-    };
+    }
     extractPageText(0);
   },
 
@@ -1701,13 +1699,13 @@ var CustomStyle = (function CustomStyleClosure() {
 
     //if all fails then set to undefined
     return (_cache[propName] = 'undefined');
-  }
+  };
 
   CustomStyle.setProp = function set(propName, element, str) {
     var prop = this.getProp(propName);
     if (prop != 'undefined')
       element.style[prop] = str;
-  }
+  };
 
   return CustomStyle;
 })();
@@ -1776,7 +1774,7 @@ var TextLayerBuilder = function textLayerBuilder(textLayerDiv) {
         // Resume rendering
         renderTimer = setInterval(renderTextLayer, renderInterval);
       }, resumeInterval);
-    }; // textLayerOnScroll
+    } // textLayerOnScroll
 
     window.addEventListener('scroll', textLayerOnScroll, false);
   }; // endLayout