Improve the pageNumber validation in BaseViewer.isPageVisible (PR 10217 follow-up)

2020-11-12 15:24:36 +01:00 · 2020-11-12 15:24:36 +01:00 · 8b5bc8d7f9
commit 8b5bc8d7f9
parent 85de01e34b
1 changed files with 8 additions and 2 deletions
--- a/web/base_viewer.js
+++ b/web/base_viewer.js
@ -1096,9 +1096,15 @@ class BaseViewer {
    if (!this.pdfDocument) {
      return false;
    }
-    if (pageNumber < 1 || pageNumber > this.pagesCount) {
+    if (
+      !(
+        Number.isInteger(pageNumber) &&
+        pageNumber > 0 &&
+        pageNumber <= this.pagesCount
+      )
+    ) {
      console.error(
-        `${this._name}.isPageVisible: "${pageNumber}" is out of bounds.`
+        `${this._name}.isPageVisible: "${pageNumber}" is not a valid page.`
      );
      return false;
    }