From 8b5bc8d7f9dd351ef5e816e99f6f764987875d49 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 12 Nov 2020 15:24:36 +0100 Subject: [PATCH] Improve the `pageNumber` validation in `BaseViewer.isPageVisible` (PR 10217 follow-up) --- web/base_viewer.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/web/base_viewer.js b/web/base_viewer.js index 7a5c59907..df9188c0e 100644 --- a/web/base_viewer.js +++ b/web/base_viewer.js @@ -1096,9 +1096,15 @@ class BaseViewer { if (!this.pdfDocument) { return false; } - if (pageNumber < 1 || pageNumber > this.pagesCount) { + if ( + !( + Number.isInteger(pageNumber) && + pageNumber > 0 && + pageNumber <= this.pagesCount + ) + ) { console.error( - `${this._name}.isPageVisible: "${pageNumber}" is out of bounds.` + `${this._name}.isPageVisible: "${pageNumber}" is not a valid page.` ); return false; }