Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #12742 from calixteman/map

Browse Source 
Don't use 'in' operator to check if key is in a Map
This commit is contained in:
Brendan Dahl 2020-12-16 11:15:16 -08:00 committed by GitHub
commit 3447f7c703
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/document.js
View File

@ -965,7 +965,7 @@ class PDFDocument {
} }
} }
if (!(name in promises)) { if (!promises.has(name)) {
promises.set(name, []); promises.set(name, []);
} }
promises.get(name).push( promises.get(name).push(

6
test/unit/document_spec.js
View File

@ -212,6 +212,7 @@ describe("document", function () {
const kid1Ref = Ref.get(314, 0); const kid1Ref = Ref.get(314, 0);
const kid11Ref = Ref.get(159, 0); const kid11Ref = Ref.get(159, 0);
const kid2Ref = Ref.get(265, 0); const kid2Ref = Ref.get(265, 0);
const kid2BisRef = Ref.get(266, 0);
const parentRef = Ref.get(358, 0); const parentRef = Ref.get(358, 0);
const allFields = Object.create(null); const allFields = Object.create(null);
@ -225,13 +226,14 @@ describe("document", function () {
} }
allFields.kid1.set("Kids", [kid11Ref]); allFields.kid1.set("Kids", [kid11Ref]);
allFields.parent.set("Kids", [kid1Ref, kid2Ref]); allFields.parent.set("Kids", [kid1Ref, kid2Ref, kid2BisRef]);
const xref = new XRefMock([ const xref = new XRefMock([
{ ref: parentRef, data: allFields.parent }, { ref: parentRef, data: allFields.parent },
{ ref: kid1Ref, data: allFields.kid1 }, { ref: kid1Ref, data: allFields.kid1 },
{ ref: kid11Ref, data: allFields.kid11 }, { ref: kid11Ref, data: allFields.kid11 },
{ ref: kid2Ref, data: allFields.kid2 }, { ref: kid2Ref, data: allFields.kid2 },
{ ref: kid2BisRef, data: allFields.kid2 },
]); ]);
acroForm.set("Fields", [parentRef]); acroForm.set("Fields", [parentRef]);
@ -244,7 +246,7 @@ describe("document", function () {
expect(fields["parent.kid1"]).toEqual(["314R"]); expect(fields["parent.kid1"]).toEqual(["314R"]);
expect(fields["parent.kid1.kid11"]).toEqual(["159R"]); expect(fields["parent.kid1.kid11"]).toEqual(["159R"]);
expect(fields["parent.kid2"]).toEqual(["265R"]); expect(fields["parent.kid2"]).toEqual(["265R", "266R"]);
expect(fields.parent).toEqual(["358R"]); expect(fields.parent).toEqual(["358R"]);
}); });