From 03814bd6a2a2e13e97a37829f3d43fe5a4541f2f Mon Sep 17 00:00:00 2001
From: Calixte Denizet <calixte.denizet@gmail.com>
Date: Wed, 16 Dec 2020 16:00:12 +0100
Subject: [PATCH] Don't use 'in' operator to check if key is in a Map

---
 src/core/document.js       | 2 +-
 test/unit/document_spec.js | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/core/document.js b/src/core/document.js
index 4f6951d40..e80a616ef 100644
--- a/src/core/document.js
+++ b/src/core/document.js
@@ -965,7 +965,7 @@ class PDFDocument {
       }
     }
 
-    if (!(name in promises)) {
+    if (!promises.has(name)) {
       promises.set(name, []);
     }
     promises.get(name).push(
diff --git a/test/unit/document_spec.js b/test/unit/document_spec.js
index cde9f5105..e4109284d 100644
--- a/test/unit/document_spec.js
+++ b/test/unit/document_spec.js
@@ -212,6 +212,7 @@ describe("document", function () {
       const kid1Ref = Ref.get(314, 0);
       const kid11Ref = Ref.get(159, 0);
       const kid2Ref = Ref.get(265, 0);
+      const kid2BisRef = Ref.get(266, 0);
       const parentRef = Ref.get(358, 0);
 
       const allFields = Object.create(null);
@@ -225,13 +226,14 @@ describe("document", function () {
       }
 
       allFields.kid1.set("Kids", [kid11Ref]);
-      allFields.parent.set("Kids", [kid1Ref, kid2Ref]);
+      allFields.parent.set("Kids", [kid1Ref, kid2Ref, kid2BisRef]);
 
       const xref = new XRefMock([
         { ref: parentRef, data: allFields.parent },
         { ref: kid1Ref, data: allFields.kid1 },
         { ref: kid11Ref, data: allFields.kid11 },
         { ref: kid2Ref, data: allFields.kid2 },
+        { ref: kid2BisRef, data: allFields.kid2 },
       ]);
 
       acroForm.set("Fields", [parentRef]);
@@ -244,7 +246,7 @@ describe("document", function () {
 
       expect(fields["parent.kid1"]).toEqual(["314R"]);
       expect(fields["parent.kid1.kid11"]).toEqual(["159R"]);
-      expect(fields["parent.kid2"]).toEqual(["265R"]);
+      expect(fields["parent.kid2"]).toEqual(["265R", "266R"]);
       expect(fields.parent).toEqual(["358R"]);
     });