Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Firefox] Slightly simplify how the generator is determined, when sending telemetry data from the viewer

Browse Source 
When working on PR 11463 I couldn't help thinking that the `Array.prototype.some` callback function, used when determining the generator, was somewhat difficult to read with its partly unused and strangely named parameters.
This commit is contained in:
Jonas Jenwald 2020-01-02 23:19:14 +01:00
parent b833f84307
commit 299ba44bb9
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
web/app.js
View File

@ -1365,16 +1365,16 @@ const PDFViewerApplication = {
"fpdf",
];
if (info.Producer) {
KNOWN_GENERATORS.some(
function(generator, s, i) {
if (!generator.includes(s)) {
return false;
}
generatorId = s.replace(/[ .\-]/g, "_");
return true;
}.bind(null, info.Producer.toLowerCase())
);
const producer = info.Producer.toLowerCase();
KNOWN_GENERATORS.some(function(generator) {
if (!producer.includes(generator)) {
return false;
}
generatorId = generator.replace(/[ .\-]/g, "_");
return true;
});
}
const formType = !info.IsAcroFormPresent
? null
: info.IsXFAPresent