From 299ba44bb92eabcfb106d9ff4169702cdc8bfd6c Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 2 Jan 2020 23:19:14 +0100 Subject: [PATCH] [Firefox] Slightly simplify how the generator is determined, when sending telemetry data from the viewer When working on PR 11463 I couldn't help thinking that the `Array.prototype.some` callback function, used when determining the generator, was somewhat difficult to read with its partly unused and strangely named parameters. --- web/app.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/web/app.js b/web/app.js index 1f55158e3..884b89ec2 100644 --- a/web/app.js +++ b/web/app.js @@ -1365,16 +1365,16 @@ const PDFViewerApplication = { "fpdf", ]; if (info.Producer) { - KNOWN_GENERATORS.some( - function(generator, s, i) { - if (!generator.includes(s)) { - return false; - } - generatorId = s.replace(/[ .\-]/g, "_"); - return true; - }.bind(null, info.Producer.toLowerCase()) - ); + const producer = info.Producer.toLowerCase(); + KNOWN_GENERATORS.some(function(generator) { + if (!producer.includes(generator)) { + return false; + } + generatorId = generator.replace(/[ .\-]/g, "_"); + return true; + }); } + const formType = !info.IsAcroFormPresent ? null : info.IsXFAPresent