Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #9078 from Snuffleupagus/eslint-lines-between-class-members

Browse Source 
Update ESLint and enable the `lines-between-class-members` rule
This commit is contained in:
Tim van der Meij 2017-10-29 13:19:55 +01:00 committed by GitHub
commit 1294247d1b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc
View File

@ -119,6 +119,7 @@
"key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "strict", }], "key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "strict", }],
"keyword-spacing": ["error", { "before": true, "after": true, }], "keyword-spacing": ["error", { "before": true, "after": true, }],
"linebreak-style": ["error", "unix"], "linebreak-style": ["error", "unix"],
"lines-between-class-members": ["error", "always"],
"max-len": ["error", 80], "max-len": ["error", 80],
"new-cap": ["error", { "newIsCap": true, "capIsNew": false, }], "new-cap": ["error", { "newIsCap": true, "capIsNew": false, }],
"new-parens": "error", "new-parens": "error",

4
package.json
View File

@ -9,8 +9,8 @@
"babel-preset-env": "^1.6.0", "babel-preset-env": "^1.6.0",
"core-js": "^2.5.1", "core-js": "^2.5.1",
"escodegen": "^1.9.0", "escodegen": "^1.9.0",
"eslint": "^4.8.0", "eslint": "^4.10.0",
"eslint-plugin-mozilla": "^0.4.4", "eslint-plugin-mozilla": "^0.4.5",
"gulp": "^3.9.1", "gulp": "^3.9.1",
"gulp-rename": "^1.2.2", "gulp-rename": "^1.2.2",
"gulp-replace": "^0.6.1", "gulp-replace": "^0.6.1",

10
web/pdf_link_service.js
View File

@ -423,24 +423,29 @@ class SimpleLinkService {
get page() { get page() {
return 0; return 0;
} }
/** /**
* @param {number} value * @param {number} value
*/ */
set page(value) {} set page(value) {}
/** /**
* @returns {number} * @returns {number}
*/ */
get rotation() { get rotation() {
return 0; return 0;
} }
/** /**
* @param {number} value * @param {number} value
*/ */
set rotation(value) {} set rotation(value) {}
/** /**
* @param dest - The PDF destination object. * @param dest - The PDF destination object.
*/ */
navigateTo(dest) {} navigateTo(dest) {}
/** /**
* @param dest - The PDF destination object. * @param dest - The PDF destination object.
* @returns {string} The hyperlink to the PDF object. * @returns {string} The hyperlink to the PDF object.
@ -448,6 +453,7 @@ class SimpleLinkService {
getDestinationHash(dest) { getDestinationHash(dest) {
return '#'; return '#';
} }
/** /**
* @param hash - The PDF parameters/hash. * @param hash - The PDF parameters/hash.
* @returns {string} The hyperlink to the PDF object. * @returns {string} The hyperlink to the PDF object.
@ -455,18 +461,22 @@ class SimpleLinkService {
getAnchorUrl(hash) { getAnchorUrl(hash) {
return '#'; return '#';
} }
/** /**
* @param {string} hash * @param {string} hash
*/ */
setHash(hash) {} setHash(hash) {}
/** /**
* @param {string} action * @param {string} action
*/ */
executeNamedAction(action) {} executeNamedAction(action) {}
/** /**
* @param {Object} params * @param {Object} params
*/ */
onFileAttachmentAnnotation({ id, filename, content, }) {} onFileAttachmentAnnotation({ id, filename, content, }) {}
/** /**
* @param {number} pageNum - page number. * @param {number} pageNum - page number.
* @param {Object} pageRef - reference to the page. * @param {Object} pageRef - reference to the page.