Update ESLint and enable the lines-between-class-members rule

This rule will help aid readability in `class`es, please see https://eslint.org/docs/rules/lines-between-class-members.
This commit is contained in:
Jonas Jenwald 2017-10-29 11:41:13 +01:00
parent 985c700bd5
commit 8f9d548874
3 changed files with 13 additions and 2 deletions

View File

@ -119,6 +119,7 @@
"key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "strict", }],
"keyword-spacing": ["error", { "before": true, "after": true, }],
"linebreak-style": ["error", "unix"],
"lines-between-class-members": ["error", "always"],
"max-len": ["error", 80],
"new-cap": ["error", { "newIsCap": true, "capIsNew": false, }],
"new-parens": "error",

View File

@ -9,8 +9,8 @@
"babel-preset-env": "^1.6.0",
"core-js": "^2.5.1",
"escodegen": "^1.9.0",
"eslint": "^4.8.0",
"eslint-plugin-mozilla": "^0.4.4",
"eslint": "^4.10.0",
"eslint-plugin-mozilla": "^0.4.5",
"gulp": "^3.9.1",
"gulp-rename": "^1.2.2",
"gulp-replace": "^0.6.1",

View File

@ -423,24 +423,29 @@ class SimpleLinkService {
get page() {
return 0;
}
/**
* @param {number} value
*/
set page(value) {}
/**
* @returns {number}
*/
get rotation() {
return 0;
}
/**
* @param {number} value
*/
set rotation(value) {}
/**
* @param dest - The PDF destination object.
*/
navigateTo(dest) {}
/**
* @param dest - The PDF destination object.
* @returns {string} The hyperlink to the PDF object.
@ -448,6 +453,7 @@ class SimpleLinkService {
getDestinationHash(dest) {
return '#';
}
/**
* @param hash - The PDF parameters/hash.
* @returns {string} The hyperlink to the PDF object.
@ -455,18 +461,22 @@ class SimpleLinkService {
getAnchorUrl(hash) {
return '#';
}
/**
* @param {string} hash
*/
setHash(hash) {}
/**
* @param {string} action
*/
executeNamedAction(action) {}
/**
* @param {Object} params
*/
onFileAttachmentAnnotation({ id, filename, content, }) {}
/**
* @param {number} pageNum - page number.
* @param {Object} pageRef - reference to the page.