pdf.js/lgtm.yml

path_classifiers:
  test:
    - exclude: test
    - test/resources

queries:
  # Already handled by the "no-unused-vars" ESLint rule.
  - exclude: js/unused-local-variable
  - exclude: js/useless-assignment-to-local
Include the `font`/`integration`/`unit`-test folders in the LGTM report By default all files/folders classified as test-code are excluded in the LGTM report, however I do believe that it makes sense to include at least the `font`/`integration`/`unit`-test folders. It seems pretty obvious that you want to avoid accidentally introducing any simple logical errors in the tests (and not only in the main code), to ensure that e.g. the unit-tests actually test the desired thing. Hopefully I've interpreted the information at https://lgtm.com/help/lgtm/customizing-file-classification correctly, however note that we may need to land this patch to actually see any difference in the results. 2021-07-22 00:26:21 +02:00			`path_classifiers:`
			`test:`
Include most of the `test`-folder in the LGTM report (PR 13772 follow-up) Given that PR 13772 seem to have worked as intended, it probably cannot hurt to enable the LGTM report for most of the remaining code in the `test`-folder. (The one remaining exception is code which originated outside of the PDF.js project.) Please note: We'll need to land this patch to actually see any difference in the LGTM results. 2021-07-22 14:22:30 +02:00			`- exclude: test`
			`- test/resources`
Include the `font`/`integration`/`unit`-test folders in the LGTM report By default all files/folders classified as test-code are excluded in the LGTM report, however I do believe that it makes sense to include at least the `font`/`integration`/`unit`-test folders. It seems pretty obvious that you want to avoid accidentally introducing any simple logical errors in the tests (and not only in the main code), to ensure that e.g. the unit-tests actually test the desired thing. Hopefully I've interpreted the information at https://lgtm.com/help/lgtm/customizing-file-classification correctly, however note that we may need to land this patch to actually see any difference in the results. 2021-07-22 00:26:21 +02:00
Try adding a very basic `lgtm.yml` file, to prevent LGTM complaining about unused variables (issue 11965) Please note: I cannot be sure if this actually helps, since we've not enabled LGTM for the PDF.js repository[1], however I hope that it should stop LGTM reporting things that we're already using ESLint to enforce. --- [1] In case the patch does nothing, we can simply revert it and move on :-) 2020-11-01 17:00:40 +01:00			`queries:`
			`# Already handled by the "no-unused-vars" ESLint rule.`
			`- exclude: js/unused-local-variable`
Prevent LGTM from complaining about useless assignments (PR 12562 follow-up) Given that we're using ESLint, which is fine with the code as-is, let's just silence the warnings; this is similar to PR 12562. 2021-05-11 11:36:36 +02:00			`- exclude: js/useless-assignment-to-local`