Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Include the font/integration/unit-test folders in the LGTM report

Browse Source 
By default all files/folders classified as test-code are excluded in the LGTM report, however I do believe that it makes sense to include at least the `font`/`integration`/`unit`-test folders.
It seems pretty obvious that you want to avoid *accidentally* introducing any simple logical errors in the tests (and not only in the main code), to ensure that e.g. the unit-tests actually test the desired thing.

Hopefully I've interpreted the information at https://lgtm.com/help/lgtm/customizing-file-classification correctly, however note that we may need to land this patch to actually see any difference in the results.
This commit is contained in:
Jonas Jenwald 2021-07-22 00:26:21 +02:00
parent 2cf90cd9ad
commit bdde1336f1
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lgtm.yml
View File

@ -1,3 +1,9 @@
path_classifiers:
test:
- exclude: test/font
- exclude: test/integration
- exclude: test/unit
queries:
# Already handled by the "no-unused-vars" ESLint rule.
- exclude: js/unused-local-variable