1cc3dbb694
*Please note:* These changes were done automatically, using the `gulp lint --fix` command. This rule is already enabled in mozilla-central, see https://searchfox.org/mozilla-central/rev/567b68b8ff4b6d607ba34a6f1926873d21a7b4d7/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#103-104 The main advantage, besides improved consistency, of this rule is that it reduces the size of the code (by 3 bytes for each case). In the PDF.js code-base there's close to 8000 instances being fixed by the `dot-notation` ESLint rule, which end up reducing the size of even the *built* files significantly; the total size of the `gulp mozcentral` build target changes from `3 247 456` to `3 224 278` bytes, which is a *reduction* of `23 178` bytes (or ~0.7%) for a completely mechanical change. A large number of these changes affect the (large) lookup tables used on the worker-thread, but given that they are still initialized lazily I don't *think* that the new formatting this patch introduces should undo any of the improvements from PR 6915. Please find additional details about the ESLint rule at https://eslint.org/docs/rules/dot-notation
151 lines
4.5 KiB
JavaScript
151 lines
4.5 KiB
JavaScript
/* Copyright 2017 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import {
|
|
getDingbatsGlyphsUnicode,
|
|
getGlyphsUnicode,
|
|
} from "../../src/core/glyphlist.js";
|
|
import {
|
|
getNormalizedUnicodes,
|
|
getUnicodeForGlyph,
|
|
getUnicodeRangeFor,
|
|
mapSpecialUnicodeValues,
|
|
reverseIfRtl,
|
|
} from "../../src/core/unicode.js";
|
|
|
|
describe("unicode", function () {
|
|
describe("mapSpecialUnicodeValues", function () {
|
|
it("should not re-map normal Unicode values", function () {
|
|
// A
|
|
expect(mapSpecialUnicodeValues(0x0041)).toEqual(0x0041);
|
|
// fi
|
|
expect(mapSpecialUnicodeValues(0xfb01)).toEqual(0xfb01);
|
|
});
|
|
|
|
it("should re-map special Unicode values", function () {
|
|
// copyrightsans => copyright
|
|
expect(mapSpecialUnicodeValues(0xf8e9)).toEqual(0x00a9);
|
|
// Private Use Area characters
|
|
expect(mapSpecialUnicodeValues(0xffff)).toEqual(0);
|
|
});
|
|
});
|
|
|
|
describe("getUnicodeForGlyph", function () {
|
|
var standardMap, dingbatsMap;
|
|
|
|
beforeAll(function (done) {
|
|
standardMap = getGlyphsUnicode();
|
|
dingbatsMap = getDingbatsGlyphsUnicode();
|
|
done();
|
|
});
|
|
|
|
afterAll(function () {
|
|
standardMap = dingbatsMap = null;
|
|
});
|
|
|
|
it("should get Unicode values for valid glyph names", function () {
|
|
expect(getUnicodeForGlyph("A", standardMap)).toEqual(0x0041);
|
|
expect(getUnicodeForGlyph("a1", dingbatsMap)).toEqual(0x2701);
|
|
});
|
|
|
|
it("should recover Unicode values from uniXXXX/uXXXX{XX} glyph names", function () {
|
|
expect(getUnicodeForGlyph("uni0041", standardMap)).toEqual(0x0041);
|
|
expect(getUnicodeForGlyph("u0041", standardMap)).toEqual(0x0041);
|
|
|
|
expect(getUnicodeForGlyph("uni2701", dingbatsMap)).toEqual(0x2701);
|
|
expect(getUnicodeForGlyph("u2701", dingbatsMap)).toEqual(0x2701);
|
|
});
|
|
|
|
it("should not get Unicode values for invalid glyph names", function () {
|
|
expect(getUnicodeForGlyph("Qwerty", standardMap)).toEqual(-1);
|
|
expect(getUnicodeForGlyph("Qwerty", dingbatsMap)).toEqual(-1);
|
|
});
|
|
});
|
|
|
|
describe("getUnicodeRangeFor", function () {
|
|
it("should get correct Unicode range", function () {
|
|
// A (Basic Latin)
|
|
expect(getUnicodeRangeFor(0x0041)).toEqual(0);
|
|
// fi (Alphabetic Presentation Forms)
|
|
expect(getUnicodeRangeFor(0xfb01)).toEqual(62);
|
|
});
|
|
|
|
it("should not get a Unicode range", function () {
|
|
expect(getUnicodeRangeFor(0x05ff)).toEqual(-1);
|
|
});
|
|
});
|
|
|
|
describe("getNormalizedUnicodes", function () {
|
|
var NormalizedUnicodes;
|
|
|
|
beforeAll(function (done) {
|
|
NormalizedUnicodes = getNormalizedUnicodes();
|
|
done();
|
|
});
|
|
|
|
afterAll(function () {
|
|
NormalizedUnicodes = null;
|
|
});
|
|
|
|
it("should get normalized Unicode values for ligatures", function () {
|
|
// fi => f + i
|
|
expect(NormalizedUnicodes["\uFB01"]).toEqual("fi");
|
|
// Arabic
|
|
expect(NormalizedUnicodes["\u0675"]).toEqual("\u0627\u0674");
|
|
});
|
|
|
|
it("should not normalize standard characters", function () {
|
|
expect(NormalizedUnicodes.A).toEqual(undefined);
|
|
});
|
|
});
|
|
|
|
describe("reverseIfRtl", function () {
|
|
var NormalizedUnicodes;
|
|
|
|
function getGlyphUnicode(char) {
|
|
if (NormalizedUnicodes[char] !== undefined) {
|
|
return NormalizedUnicodes[char];
|
|
}
|
|
return char;
|
|
}
|
|
|
|
beforeAll(function (done) {
|
|
NormalizedUnicodes = getNormalizedUnicodes();
|
|
done();
|
|
});
|
|
|
|
afterAll(function () {
|
|
NormalizedUnicodes = null;
|
|
});
|
|
|
|
it("should not reverse LTR characters", function () {
|
|
var A = getGlyphUnicode("A");
|
|
expect(reverseIfRtl(A)).toEqual("A");
|
|
|
|
var fi = getGlyphUnicode("\uFB01");
|
|
expect(reverseIfRtl(fi)).toEqual("fi");
|
|
});
|
|
|
|
it("should reverse RTL characters", function () {
|
|
// Hebrew (no-op, since it's not a combined character)
|
|
var heAlef = getGlyphUnicode("\u05D0");
|
|
expect(reverseIfRtl(heAlef)).toEqual("\u05D0");
|
|
// Arabic
|
|
var arAlef = getGlyphUnicode("\u0675");
|
|
expect(reverseIfRtl(arAlef)).toEqual("\u0674\u0627");
|
|
});
|
|
});
|
|
});
|