7f21e38787
Incomplete path operators, in particular, can result in fairly chaotic rendering artifacts, as can be observed on page four of the referenced PDF file. The initial (naive) solution that was attempted, was to simply throw a `FormatError` as soon as any invalid (i.e. too short) operator was found and rely on the existing `ignoreErrors` code-paths. However, doing so would have caused regressions in some files; see the existing `issue2391-1` test-case, which was promoted to an `eq` test to help prevent future bugs. Hence this patch, which adds special handling for invalid path operators since those may cause quite bad rendering artifacts. You could, in all fairness, argue that the patch is a handwavy solution and I wouldn't object. However, given that this only concerns *corrupt* PDF files, the way that PDF viewers (PDF.js included) try to gracefully deal with those could probably be described as a best-effort solution anyway. This patch also adjusts the existing `warn`/`info` messages to print the command name according to the PDF specification, rather than an internal PDF.js enumeration value. The former should be much more useful for debugging purposes. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1443140.
345 lines
12 KiB
JavaScript
345 lines
12 KiB
JavaScript
/* Copyright 2017 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { Dict, Name } from '../../src/core/primitives';
|
|
import { FormatError, OPS } from '../../src/shared/util';
|
|
import { Stream, StringStream } from '../../src/core/stream';
|
|
import { OperatorList } from '../../src/core/operator_list';
|
|
import { PartialEvaluator } from '../../src/core/evaluator';
|
|
import { WorkerTask } from '../../src/core/worker';
|
|
import { XRefMock } from './test_utils';
|
|
|
|
describe('evaluator', function() {
|
|
function HandlerMock() {
|
|
this.inputs = [];
|
|
}
|
|
HandlerMock.prototype = {
|
|
send(name, data) {
|
|
this.inputs.push({ name, data, });
|
|
},
|
|
};
|
|
function ResourcesMock() { }
|
|
ResourcesMock.prototype = {
|
|
get(name) {
|
|
return this[name];
|
|
},
|
|
};
|
|
|
|
function PdfManagerMock() { }
|
|
|
|
function runOperatorListCheck(evaluator, stream, resources, callback) {
|
|
var result = new OperatorList();
|
|
var task = new WorkerTask('OperatorListCheck');
|
|
evaluator.getOperatorList({
|
|
stream,
|
|
task,
|
|
resources,
|
|
operatorList: result,
|
|
}).then(function() {
|
|
callback(result);
|
|
}, function(reason) {
|
|
callback(reason);
|
|
});
|
|
}
|
|
|
|
var partialEvaluator;
|
|
|
|
beforeAll(function(done) {
|
|
partialEvaluator = new PartialEvaluator({
|
|
pdfManager: new PdfManagerMock(),
|
|
xref: new XRefMock(),
|
|
handler: new HandlerMock(),
|
|
pageIndex: 0,
|
|
});
|
|
done();
|
|
});
|
|
|
|
afterAll(function() {
|
|
partialEvaluator = null;
|
|
});
|
|
|
|
describe('splitCombinedOperations', function() {
|
|
it('should reject unknown operations', function(done) {
|
|
var stream = new StringStream('fTT');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function(result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(1);
|
|
expect(result.fnArray[0]).toEqual(OPS.fill);
|
|
expect(result.argsArray[0]).toEqual(null);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should handle one operation', function(done) {
|
|
var stream = new StringStream('Q');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function(result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(1);
|
|
expect(result.fnArray[0]).toEqual(OPS.restore);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should handle two glued operations', function(done) {
|
|
var resources = new ResourcesMock();
|
|
resources.Res1 = {};
|
|
var stream = new StringStream('/Res1 DoQ');
|
|
runOperatorListCheck(partialEvaluator, stream, resources,
|
|
function(result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(2);
|
|
expect(result.fnArray[0]).toEqual(OPS.paintXObject);
|
|
expect(result.fnArray[1]).toEqual(OPS.restore);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should handle three glued operations', function(done) {
|
|
var stream = new StringStream('fff');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(3);
|
|
expect(result.fnArray[0]).toEqual(OPS.fill);
|
|
expect(result.fnArray[1]).toEqual(OPS.fill);
|
|
expect(result.fnArray[2]).toEqual(OPS.fill);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should handle three glued operations #2', function(done) {
|
|
var resources = new ResourcesMock();
|
|
resources.Res1 = {};
|
|
var stream = new StringStream('B*Bf*');
|
|
runOperatorListCheck(partialEvaluator, stream, resources,
|
|
function(result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(3);
|
|
expect(result.fnArray[0]).toEqual(OPS.eoFillStroke);
|
|
expect(result.fnArray[1]).toEqual(OPS.fillStroke);
|
|
expect(result.fnArray[2]).toEqual(OPS.eoFill);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should handle glued operations and operands', function(done) {
|
|
var stream = new StringStream('f5 Ts');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(2);
|
|
expect(result.fnArray[0]).toEqual(OPS.fill);
|
|
expect(result.fnArray[1]).toEqual(OPS.setTextRise);
|
|
expect(result.argsArray.length).toEqual(2);
|
|
expect(result.argsArray[1].length).toEqual(1);
|
|
expect(result.argsArray[1][0]).toEqual(5);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should handle glued operations and literals', function(done) {
|
|
var stream = new StringStream('trueifalserinulln');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(3);
|
|
expect(result.fnArray[0]).toEqual(OPS.setFlatness);
|
|
expect(result.fnArray[1]).toEqual(OPS.setRenderingIntent);
|
|
expect(result.fnArray[2]).toEqual(OPS.endPath);
|
|
expect(result.argsArray.length).toEqual(3);
|
|
expect(result.argsArray[0].length).toEqual(1);
|
|
expect(result.argsArray[0][0]).toEqual(true);
|
|
expect(result.argsArray[1].length).toEqual(1);
|
|
expect(result.argsArray[1][0]).toEqual(false);
|
|
expect(result.argsArray[2]).toEqual(null);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('validateNumberOfArgs', function() {
|
|
it('should execute if correct number of arguments', function(done) {
|
|
var stream = new StringStream('5 1 d0');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(result.argsArray[0][0]).toEqual(5);
|
|
expect(result.argsArray[0][1]).toEqual(1);
|
|
expect(result.fnArray[0]).toEqual(OPS.setCharWidth);
|
|
done();
|
|
});
|
|
});
|
|
it('should execute if too many arguments', function(done) {
|
|
var stream = new StringStream('5 1 4 d0');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(result.argsArray[0][0]).toEqual(1);
|
|
expect(result.argsArray[0][1]).toEqual(4);
|
|
expect(result.fnArray[0]).toEqual(OPS.setCharWidth);
|
|
done();
|
|
});
|
|
});
|
|
it('should execute if nested commands', function(done) {
|
|
var stream = new StringStream('/F2 /GS2 gs 5.711 Tf');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(result.fnArray.length).toEqual(3);
|
|
expect(result.fnArray[0]).toEqual(OPS.setGState);
|
|
expect(result.fnArray[1]).toEqual(OPS.dependency);
|
|
expect(result.fnArray[2]).toEqual(OPS.setFont);
|
|
expect(result.argsArray.length).toEqual(3);
|
|
expect(result.argsArray[0].length).toEqual(1);
|
|
expect(result.argsArray[1].length).toEqual(1);
|
|
expect(result.argsArray[2].length).toEqual(2);
|
|
done();
|
|
});
|
|
});
|
|
it('should skip if too few arguments', function(done) {
|
|
var stream = new StringStream('5 d0');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(result.argsArray).toEqual([]);
|
|
expect(result.fnArray).toEqual([]);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should error if (many) path operators have too few arguments ' +
|
|
'(bug 1443140)', function(done) {
|
|
const NUM_INVALID_OPS = 25;
|
|
const tempArr = new Array(NUM_INVALID_OPS + 1);
|
|
|
|
// Non-path operators, should be ignored.
|
|
const invalidMoveText = tempArr.join('10 Td\n');
|
|
const moveTextStream = new StringStream(invalidMoveText);
|
|
runOperatorListCheck(partialEvaluator, moveTextStream,
|
|
new ResourcesMock(), function(result) {
|
|
expect(result.argsArray).toEqual([]);
|
|
expect(result.fnArray).toEqual([]);
|
|
done();
|
|
});
|
|
|
|
// Path operators, should throw error.
|
|
const invalidLineTo = tempArr.join('20 l\n');
|
|
const lineToStream = new StringStream(invalidLineTo);
|
|
runOperatorListCheck(partialEvaluator, lineToStream, new ResourcesMock(),
|
|
function(error) {
|
|
expect(error instanceof FormatError).toEqual(true);
|
|
expect(error.message).toEqual(
|
|
'Invalid command l: expected 2 args, but received 1 args.');
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should close opened saves', function(done) {
|
|
var stream = new StringStream('qq');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function (result) {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(4);
|
|
expect(result.fnArray[0]).toEqual(OPS.save);
|
|
expect(result.fnArray[1]).toEqual(OPS.save);
|
|
expect(result.fnArray[2]).toEqual(OPS.restore);
|
|
expect(result.fnArray[3]).toEqual(OPS.restore);
|
|
done();
|
|
});
|
|
});
|
|
it('should skip paintXObject if name is missing', function(done) {
|
|
var stream = new StringStream('/ Do');
|
|
runOperatorListCheck(partialEvaluator, stream, new ResourcesMock(),
|
|
function(result) {
|
|
expect(result instanceof FormatError).toEqual(true);
|
|
expect(result.message).toEqual('XObject must be referred to by name.');
|
|
done();
|
|
});
|
|
});
|
|
it('should skip paintXObject if subtype is PS', function(done) {
|
|
var xobjStreamDict = new Dict();
|
|
xobjStreamDict.set('Subtype', Name.get('PS'));
|
|
var xobjStream = new Stream([], 0, 0, xobjStreamDict);
|
|
|
|
var xobjs = new Dict();
|
|
xobjs.set('Res1', xobjStream);
|
|
|
|
var resources = new Dict();
|
|
resources.set('XObject', xobjs);
|
|
|
|
var stream = new StringStream('/Res1 Do');
|
|
runOperatorListCheck(partialEvaluator, stream, resources,
|
|
function(result) {
|
|
expect(result.argsArray).toEqual([]);
|
|
expect(result.fnArray).toEqual([]);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('thread control', function() {
|
|
it('should abort operator list parsing', function (done) {
|
|
var stream = new StringStream('qqQQ');
|
|
var resources = new ResourcesMock();
|
|
var result = new OperatorList();
|
|
var task = new WorkerTask('OperatorListAbort');
|
|
task.terminate();
|
|
partialEvaluator.getOperatorList({
|
|
stream,
|
|
task,
|
|
resources,
|
|
operatorList: result,
|
|
}).catch(function() {
|
|
expect(!!result.fnArray && !!result.argsArray).toEqual(true);
|
|
expect(result.fnArray.length).toEqual(0);
|
|
done();
|
|
});
|
|
});
|
|
it('should abort text parsing parsing', function (done) {
|
|
var resources = new ResourcesMock();
|
|
var stream = new StringStream('qqQQ');
|
|
var task = new WorkerTask('TextContentAbort');
|
|
task.terminate();
|
|
partialEvaluator.getTextContent({
|
|
stream,
|
|
task,
|
|
resources,
|
|
}).catch(function() {
|
|
expect(true).toEqual(true);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('operator list', function () {
|
|
function MessageHandlerMock() { }
|
|
MessageHandlerMock.prototype = {
|
|
send() { },
|
|
};
|
|
|
|
it('should get correct total length after flushing', function () {
|
|
var operatorList = new OperatorList(null, new MessageHandlerMock());
|
|
operatorList.addOp(OPS.save, null);
|
|
operatorList.addOp(OPS.restore, null);
|
|
|
|
expect(operatorList.totalLength).toEqual(2);
|
|
expect(operatorList.length).toEqual(2);
|
|
|
|
operatorList.flush();
|
|
|
|
expect(operatorList.totalLength).toEqual(2);
|
|
expect(operatorList.length).toEqual(0);
|
|
});
|
|
});
|
|
});
|