Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b7cb44af88
pdf.js/web
History
Jonas Jenwald b7cb44af88 Remove the previousPageNumber parameter from the pagechanging/pagechange` events, and stop dispatching the events if the input is out of bounds 
This patch attempts to cleanup a couple of things:
 - Remove the `previousPageNumber` paramater. Prior to PR 7289, when the events were dispatched even when the active page didn't change, it made sense to be able to detect that in an event listener. However, now that's no longer the case, and furthermore other similar events (e.g. `scalechanging`/`scalechange`) don't include information about the previous state.

 - Don't dispatch the events when the value passed to `set currentPageNumber` is out of bounds. Given that the active page doesn't change in this case, again similar to PR 7289, I don't think that the events should actually be dispatched in this case.

 - Ensure that the value passed to `set currentPageNumber` is actually an integer, to avoid any issues (note how e.g. `set currentScale` has similar validation code).

Given that these changes could possibly affect the PDF.js `mochitest` integration tests in mozilla-central, in particular https://dxr.mozilla.org/mozilla-central/source/browser/extensions/pdfjs/test/browser_pdfjs_navigation.js, I ran the tests locally with this patch applied to ensure that they still pass.
2016-07-25 10:08:53 +02:00
..
images optimize png images using zopflipng 2016-07-10 17:49:16 +08:00
.gitignore Remove obselete file from .gitignore 2015-01-26 16:44:45 +01:00
annotation_layer_builder.css Implement support for FileAttachment annotations 2016-02-23 22:49:53 +01:00
annotation_layer_builder.js Export the DefaultAnnotationLayerFactory to prevent the viewer components from breaking (PR 7172 followup) 2016-04-13 17:42:04 +02:00
app.js Remove the previousPageNumber parameter from the pagechanging/pagechange` events, and stop dispatching the events if the input is out of bounds 2016-07-25 10:08:53 +02:00
chrome-i18n-allow-access-to-file-urls.json Add translations of "Allow access to file URLs" 2015-08-14 18:59:55 +02:00
chromecom.js trivial spelling fixes 2016-07-17 14:33:41 +02:00
compatibility.js Added context to compatibility.js to have 'use strict' directive in our context only 2016-05-12 10:04:51 +02:00
compressed.tracemonkey-pldi-09.pdf Add Makefile. Move some files around to make building the website easier. 2011-07-05 10:53:57 -07:00
debugger.js trivial spelling fixes 2016-07-17 14:33:41 +02:00
default_preferences.js Moves DEFAULT_PREFENCES into JSON format. 2016-05-11 17:58:17 -05:00
default_preferences.json Moves DEFAULT_PREFENCES into JSON format. 2016-05-11 17:58:17 -05:00
dom_events.js Remove the previousPageNumber parameter from the pagechanging/pagechange` events, and stop dispatching the events if the input is out of bounds 2016-07-25 10:08:53 +02:00
download_manager.js Replace pdfjsLib with module that represents pdf.js. 2016-04-13 10:11:34 -05:00
firefoxcom.js Added multiple term search functionality (with default phrase search) 2016-05-26 18:24:58 +05:00
grab_to_pan.js Update grab_to_pan.js 2016-05-07 23:46:56 +02:00
hand_tool.js Removes circular dependency of secondary toolbar on app.js. 2016-04-28 15:04:09 -05:00
interfaces.js Remove a superfluous "s" in AnnotationsLayerBuilder from files in web/ 2015-12-18 19:55:54 +01:00
mozPrintCallback_polyfill.js Introduces UMD headers to the web/ folder. 2016-04-13 10:09:48 -05:00
overlay_manager.js Moves all document.getElementById lookups into viewer.js 2016-04-21 11:39:11 -05:00
password_prompt.js Moves all document.getElementById lookups into viewer.js 2016-04-21 11:39:11 -05:00
pdf_attachment_viewer.js Adds EventBus. 2016-04-28 06:57:24 -05:00
pdf_document_properties.js Moves all document.getElementById lookups into viewer.js 2016-04-21 11:39:11 -05:00
pdf_find_bar.js Added multiple term search functionality (with default phrase search) 2016-05-26 18:24:58 +05:00
pdf_find_controller.js Merge pull request #5579 from jazzy-em/master 2016-05-27 14:23:26 -05:00
pdf_history.js Fixes some static analysis warnings and recommendations 2016-05-02 17:34:58 -05:00
pdf_link_service.js Merge pull request #7341 from Snuffleupagus/getDestinationHash-Array 2016-06-09 00:29:10 +02:00
pdf_outline_viewer.js Fixes some static analysis warnings and recommendations 2016-05-02 17:34:58 -05:00
pdf_page_view.js trivial spelling fixes 2016-07-17 14:33:41 +02:00
pdf_presentation_mode.js Removes circular dependency of secondary toolbar on app.js. 2016-04-28 15:04:09 -05:00
pdf_rendering_queue.js Introduces UMD headers to the web/ folder. 2016-04-13 10:09:48 -05:00
pdf_sidebar.js Adds EventBus. 2016-04-28 06:57:24 -05:00
pdf_thumbnail_view.js Introduces UMD headers to the web/ folder. 2016-04-13 10:09:48 -05:00
pdf_thumbnail_viewer.js Fixes some static analysis warnings and recommendations 2016-05-02 17:34:58 -05:00
pdf_viewer.component.js Fixes AMD name in the web/pdf_viewer.js. 2016-05-16 12:01:29 -05:00
pdf_viewer.css Better components examples. 2016-04-28 13:30:03 -05:00
pdf_viewer.js Remove the previousPageNumber parameter from the pagechanging/pagechange` events, and stop dispatching the events if the input is out of bounds 2016-07-25 10:08:53 +02:00
pdfjs.js Replace pdfjsLib with module that represents pdf.js. 2016-04-13 10:11:34 -05:00
preferences.js Moves DEFAULT_PREFENCES into JSON format. 2016-05-11 17:58:17 -05:00
secondary_toolbar.js Convert the secondary toolbar to a class 2016-05-11 20:53:39 +02:00
text_layer_builder.css Use default line height for the text layer 2015-12-02 23:00:12 +01:00
text_layer_builder.js Merge pull request #5579 from jazzy-em/master 2016-05-27 14:23:26 -05:00
ui_utils.js Adds EventBus. 2016-04-28 06:57:24 -05:00
view_history.js Introduces UMD headers to the web/ folder. 2016-04-13 10:09:48 -05:00
viewer-snippet-chrome-extension.html Remove type="text/javascript" from script tags. 2014-05-13 02:41:01 +02:00
viewer-snippet-chrome-overlays.html Add translations of "Allow access to file URLs" 2015-08-14 18:59:55 +02:00
viewer-snippet-firefox-extension.html Remove XHTML leftovers from the viewer HTML files 2016-02-14 13:23:34 +01:00
viewer-snippet-minified.html Remove XHTML leftovers from the viewer HTML files 2016-02-14 13:23:34 +01:00
viewer-snippet-mozPrintCallback-polyfill.html Revert PR 5510, except in WebKit browsers, for breaking print preview in Firefox 2015-03-07 00:16:55 +01:00
viewer-snippet.html Remove XHTML leftovers from the viewer HTML files 2016-02-14 13:23:34 +01:00
viewer.css Fix insertion of blank pages during printing due to non-matching page sizes 2016-03-21 14:21:07 -07:00
viewer.html [Firefox addon] Remove compatibility.js 2016-07-09 17:59:06 +02:00
viewer.js Ensure that the necessary src/* dependencies are loaded before the viewer, when it's run with gulp server (issue 7448) 2016-06-29 15:19:28 +02:00