Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b40fb3814a
pdf.js/web
History
Jonas Jenwald 842e9206c0 Replace String.prototype.substr() occurrences with String.prototype.substring() 
As outlined in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr, which refers to the ECMA-262 specification, using the `substr` function is advised against.

Hence this PR, which replaces all remaining `substr` occurrences with `substring` instead. Please refer to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr#Syntax respectively https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring#Syntax for the differences between the two functions.

Note that in most cases in the code-base there's only one argument passed to `substr`, and those require no other changes except replacing "substr" with "substring". For the other cases, the `substr(start, length)` calls are changed to `substring(start, start + length)` instead.
2018-09-28 11:41:07 +02:00
..
images Add spread modes to web viewer 2018-05-14 23:10:32 -04:00
.eslintrc Provide custom messages for the no-restricted-globals ESLint rule, and refactor the .eslintrc files (PR 9868 follow-up) 2018-07-23 14:10:13 +02:00
.gitignore Remove obselete file from .gitignore 2015-01-26 16:44:45 +01:00
annotation_layer_builder.css Clean up browser-specific CSS 2018-04-04 00:25:12 +02:00
annotation_layer_builder.js Move the imageResourcesPath option to a BaseViewer/PDFPageView/AnnotationLayerBuilder option 2018-02-13 14:28:38 +01:00
app_options.js Add general support for re-dispatching events, on EventBus instances, to the DOM 2018-08-30 17:28:12 +02:00
app.js Add initial support for "Whole words" searching in the viewer 2018-09-10 11:59:29 +02:00
base_viewer.js Remove left-over this.enhanceTextSelection property from the BaseViewer constructor (PR 9479 follow-up) 2018-08-20 16:01:31 +02:00
chrome-i18n-allow-access-to-file-urls.json Add translations of "Allow access to file URLs" 2015-08-14 18:59:55 +02:00
chromecom.js Refactor the Preferences classes to utilize async methods rather than manually returning Promises 2018-09-03 09:52:36 +02:00
compressed.tracemonkey-pldi-09.pdf Add Makefile. Move some files around to make building the website easier. 2011-07-05 10:53:57 -07:00
debugger.js Replace String.prototype.substr() occurrences with String.prototype.substring() 2018-09-28 11:41:07 +02:00
default_preferences.json Add general support for re-dispatching events, on EventBus instances, to the DOM 2018-08-30 17:28:12 +02:00
dom_events.js Add general support for re-dispatching events, on EventBus instances, to the DOM 2018-08-30 17:28:12 +02:00
download_manager.js Stop exposing the URL polyfill in the global scope 2018-07-04 09:16:28 +02:00
firefox_print_service.js Use let/const instead of var in the printing code 2017-10-22 16:13:14 +02:00
firefoxcom.js Enable forwarding, in FirefoxCom, of the matchesCount to the browser findbar (bug 1062025) 2018-09-15 23:45:38 +02:00
genericcom.js Refactor the Preferences classes to utilize async methods rather than manually returning Promises 2018-09-03 09:52:36 +02:00
genericl10n.js Refactor the IL10n implementations to utilize async methods rather than manually returning Promises 2018-09-03 09:52:36 +02:00
grab_to_pan.js Enable the no-var ESLint rule in the /web folder 2017-11-05 16:53:47 +01:00
interfaces.js Refactor the IL10n implementations to utilize async methods rather than manually returning Promises 2018-09-03 09:52:36 +02:00
overlay_manager.js Refactor the OverlayManager to utilize async methods rather than manually returning Promises 2018-09-03 09:52:36 +02:00
password_prompt.js Change var to let, and use object destructuring, in a couple of previously class converted web/*.js files 2017-07-03 11:22:49 +02:00
pdf_attachment_viewer.js Move the disableCreateObjectURL option from the global PDFJS object and into getDocument instead 2018-03-01 18:11:17 +01:00
pdf_cursor_tools.js Simplify resetting of the SecondaryToolbar Scroll/Spread mode buttons, and add a missing comment in PDFCursorTools 2018-07-08 10:55:56 +02:00
pdf_document_properties.js Expose the Linearization status in the document properties dialog 2018-07-26 17:30:46 +02:00
pdf_find_bar.js Improve plural support for the matches counter 2018-09-16 14:23:06 +02:00
pdf_find_controller.js Further ensure that PDFFindController._requestMatchesCount won't return broken data (PR 10052 follow-up) 2018-09-15 23:45:38 +02:00
pdf_find_utils.js Add initial support for "Whole words" searching in the viewer 2018-09-10 11:59:29 +02:00
pdf_history.js Replace the remaining occurences of instanceof Array with Array.isArray() 2018-07-09 13:17:41 +02:00
pdf_link_service.js Replace the remaining occurences of instanceof Array with Array.isArray() 2018-07-09 13:17:41 +02:00
pdf_outline_viewer.js Move various viewer components options from PDFJS/PDFViewerApplication.viewerPrefs and into AppOptions instead 2018-03-01 18:11:16 +01:00
pdf_page_view.js Replace the PDFJS.disableWebGL option with a enableWebGL option passed, via BaseViewer/PDFPageView, to PDFPageProxy.render 2018-02-13 16:56:56 +01:00
pdf_presentation_mode.js Add source parameters to all remaining EventBus.dispatch calls that are currently missing those 2018-08-30 10:39:32 +02:00
pdf_print_service.js Stop exposing the URL polyfill in the global scope 2018-07-04 09:16:28 +02:00
pdf_rendering_queue.js Replace a few occurences of var with let in already ES6 converted web/ files 2017-10-22 16:23:38 +02:00
pdf_sidebar_resizer.js Only resize the sidebar with the left mouse button 2017-12-02 19:05:17 +01:00
pdf_sidebar.js Layout the sidebar in the same vertical position regardless of the viewer width (issue 4052, bug 850591) 2017-10-11 18:17:28 +02:00
pdf_single_page_viewer.js Re-factor updating of Scroll/Spread modes, and place all the code in BaseViewer with overrides (as necessary) in the extending classes 2018-06-30 12:36:56 +02:00
pdf_thumbnail_view.js Refactor PDFThumbnailViewer.scrollThumbnailIntoView to avoid unnecessary DOM look-ups 2018-02-09 14:43:11 +01:00
pdf_thumbnail_viewer.js Replace the remaining occurences of instanceof Array with Array.isArray() 2018-07-09 13:17:41 +02:00
pdf_viewer.component.js [api-major] Completely remove the global PDFJS object 2018-03-01 18:13:27 +01:00
pdf_viewer.css Add spread modes to web viewer 2018-05-14 23:10:32 -04:00
pdf_viewer.js Re-factor updating of Scroll/Spread modes, and place all the code in BaseViewer with overrides (as necessary) in the extending classes 2018-06-30 12:36:56 +02:00
pdfjs.js Use ES6 notation, and replace var with let, in web/pdf_viewer.component.js and web/pdfjs.js 2017-11-05 16:53:47 +01:00
preferences.js Refactor the Preferences classes to utilize async methods rather than manually returning Promises 2018-09-03 09:52:36 +02:00
secondary_toolbar.js Temporarily disable the Spread mode buttons when horizontal scrolling is enabled 2018-07-08 12:11:03 +02:00
text_layer_builder.css Clean up browser-specific CSS 2018-04-04 00:25:12 +02:00
text_layer_builder.js Move scrolling the selected match into view from the find controller to the text layer builder 2018-09-13 22:06:01 +02:00
toolbar.js Add source parameters to all remaining EventBus.dispatch calls that are currently missing those 2018-08-30 10:39:32 +02:00
ui_utils.js Replace String.prototype.substr() occurrences with String.prototype.substring() 2018-09-28 11:41:07 +02:00
view_history.js Refactor the ViewHistory to utilize async methods rather than manually returning Promises 2018-09-03 09:52:36 +02:00
viewer_compatibility.js Remove the disableFullscreen hack for embedded IE 11 (issue 9585) 2018-06-14 12:25:28 +02:00
viewer-snippet-chrome-extension.html Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
viewer-snippet-chrome-overlays.html [CRX] Add file chooser as fallback (fixes #9411) 2018-03-21 18:21:46 +01:00
viewer-snippet-firefox-extension.html Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
viewer-snippet-minified.html Remove XHTML leftovers from the viewer HTML files 2016-02-14 13:23:34 +01:00
viewer-snippet.html Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
viewer.css Hide the Scroll/Spread mode buttons when the viewer is a PDFSinglePageViewer instance 2018-07-08 12:08:48 +02:00
viewer.html Add initial support for "Whole words" searching in the viewer 2018-09-10 11:59:29 +02:00
viewer.js Remove unused findStatusIcon property from PDFFindBar instances 2018-09-10 11:59:30 +02:00