pdf.js/extensions/chromium/options/migration.js
Jonas Jenwald c591826f3b Enable the no-nested-ternary ESLint rule (PR 11488 follow-up)
This rule is already enabled in mozilla-central, and helps avoid some confusing formatting, see https://searchfox.org/mozilla-central/rev/9e45d74b956be046e5021a746b0c8912f1c27318/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#209-210

With the recent introduction of Prettier some of the existing nested ternary statements became even more difficult to read, since any possibly helpful indentation was removed.
This particular ESLint rule wasn't entirely straightforward to enable, and I do recognize that there's a certain amount of subjectivity in the changes being made. Generally, the changes in this patch fall into three categories:
 - Cases where a value is only clamped to a certain range (the easiest ones to update).
 - Cases where the values involved are "simple", such as Numbers and Strings, which are re-factored to initialize the variable with the *default* value and only update it when necessary by using `if`/`else if` statements.
 - Cases with more complex and/or larger values, such as TypedArrays, which are re-factored to let the variable be (implicitly) undefined and where all values are then set through `if`/`else if`/`else` statements.

Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-nested-ternary
2020-01-14 17:49:39 +01:00

161 lines
5.1 KiB
JavaScript

/*
Copyright 2016 Mozilla Foundation
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
/* eslint strict: ["error", "function"] */
(function() {
"use strict";
var storageLocal = chrome.storage.local;
var storageSync = chrome.storage.sync;
if (!storageSync) {
// No sync storage area - nothing to migrate to.
return;
}
getStorageNames(function(storageKeys) {
storageLocal.get(storageKeys, function(values) {
if (!values || !Object.keys(values).length) {
// No local storage - nothing to migrate.
// ... except possibly for a renamed preference name.
migrateRenamedStorage();
return;
}
migrateToSyncStorage(values);
});
});
function getStorageNames(callback) {
var x = new XMLHttpRequest();
var schema_location = chrome.runtime.getManifest().storage.managed_schema;
x.open("get", chrome.runtime.getURL(schema_location));
x.onload = function() {
var storageKeys = Object.keys(x.response.properties);
callback(storageKeys);
};
x.responseType = "json";
x.send();
}
// Save |values| to storage.sync and delete the values with that key from
// storage.local.
function migrateToSyncStorage(values) {
storageSync.set(values, function() {
if (chrome.runtime.lastError) {
console.error(
"Failed to migrate settings due to an error: " +
chrome.runtime.lastError.message
);
return;
}
// Migration successful. Delete local settings.
storageLocal.remove(Object.keys(values), function() {
// In theory remove() could fail (e.g. if the browser's storage
// backend is corrupt), but since storageSync.set succeeded, consider
// the migration successful.
console.log(
"Successfully migrated preferences from local to sync storage."
);
migrateRenamedStorage();
});
});
}
// TODO: Remove this migration code somewhere in the future, when most users
// have had their chance of migrating to the new preference format.
// Note: We cannot modify managed preferences, so the migration logic is
// duplicated in web/chromecom.js too.
function migrateRenamedStorage() {
storageSync.get(
[
"enableHandToolOnLoad",
"cursorToolOnLoad",
"disableTextLayer",
"enhanceTextSelection",
"textLayerMode",
"showPreviousViewOnLoad",
"disablePageMode",
"viewOnLoad",
],
function(items) {
// Migration code for https://github.com/mozilla/pdf.js/pull/7635.
if (typeof items.enableHandToolOnLoad === "boolean") {
if (items.enableHandToolOnLoad) {
storageSync.set(
{
cursorToolOnLoad: 1,
},
function() {
if (!chrome.runtime.lastError) {
storageSync.remove("enableHandToolOnLoad");
}
}
);
} else {
storageSync.remove("enableHandToolOnLoad");
}
}
// Migration code for https://github.com/mozilla/pdf.js/pull/9479.
if (typeof items.disableTextLayer === "boolean") {
var textLayerMode = 1;
if (items.disableTextLayer) {
textLayerMode = 0;
} else if (items.enhanceTextSelection) {
textLayerMode = 2;
}
if (textLayerMode !== 1) {
// Overwrite if computed textLayerMode is not the default value (1).
storageSync.set(
{
textLayerMode: textLayerMode,
},
function() {
if (!chrome.runtime.lastError) {
storageSync.remove([
"disableTextLayer",
"enhanceTextSelection",
]);
}
}
);
} else {
storageSync.remove(["disableTextLayer", "enhanceTextSelection"]);
}
}
// Migration code for https://github.com/mozilla/pdf.js/pull/10502.
if (typeof items.showPreviousViewOnLoad === "boolean") {
if (!items.showPreviousViewOnLoad) {
storageSync.set(
{
viewOnLoad: 1,
},
function() {
if (!chrome.runtime.lastError) {
storageSync.remove([
"showPreviousViewOnLoad",
"disablePageMode",
]);
}
}
);
} else {
storageSync.remove(["showPreviousViewOnLoad", "disablePageMode"]);
}
}
}
);
}
})();