a177afc206
This fixes only those warnings, as reported by https://lgtm.com/projects/g/mozilla/pdf.js?mode=list, that make sense (as far as I'm concerned). Hence this patch leaves the following things unaddressed: - The "recommendation"-category, since it only complains about unused variables. However, note that all of those cases are purposely included and that there's thus ESLint-disable comments added to explictly allow them. - The "warning"-category, which still contains two complaints. However, as far as I can tell, they are both false positives. Given first of all the false positives of the LGTM static analyzer, and secondly that we'd need to add (essentially duplicated) disable-comments for the unused variable cases, it's not entirely clear to me if we actually want to work towards including LGTM in the PDF.js project (e.g. running alongside Travis) or if we should just close issue 11965.
56 lines
1.7 KiB
JavaScript
56 lines
1.7 KiB
JavaScript
/* Copyright 2017 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { DefaultExternalServices, PDFViewerApplication } from "./app.js";
|
|
import { BasePreferences } from "./preferences.js";
|
|
import { DownloadManager } from "./download_manager.js";
|
|
import { GenericL10n } from "./genericl10n.js";
|
|
|
|
if (typeof PDFJSDev !== "undefined" && !PDFJSDev.test("GENERIC")) {
|
|
throw new Error(
|
|
'Module "pdfjs-web/genericcom" shall not be used outside ' +
|
|
"GENERIC build."
|
|
);
|
|
}
|
|
|
|
const GenericCom = {};
|
|
|
|
class GenericPreferences extends BasePreferences {
|
|
async _writeToStorage(prefObj) {
|
|
localStorage.setItem("pdfjs.preferences", JSON.stringify(prefObj));
|
|
}
|
|
|
|
async _readFromStorage(prefObj) {
|
|
return JSON.parse(localStorage.getItem("pdfjs.preferences"));
|
|
}
|
|
}
|
|
|
|
class GenericExternalServices extends DefaultExternalServices {
|
|
static createDownloadManager(options) {
|
|
return new DownloadManager();
|
|
}
|
|
|
|
static createPreferences() {
|
|
return new GenericPreferences();
|
|
}
|
|
|
|
static createL10n({ locale = "en-US" }) {
|
|
return new GenericL10n(locale);
|
|
}
|
|
}
|
|
PDFViewerApplication.externalServices = GenericExternalServices;
|
|
|
|
export { GenericCom };
|