c7af2db2ec
Initially I just implemented the unit tests, but quickly found that they were failing my expectation of having a size of 256 items. Some of them did contain 256 items and some did not. I looked up various resources and figured that they indeed all need to have 256 items. One of the good resources is https://github.com/davidben/poppler/blob/master/poppler/FontEncodingTables.cc Aside from some missing `notdef` (empty string) entries at the end of the arrays, which I assume causes issues since it may cause out-of-bounds array access which in JavaScript gives `undefined`, there was a `notdef` entry missing in the `MacExpertEncoding`, causing the entries after that to be shifted. This fix for this is similar to the one in #8589. The unit tests verify that, for known encoding names, the return value is not only an array, but that it is also of the right length and contains only strings.
43 lines
1.5 KiB
JavaScript
43 lines
1.5 KiB
JavaScript
/* Copyright 2017 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { getEncoding } from '../../src/core/encodings';
|
|
|
|
describe('encodings', function() {
|
|
describe('getEncoding', function() {
|
|
it('fetches a valid array for known encoding names', function() {
|
|
const knownEncodingNames = [
|
|
'ExpertEncoding', 'MacExpertEncoding', 'MacRomanEncoding',
|
|
'StandardEncoding', 'SymbolSetEncoding', 'WinAnsiEncoding',
|
|
'ZapfDingbatsEncoding',
|
|
];
|
|
|
|
for (const knownEncodingName of knownEncodingNames) {
|
|
const encoding = getEncoding(knownEncodingName);
|
|
expect(Array.isArray(encoding)).toEqual(true);
|
|
expect(encoding.length).toEqual(256);
|
|
|
|
for (const item of encoding) {
|
|
expect(typeof item).toEqual('string');
|
|
}
|
|
}
|
|
});
|
|
|
|
it('fetches `null` for unknown encoding names', function() {
|
|
expect(getEncoding('FooBarEncoding')).toEqual(null);
|
|
});
|
|
});
|
|
});
|