642d8621ef
We're currently making use of `uniquePrefix`/`idCounters` in multiple files, to create unique object id's, and adding a new occurrence of them requires some care to ensure that an object id isn't accidentally reused. Furthermore, having to pass around multiple parameters as we currently do seem like something you want to avoid. Instead, this patch adds a factory which means that there's only *one* thing that needs to be passed around. And since it's now only necessary to call a method in order to obtain a unique object id, the details are thus abstracted away at the call-sites which avoids accidental reuse of object id's. To test that this works as expected a very simple `Page` unit-test is added, and the existing `Annotation layer` tests are also adjusted slightly.
57 lines
2.1 KiB
JavaScript
57 lines
2.1 KiB
JavaScript
/* Copyright 2017 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
'use strict';
|
|
|
|
(function (root, factory) {
|
|
if (typeof define === 'function' && define.amd) {
|
|
define('pdfjs-test/unit/document_spec', ['exports', 'pdfjs/core/document'],
|
|
factory);
|
|
} else if (typeof exports !== 'undefined') {
|
|
factory(exports, require('../../src/core/document.js'));
|
|
} else {
|
|
factory((root.pdfjsTestUnitDocumentSpec = {}),
|
|
root.pdfjsCoreDocument);
|
|
}
|
|
}(this, function (exports, coreDocument) {
|
|
|
|
var Page = coreDocument.Page;
|
|
|
|
describe('document', function () {
|
|
describe('Page', function () {
|
|
it('should create correct objId using the idFactory', function () {
|
|
var page1 = new Page(/* pdfManager = */ { }, /* xref = */ null,
|
|
/* pageIndex = */ 0,
|
|
/* pageDict = */ null, /* ref = */ null,
|
|
/* fontCache = */ null);
|
|
var page2 = new Page(/* pdfManager = */ { }, /* xref = */ null,
|
|
/* pageIndex = */ 1,
|
|
/* pageDict = */ null, /* ref = */ null,
|
|
/* fontCache = */ null);
|
|
|
|
var idFactory1 = page1.idFactory, idFactory2 = page2.idFactory;
|
|
|
|
expect(idFactory1.createObjId()).toEqual('p0_1');
|
|
expect(idFactory1.createObjId()).toEqual('p0_2');
|
|
|
|
expect(idFactory2.createObjId()).toEqual('p1_1');
|
|
expect(idFactory2.createObjId()).toEqual('p1_2');
|
|
|
|
expect(idFactory1.createObjId()).toEqual('p0_3');
|
|
expect(idFactory1.createObjId()).toEqual('p0_4');
|
|
});
|
|
});
|
|
});
|
|
}));
|