Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
52fce0d17b
pdf.js/web
History
Jonas Jenwald fa8c0ef616 [api-minor] Change PDFFindController to use the "find"-event directly (issue 12731) 
Looking at the code, I do have to agree with the point made in issue 12731 about it being unexpected/unhelpful that the `PDFFindController.executeCommand`-method isn't directly usable with the "find"-event.
The reason for it being this way is, as so often, for historical reasons: The `executeCommand`-method was added (just) prior to the introduction of the `EventBus` in the viewer.

Obviously we cannot simply change the existing `PDFFindController.executeCommand`-method, since that'd be a breaking change in code which has existed for over five years.
Initially I figured that we could simply add a new method in `PDFFindController` that'd accept the state from the "find"-event, however after thinking about this and looking through the use-cases in the default viewer I settled on a slightly different approach: Let the `PDFFindController` just listen for the "find"-event (on the `EventBus`-instance) directly instead, which also removes one level of (unneeded) indirection during searching in the default viewer.

For GENERIC builds of the PDF.js library, the old `PDFFindController.executeCommand`-method is still available with a deprecation warning.
2021-10-16 10:36:22 +02:00
..
images Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
.gitignore Remove obselete file from .gitignore 2015-01-26 16:44:45 +01:00
annotation_layer_builder.css [Regression] Fix comb fields scrolling when the last character is entered (PR 14049 follow-up) 2021-10-05 09:36:08 +02:00
annotation_layer_builder.js Re-factor document.getElementsByName lookups in the AnnotationLayer (issue 14003) 2021-09-23 13:05:18 +02:00
app_options.js [GENERIC viewer] Warn about AppOptions being overridden by Preferences during loading 2021-09-22 15:43:26 +02:00
app.js [api-minor] Change PDFFindController to use the "find"-event directly (issue 12731) 2021-10-16 10:36:22 +02:00
base_tree_viewer.js Add support for finding/highlighting the outlineItem, corresponding to the currently visible page, in the sidebar (issue 7557, bug 1253820, bug 1499050) 2021-01-09 16:09:44 +01:00
base_viewer.js Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
chrome-i18n-allow-access-to-file-urls.json Add translations of "Allow access to file URLs" 2015-08-14 18:59:55 +02:00
chromecom.js Account for formatting changes in Prettier version 2.3.0 2021-05-16 11:44:05 +02:00
compressed.tracemonkey-pldi-09.pdf Add Makefile. Move some files around to make building the website easier. 2011-07-05 10:53:57 -07:00
debugger.js Re-factor loadAndEnablePDFBug and PDFBug.init 2021-08-19 12:06:23 +02:00
download_manager.js [GENERIC viewer] Always show the Download-buttons, to allow saving of forms (issue 13997) 2021-09-15 23:51:56 +02:00
firefox_print_service.js Re-factor the CSS_PIXELS_PER_INCH/PDF_PIXELS_PER_INCH exports (PR 13991 follow-up) 2021-09-11 11:15:25 +02:00
firefoxcom.js [api-minor] Change PDFFindController to use the "find"-event directly (issue 12731) 2021-10-16 10:36:22 +02:00
generic_scripting.js Account for formatting changes in Prettier version 2.3.0 2021-05-16 11:44:05 +02:00
genericcom.js Pass in the "sandboxBundleSrc" option when calling DefaultExternalServices.createScripting 2020-12-23 14:05:49 +01:00
genericl10n.js [GENERIC viewer] Try to fixup "incomplete" language codes (issue 13689) 2021-07-08 12:54:58 +02:00
grab_to_pan.js [GrabToPan] Use Element.matches() rather than prefixed ...matchesSelector versions 2021-03-26 21:37:51 +01:00
interfaces.js [api-minor] Add a wrapper around the addLinkAttributes-function, in the API, to the PDFLinkService implementations 2021-10-02 12:28:00 +02:00
l10n_utils.js [GENERIC viewer] Try to fixup "incomplete" language codes (issue 13689) 2021-07-08 12:54:58 +02:00
overlay_manager.js Fix the linting errors, from the Prettier auto-formatting, that ESLint --fix couldn't handle 2019-12-26 12:35:12 +01:00
password_prompt.js Collect all l10n fallback strings, used in the viewer, in one helper function (PR 12981 follow-up) 2021-03-04 11:34:51 +01:00
pdf_attachment_viewer.js [api-minor] Support the Content-Disposition filename in the Firefox PDF Viewer (bug 1694556, PR 9379 follow-up) 2021-02-26 10:50:29 +01:00
pdf_cursor_tools.js Remove the useless PresentationModeState.CHANGING-case in PDFCursorTools (PR 12788 follow-up) 2021-02-14 10:39:49 +01:00
pdf_document_properties.js Move the getPdfFilenameFromUrl helper function from web/ui_utils.js and into src/display/display_utils.js 2021-03-17 15:48:24 +01:00
pdf_find_bar.js [api-minor] Change PDFFindController to use the "find"-event directly (issue 12731) 2021-10-16 10:36:22 +02:00
pdf_find_controller.js [api-minor] Change PDFFindController to use the "find"-event directly (issue 12731) 2021-10-16 10:36:22 +02:00
pdf_find_utils.js Enable auto-formatting of the entire code-base using Prettier (issue 11444) 2019-12-26 12:34:24 +01:00
pdf_history.js Change the parseQueryString function to return a Map rather than an Object (issue 13829) 2021-07-31 23:24:49 +02:00
pdf_layer_viewer.js Account for formatting changes in Prettier version 2.3.0 2021-05-16 11:44:05 +02:00
pdf_link_service.js [api-minor] Add a wrapper around the addLinkAttributes-function, in the API, to the PDFLinkService implementations 2021-10-02 12:28:00 +02:00
pdf_outline_viewer.js [api-minor] Add a wrapper around the addLinkAttributes-function, in the API, to the PDFLinkService implementations 2021-10-02 12:28:00 +02:00
pdf_page_view.js Fix the remaining Promise.resolve(undefined) cases 2021-10-15 22:42:13 +02:00
pdf_presentation_mode.js Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
pdf_print_service.js Re-factor the CSS_PIXELS_PER_INCH/PDF_PIXELS_PER_INCH exports (PR 13991 follow-up) 2021-09-11 11:15:25 +02:00
pdf_rendering_queue.js Ensure that pre-rendering works correctly with spreadModes at higher zoom levels 2021-10-14 11:20:49 +02:00
pdf_scripting_manager.js Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
pdf_sidebar_resizer.js Use more optional chaining in the web/-folder (PR 12961 follow-up) 2021-03-07 16:20:52 +01:00
pdf_sidebar.js Improve the handling of the currentOutlineButton enabling/disabling (PR 12777 follow-up) 2021-04-10 13:12:47 +02:00
pdf_thumbnail_view.js Fix the remaining Promise.resolve(undefined) cases 2021-10-15 22:42:13 +02:00
pdf_thumbnail_viewer.js [api-minor] Change {PDFPageView, PDFThumbnailView}.update to take a parameter object 2021-09-04 11:39:25 +02:00
pdf_viewer.component.js Move PDFSinglePageViewer into the web/pdf_viewer.js file 2021-10-12 13:45:19 +02:00
pdf_viewer.css Annotation & XFA: Scale the font size in choicelist using zoom factor (bug 1715996) 2021-08-04 20:36:04 +02:00
pdf_viewer.js Move PDFSinglePageViewer into the web/pdf_viewer.js file 2021-10-12 13:45:19 +02:00
pdfjs.js Enable auto-formatting of the entire code-base using Prettier (issue 11444) 2019-12-26 12:34:24 +01:00
preferences.js Remove some *indirect* loops in the BasePreferences.getAll-method 2021-03-22 14:38:05 +01:00
print_utils.js Add PDF_TO_CSS_UNITS to the PixelsPerInch-structure 2021-09-20 13:20:09 +02:00
secondary_toolbar.js Move PDFSinglePageViewer into the web/pdf_viewer.js file 2021-10-12 13:45:19 +02:00
struct_tree_layer_builder.js Fix Viewer API definitions and include in CI 2021-08-25 18:45:46 -04:00
text_highlighter.js Fix Viewer API definitions and include in CI 2021-08-25 18:45:46 -04:00
text_layer_builder.css Visually hide br in text selections 2021-08-01 19:42:05 +02:00
text_layer_builder.js Enable XFA by default in the viewer, and components/ examples (issue 13968) 2021-09-14 16:54:36 +02:00
toolbar.js [api-minor] Add a wrapper around the addLinkAttributes-function, in the API, to the PDFLinkService implementations 2021-10-02 12:28:00 +02:00
ui_utils.js Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
view_history.js Add a bit more validation in the ViewHistory constructor 2020-03-21 13:55:06 +01:00
viewer-snippet-chrome-extension.html Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
viewer-snippet-chrome-overlays.html [CRX] Add file chooser as fallback (fixes #9411) 2018-03-21 18:21:46 +01:00
viewer-snippet-firefox-extension.html Stop bundling the ReadableStream polyfill in MOZCENTRAL builds (PR 10470 follow-up) 2019-01-23 20:33:20 +01:00
viewer-snippet-minified.html Remove XHTML leftovers from the viewer HTML files 2016-02-14 13:23:34 +01:00
viewer-snippet.html Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
viewer.css Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
viewer.html Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
viewer.js Add a new Page scrolling mode (issue 2638, 8952, 10907) 2021-10-12 13:45:15 +02:00
xfa_layer_builder.css Merge pull request #14049 from calixteman/bg_from_mk 2021-09-29 21:13:20 +02:00
xfa_layer_builder.js Ensure that various URL-related options are applied in the xfaLayer too 2021-10-02 09:32:23 +02:00