http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/extensions/firefox/content/PdfStreamConverter.jsm b/extensions/firefox/content/PdfStreamConverter.jsm index ea91a71a..0d59dad1 100644 --- a/extensions/firefox/content/PdfStreamConverter.jsm +++ b/extensions/firefox/content/PdfStreamConverter.jsm @@ -773,7 +773,8 @@ class RequestListener { response = function sendResponse(aResponse) { try { var listener = doc.createEvent("CustomEvent"); - let detail = Cu.cloneInto({ response: aResponse, }, doc.defaultView); + let detail = Cu.cloneInto({ response: aResponse, }, + doc.defaultView); listener.initCustomEvent("pdf.js.response", true, false, detail); return message.dispatchEvent(listener); } catch (e) { ```
		
			
				
	
	
		
			70 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			70 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
/* Copyright 2013 Mozilla Foundation
 | 
						|
 *
 | 
						|
 * Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
 * you may not use this file except in compliance with the License.
 | 
						|
 * You may obtain a copy of the License at
 | 
						|
 *
 | 
						|
 *     http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 *
 | 
						|
 * Unless required by applicable law or agreed to in writing, software
 | 
						|
 * distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
 * See the License for the specific language governing permissions and
 | 
						|
 * limitations under the License.
 | 
						|
 */
 | 
						|
/* eslint max-len: ["error", 100] */
 | 
						|
 | 
						|
"use strict";
 | 
						|
 | 
						|
this.EXPORTED_SYMBOLS = ["PdfJsTelemetry"];
 | 
						|
 | 
						|
const Cu = Components.utils;
 | 
						|
Cu.import("resource://gre/modules/Services.jsm");
 | 
						|
 | 
						|
this.PdfJsTelemetry = {
 | 
						|
  onViewerIsUsed() {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_USED");
 | 
						|
    histogram.add(true);
 | 
						|
  },
 | 
						|
  onFallback() {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_FALLBACK_SHOWN");
 | 
						|
    histogram.add(true);
 | 
						|
  },
 | 
						|
  onDocumentSize(size) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_DOCUMENT_SIZE_KB");
 | 
						|
    histogram.add(size / 1024);
 | 
						|
  },
 | 
						|
  onDocumentVersion(versionId) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_DOCUMENT_VERSION");
 | 
						|
    histogram.add(versionId);
 | 
						|
  },
 | 
						|
  onDocumentGenerator(generatorId) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_DOCUMENT_GENERATOR");
 | 
						|
    histogram.add(generatorId);
 | 
						|
  },
 | 
						|
  onEmbed(isObject) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_EMBED");
 | 
						|
    histogram.add(isObject);
 | 
						|
  },
 | 
						|
  onFontType(fontTypeId) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_FONT_TYPES");
 | 
						|
    histogram.add(fontTypeId);
 | 
						|
  },
 | 
						|
  onForm(isAcroform) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_FORM");
 | 
						|
    histogram.add(isAcroform);
 | 
						|
  },
 | 
						|
  onPrint() {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_PRINT");
 | 
						|
    histogram.add(true);
 | 
						|
  },
 | 
						|
  onStreamType(streamTypeId) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_STREAM_TYPES");
 | 
						|
    histogram.add(streamTypeId);
 | 
						|
  },
 | 
						|
  onTimeToView(ms) {
 | 
						|
    let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_TIME_TO_VIEW_MS");
 | 
						|
    histogram.add(ms);
 | 
						|
  },
 | 
						|
};
 |