4f48c8198c
http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/extensions/firefox/content/PdfStreamConverter.jsm b/extensions/firefox/content/PdfStreamConverter.jsm index ea91a71a..0d59dad1 100644 --- a/extensions/firefox/content/PdfStreamConverter.jsm +++ b/extensions/firefox/content/PdfStreamConverter.jsm @@ -773,7 +773,8 @@ class RequestListener { response = function sendResponse(aResponse) { try { var listener = doc.createEvent("CustomEvent"); - let detail = Cu.cloneInto({ response: aResponse, }, doc.defaultView); + let detail = Cu.cloneInto({ response: aResponse, }, + doc.defaultView); listener.initCustomEvent("pdf.js.response", true, false, detail); return message.dispatchEvent(listener); } catch (e) { ```
95 lines
2.8 KiB
JavaScript
95 lines
2.8 KiB
JavaScript
/*
|
|
Copyright 2014 Mozilla Foundation
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
/* eslint strict: ["error", "function"] */
|
|
/* import-globals-from pdfHandler.js */
|
|
|
|
(function() {
|
|
'use strict';
|
|
|
|
if (!chrome.fileBrowserHandler) {
|
|
// Not on Chromium OS, bail out
|
|
return;
|
|
}
|
|
chrome.fileBrowserHandler.onExecute.addListener(onExecuteFileBrowserHandler);
|
|
|
|
/**
|
|
* Invoked when "Open with PDF Viewer" is chosen in the File browser.
|
|
*
|
|
* @param {String} id File browser action ID as specified in
|
|
* manifest.json
|
|
* @param {Object} details Object of type FileHandlerExecuteEventDetails
|
|
*/
|
|
function onExecuteFileBrowserHandler(id, details) {
|
|
if (id !== 'open-as-pdf') {
|
|
return;
|
|
}
|
|
var fileEntries = details.entries;
|
|
// "tab_id" is the currently documented format, but it is inconsistent with
|
|
// the other Chrome APIs that use "tabId" (http://crbug.com/179767)
|
|
var tabId = details.tab_id || details.tabId;
|
|
if (tabId > 0) {
|
|
chrome.tabs.get(tabId, function(tab) {
|
|
openViewer(tab && tab.windowId, fileEntries);
|
|
});
|
|
} else {
|
|
// Re-use existing window, if available.
|
|
chrome.windows.getLastFocused(function(chromeWindow) {
|
|
var windowId = chromeWindow && chromeWindow.id;
|
|
if (windowId) {
|
|
chrome.windows.update(windowId, { focused: true, });
|
|
}
|
|
openViewer(windowId, fileEntries);
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Open the PDF Viewer for the given list of PDF files.
|
|
*
|
|
* @param {number} windowId
|
|
* @param {Array} fileEntries List of Entry objects (HTML5 FileSystem API)
|
|
*/
|
|
function openViewer(windowId, fileEntries) {
|
|
if (!fileEntries.length) {
|
|
return;
|
|
}
|
|
var fileEntry = fileEntries.shift();
|
|
var url = fileEntry.toURL();
|
|
// Use drive: alias to get shorter (more human-readable) URLs.
|
|
url = url.replace(/^filesystem:chrome-extension:\/\/[a-p]{32}\/external\//,
|
|
'drive:');
|
|
url = getViewerURL(url);
|
|
|
|
if (windowId) {
|
|
chrome.tabs.create({
|
|
windowId: windowId,
|
|
active: true,
|
|
url: url,
|
|
}, function() {
|
|
openViewer(windowId, fileEntries);
|
|
});
|
|
} else {
|
|
chrome.windows.create({
|
|
type: 'normal',
|
|
focused: true,
|
|
url: url,
|
|
}, function(chromeWindow) {
|
|
openViewer(chromeWindow.id, fileEntries);
|
|
});
|
|
}
|
|
}
|
|
})();
|