http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/extensions/firefox/content/PdfStreamConverter.jsm b/extensions/firefox/content/PdfStreamConverter.jsm index ea91a71a..0d59dad1 100644 --- a/extensions/firefox/content/PdfStreamConverter.jsm +++ b/extensions/firefox/content/PdfStreamConverter.jsm @@ -773,7 +773,8 @@ class RequestListener { response = function sendResponse(aResponse) { try { var listener = doc.createEvent("CustomEvent"); - let detail = Cu.cloneInto({ response: aResponse, }, doc.defaultView); + let detail = Cu.cloneInto({ response: aResponse, }, + doc.defaultView); listener.initCustomEvent("pdf.js.response", true, false, detail); return message.dispatchEvent(listener); } catch (e) { ```
		
			
				
	
	
		
			46 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			46 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
/*
 | 
						|
Copyright 2014 Mozilla Foundation
 | 
						|
 | 
						|
Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
you may not use this file except in compliance with the License.
 | 
						|
You may obtain a copy of the License at
 | 
						|
 | 
						|
    http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 | 
						|
Unless required by applicable law or agreed to in writing, software
 | 
						|
distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
See the License for the specific language governing permissions and
 | 
						|
limitations under the License.
 | 
						|
*/
 | 
						|
 | 
						|
'use strict';
 | 
						|
 | 
						|
(function PageActionClosure() {
 | 
						|
  /**
 | 
						|
   * @param {number} tabId - ID of tab where the page action will be shown.
 | 
						|
   * @param {string} url - URL to be displayed in page action.
 | 
						|
   */
 | 
						|
  function showPageAction(tabId, displayUrl) {
 | 
						|
    // rewriteUrlClosure in viewer.js ensures that the URL looks like
 | 
						|
    // chrome-extension://[extensionid]/http://example.com/file.pdf
 | 
						|
    var url = /^chrome-extension:\/\/[a-p]{32}\/([^#]+)/.exec(displayUrl);
 | 
						|
    if (url) {
 | 
						|
      url = url[1];
 | 
						|
      chrome.pageAction.setPopup({
 | 
						|
        tabId: tabId,
 | 
						|
        popup: '/pageAction/popup.html?file=' + encodeURIComponent(url),
 | 
						|
      });
 | 
						|
      chrome.pageAction.show(tabId);
 | 
						|
    } else {
 | 
						|
      console.log('Unable to get PDF url from ' + displayUrl);
 | 
						|
    }
 | 
						|
  }
 | 
						|
 | 
						|
  chrome.runtime.onMessage.addListener(function(message, sender) {
 | 
						|
    if (message === 'showPageAction' && sender.tab) {
 | 
						|
      showPageAction(sender.tab.id, sender.tab.url);
 | 
						|
    }
 | 
						|
  });
 | 
						|
})();
 |