2f3805efbc
*Please note that most of the necessary code adjustments were made in PR 7890.* ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. *Note:* in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors *and* various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/
298 lines
8.6 KiB
JavaScript
298 lines
8.6 KiB
JavaScript
/*
|
|
* Copyright 2014 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
var http = require('http');
|
|
var path = require('path');
|
|
var fs = require('fs');
|
|
|
|
var mimeTypes = {
|
|
'.css': 'text/css',
|
|
'.html': 'text/html',
|
|
'.js': 'application/javascript',
|
|
'.json': 'application/json',
|
|
'.svg': 'image/svg+xml',
|
|
'.pdf': 'application/pdf',
|
|
'.xhtml': 'application/xhtml+xml',
|
|
'.gif': 'image/gif',
|
|
'.ico': 'image/x-icon',
|
|
'.png': 'image/png',
|
|
'.log': 'text/plain',
|
|
'.bcmap': 'application/octet-stream',
|
|
'.properties': 'text/plain'
|
|
};
|
|
|
|
var defaultMimeType = 'application/octet-stream';
|
|
|
|
function WebServer() {
|
|
this.root = '.';
|
|
this.host = 'localhost';
|
|
this.port = 0;
|
|
this.server = null;
|
|
this.verbose = false;
|
|
this.cacheExpirationTime = 0;
|
|
this.disableRangeRequests = false;
|
|
this.hooks = {
|
|
'GET': [],
|
|
'POST': []
|
|
};
|
|
}
|
|
WebServer.prototype = {
|
|
start: function (callback) {
|
|
this._ensureNonZeroPort();
|
|
this.server = http.createServer(this._handler.bind(this));
|
|
this.server.listen(this.port, this.host, callback);
|
|
console.log(
|
|
'Server running at http://' + this.host + ':' + this.port + '/');
|
|
},
|
|
stop: function (callback) {
|
|
this.server.close(callback);
|
|
this.server = null;
|
|
},
|
|
_ensureNonZeroPort: function () {
|
|
if (!this.port) {
|
|
// If port is 0, a random port will be chosen instead. Do not set a host
|
|
// name to make sure that the port is synchronously set by .listen().
|
|
var server = http.createServer().listen(0);
|
|
var address = server.address();
|
|
// .address().port being available synchronously is merely an
|
|
// implementation detail. So we are defensive here and fall back to some
|
|
// fixed port when the address is not available yet.
|
|
this.port = address ? address.port : 8000;
|
|
server.close();
|
|
}
|
|
},
|
|
_handler: function (req, res) {
|
|
var url = req.url.replace(/\/\//g, '/');
|
|
var urlParts = /([^?]*)((?:\?(.*))?)/.exec(url);
|
|
var pathPart = decodeURI(urlParts[1]), queryPart = urlParts[3];
|
|
var verbose = this.verbose;
|
|
|
|
var methodHooks = this.hooks[req.method];
|
|
if (!methodHooks) {
|
|
res.writeHead(405);
|
|
res.end('Unsupported request method', 'utf8');
|
|
return;
|
|
}
|
|
var handled = methodHooks.some(function (hook) {
|
|
return hook(req, res);
|
|
});
|
|
if (handled) {
|
|
return;
|
|
}
|
|
|
|
if (pathPart === '/favicon.ico') {
|
|
fs.realpath(path.join(this.root, 'test/resources/favicon.ico'),
|
|
checkFile);
|
|
return;
|
|
}
|
|
|
|
var disableRangeRequests = this.disableRangeRequests;
|
|
var cacheExpirationTime = this.cacheExpirationTime;
|
|
|
|
var filePath;
|
|
fs.realpath(path.join(this.root, pathPart), checkFile);
|
|
|
|
function checkFile(err, file) {
|
|
if (err) {
|
|
res.writeHead(404);
|
|
res.end();
|
|
if (verbose) {
|
|
console.error(url + ': not found');
|
|
}
|
|
return;
|
|
}
|
|
filePath = file;
|
|
fs.stat(filePath, statFile);
|
|
}
|
|
|
|
var fileSize;
|
|
|
|
function statFile(err, stats) {
|
|
if (err) {
|
|
res.writeHead(500);
|
|
res.end();
|
|
return;
|
|
}
|
|
|
|
fileSize = stats.size;
|
|
var isDir = stats.isDirectory();
|
|
if (isDir && !/\/$/.test(pathPart)) {
|
|
res.setHeader('Location', pathPart + '/' + urlParts[2]);
|
|
res.writeHead(301);
|
|
res.end('Redirected', 'utf8');
|
|
return;
|
|
}
|
|
if (isDir) {
|
|
serveDirectoryIndex(filePath);
|
|
return;
|
|
}
|
|
|
|
var range = req.headers['range'];
|
|
if (range && !disableRangeRequests) {
|
|
var rangesMatches = /^bytes=(\d+)\-(\d+)?/.exec(range);
|
|
if (!rangesMatches) {
|
|
res.writeHead(501);
|
|
res.end('Bad range', 'utf8');
|
|
if (verbose) {
|
|
console.error(url + ': bad range: "' + range + '"');
|
|
}
|
|
return;
|
|
}
|
|
var start = +rangesMatches[1];
|
|
var end = +rangesMatches[2];
|
|
if (verbose) {
|
|
console.log(url + ': range ' + start + ' - ' + end);
|
|
}
|
|
serveRequestedFileRange(filePath,
|
|
start,
|
|
isNaN(end) ? fileSize : (end + 1));
|
|
return;
|
|
}
|
|
if (verbose) {
|
|
console.log(url);
|
|
}
|
|
serveRequestedFile(filePath);
|
|
}
|
|
|
|
function escapeHTML(untrusted) {
|
|
// Escape untrusted input so that it can safely be used in a HTML response
|
|
// in HTML and in HTML attributes.
|
|
return untrusted
|
|
.replace(/&/g, '&')
|
|
.replace(/</g, '<')
|
|
.replace(/>/g, '>')
|
|
.replace(/"/g, '"')
|
|
.replace(/'/g, ''');
|
|
}
|
|
|
|
function serveDirectoryIndex(dir) {
|
|
res.setHeader('Content-Type', 'text/html');
|
|
res.writeHead(200);
|
|
|
|
if (queryPart === 'frame') {
|
|
res.end('<html><frameset cols=*,200><frame name=pdf>' +
|
|
'<frame src=\"' + encodeURI(pathPart) +
|
|
'?side\"></frameset></html>', 'utf8');
|
|
return;
|
|
}
|
|
var all = queryPart === 'all';
|
|
fs.readdir(dir, function (err, files) {
|
|
if (err) {
|
|
res.end();
|
|
return;
|
|
}
|
|
res.write('<html><head><meta charset=\"utf-8\"></head><body>' +
|
|
'<h1>PDFs of ' + pathPart + '</h1>\n');
|
|
if (pathPart !== '/') {
|
|
res.write('<a href=\"..\">..</a><br>\n');
|
|
}
|
|
files.forEach(function (file) {
|
|
var stat;
|
|
var item = pathPart + file;
|
|
var href = '';
|
|
var label = '';
|
|
var extraAttributes = '';
|
|
try {
|
|
stat = fs.statSync(path.join(dir, file));
|
|
} catch (e) {
|
|
href = encodeURI(item);
|
|
label = file + ' (' + e + ')';
|
|
extraAttributes = ' style="color:red"';
|
|
}
|
|
if (stat) {
|
|
if (stat.isDirectory()) {
|
|
href = encodeURI(item);
|
|
label = file;
|
|
} else if (path.extname(file).toLowerCase() === '.pdf') {
|
|
href = '/web/viewer.html?file=' + encodeURIComponent(item);
|
|
label = file;
|
|
extraAttributes = ' target="pdf"';
|
|
} else if (all) {
|
|
href = encodeURI(item);
|
|
label = file;
|
|
}
|
|
}
|
|
if (label) {
|
|
res.write('<a href=\"' + escapeHTML(href) + '\"' +
|
|
extraAttributes + '>' + escapeHTML(label) + '</a><br>\n');
|
|
}
|
|
});
|
|
if (files.length === 0) {
|
|
res.write('<p>no files found</p>\n');
|
|
}
|
|
if (!all && queryPart !== 'side') {
|
|
res.write('<hr><p>(only PDF files are shown, ' +
|
|
'<a href=\"?all\">show all</a>)</p>\n');
|
|
}
|
|
res.end('</body></html>');
|
|
});
|
|
}
|
|
|
|
function serveRequestedFile(filePath) {
|
|
var stream = fs.createReadStream(filePath, {flags: 'rs'});
|
|
|
|
stream.on('error', function (error) {
|
|
res.writeHead(500);
|
|
res.end();
|
|
});
|
|
|
|
var ext = path.extname(filePath).toLowerCase();
|
|
var contentType = mimeTypes[ext] || defaultMimeType;
|
|
|
|
if (!disableRangeRequests) {
|
|
res.setHeader('Accept-Ranges', 'bytes');
|
|
}
|
|
res.setHeader('Content-Type', contentType);
|
|
res.setHeader('Content-Length', fileSize);
|
|
if (cacheExpirationTime > 0) {
|
|
var expireTime = new Date();
|
|
expireTime.setSeconds(expireTime.getSeconds() + cacheExpirationTime);
|
|
res.setHeader('Expires', expireTime.toUTCString());
|
|
}
|
|
res.writeHead(200);
|
|
|
|
stream.pipe(res);
|
|
}
|
|
|
|
function serveRequestedFileRange(filePath, start, end) {
|
|
var stream = fs.createReadStream(filePath, {
|
|
flags: 'rs', start: start, end: end - 1});
|
|
|
|
stream.on('error', function (error) {
|
|
res.writeHead(500);
|
|
res.end();
|
|
});
|
|
|
|
var ext = path.extname(filePath).toLowerCase();
|
|
var contentType = mimeTypes[ext] || defaultMimeType;
|
|
|
|
res.setHeader('Accept-Ranges', 'bytes');
|
|
res.setHeader('Content-Type', contentType);
|
|
res.setHeader('Content-Length', (end - start));
|
|
res.setHeader('Content-Range',
|
|
'bytes ' + start + '-' + (end - 1) + '/' + fileSize);
|
|
res.writeHead(206);
|
|
|
|
stream.pipe(res);
|
|
}
|
|
|
|
}
|
|
};
|
|
|
|
exports.WebServer = WebServer;
|