Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3e52098e29
pdf.js/web
History
Jonas Jenwald a177afc206 Fix some static static analyzer warnings (issue 11965) 
This fixes only those warnings, as reported by https://lgtm.com/projects/g/mozilla/pdf.js?mode=list, that make sense (as far as I'm concerned).

Hence this patch leaves the following things unaddressed:
 - The "recommendation"-category, since it only complains about unused variables. However, note that all of those cases are purposely included and that there's thus ESLint-disable comments added to explictly allow them.
 - The "warning"-category, which still contains two complaints. However, as far as I can tell, they are both false positives.

Given first of all the false positives of the LGTM static analyzer, and secondly that we'd need to add (essentially duplicated) disable-comments for the unused variable cases, it's not entirely clear to me if we actually want to work towards including LGTM in the PDF.js project (e.g. running alongside Travis) or if we should just close issue 11965.
2020-11-01 12:08:38 +01:00
..
images [api-minor] Add support for toggling of Optional Content in the viewer (issue 12096) 2020-08-30 16:28:40 +02:00
.eslintrc Enable the ESLint prefer-const rule globally (PR 11450 follow-up) 2020-01-25 00:20:22 +01:00
.gitignore Remove obselete file from .gitignore 2015-01-26 16:44:45 +01:00
annotation_layer_builder.css Re-format all web/*.css files using Stylelint/Prettier 2020-08-30 21:49:08 +02:00
annotation_layer_builder.js Also enable renderInteractiveForms by default in the viewer components (PR 12201 follow-up) 2020-08-22 14:24:04 +02:00
app_options.js JS - Add the basic architecture to be able to execute embedded js 2020-10-21 19:00:56 +02:00
app.js Merge pull request #12525 from brendandahl/mark-info 2020-10-31 00:05:19 +01:00
base_tree_viewer.js Extract common methods from PDFOutlineViewer/PDFAttachmentViewer into a new abstract BaseTreeViewer class 2020-08-05 23:08:06 +02:00
base_viewer.js Ensure that the same version of PDF.js is used in both the API and the Viewer (PR 8959 follow-up) 2020-10-27 17:09:42 +01:00
chrome-i18n-allow-access-to-file-urls.json Add translations of "Allow access to file URLs" 2015-08-14 18:59:55 +02:00
chromecom.js Fix some static static analyzer warnings (issue 11965) 2020-11-01 12:08:38 +01:00
compressed.tracemonkey-pldi-09.pdf Add Makefile. Move some files around to make building the website easier. 2011-07-05 10:53:57 -07:00
debugger.js Fix some static static analyzer warnings (issue 11965) 2020-11-01 12:08:38 +01:00
download_manager.js Remove code-paths only relevant for IE 11/Edge (non-Chromium based) from the web/ folder 2020-09-05 17:18:15 +02:00
firefox_print_service.js [Firefox] Stop logging RenderingCancelledExceptions as errors when printing 2020-10-04 20:25:31 +02:00
firefoxcom.js Fix some static static analyzer warnings (issue 11965) 2020-11-01 12:08:38 +01:00
genericcom.js Fix some static static analyzer warnings (issue 11965) 2020-11-01 12:08:38 +01:00
genericl10n.js Enable import/extensions of ESlint plugin to enforce all import have a .js file extension. 2020-01-18 10:53:01 +09:00
grab_to_pan.js Remove some code/comments relevant for old (pre-Chromium) versions of Opera 2020-09-08 12:54:51 +02:00
interfaces.js Support adding pages, in addition to regular destinations, to the browser history and use it with thumbnails (issue 12440) 2020-10-18 16:04:00 +02:00
overlay_manager.js Fix the linting errors, from the Prettier auto-formatting, that ESLint --fix couldn't handle 2019-12-26 12:35:12 +01:00
password_prompt.js Ensure that all import and require statements, in the entire code-base, have a .js file extension 2020-01-04 13:01:43 +01:00
pdf_attachment_viewer.js Revert "Download, rather than opening, PDF attachments in Firefox (bug 1661259, PR 12286 follow-up)" 2020-09-04 12:07:34 +02:00
pdf_cursor_tools.js Re-factor the EventBus to allow servicing of "external" event listeners *after* the viewer components have updated 2020-02-27 19:38:13 +01:00
pdf_document_properties.js Remove unnecessary empty string fallback from the getPDFFileNameFromURL call in web/pdf_document_properties.js (PR 10114 follow-up) 2020-05-20 12:09:04 +02:00
pdf_find_bar.js [api-minor] Remove the getGlobalEventBus viewer functionality (PR 11631 follow-up) 2020-03-29 12:20:23 +02:00
pdf_find_controller.js Return the query with the findcontrols 2020-08-20 11:18:43 +01:00
pdf_find_utils.js Enable auto-formatting of the entire code-base using Prettier (issue 11444) 2019-12-26 12:34:24 +01:00
pdf_history.js Move updating of this._maxUid into PDFHistory._updateInternalState 2020-10-18 16:29:15 +02:00
pdf_layer_viewer.js [api-minor] Add support for toggling of Optional Content in the viewer (issue 12096) 2020-08-30 16:28:40 +02:00
pdf_link_service.js A couple of small (viewer) tweaks of tooltip-only Annotations (PR 12333 follow-up) 2020-10-23 14:31:45 +02:00
pdf_outline_viewer.js Re-name and re-factor the PDFLinkService.navigateTo method 2020-10-18 14:29:59 +02:00
pdf_page_view.js Use template strings when calculating the CSS transforms, in the PDFPageView.cssTransform method 2020-09-25 14:42:55 +02:00
pdf_presentation_mode.js Remove code-paths only relevant for IE 11/Edge (non-Chromium based) from the web/ folder 2020-09-05 17:18:15 +02:00
pdf_print_service.js Remove code-paths only relevant for IE 11/Edge (non-Chromium based) from the web/ folder 2020-09-05 17:18:15 +02:00
pdf_rendering_queue.js Ignore RenderingCancelledException when logging errors in PDFRenderingQueue.renderView 2020-09-25 14:21:05 +02:00
pdf_sidebar_resizer.js Remove CSS variables feature-testing from PDFSidebarResizer 2020-09-09 22:26:08 +02:00
pdf_sidebar.js [api-minor] Add support for toggling of Optional Content in the viewer (issue 12096) 2020-08-30 16:28:40 +02:00
pdf_single_page_viewer.js Rename BaseViewer._setDocumentViewerElement to BaseViewer._viewerElement 2020-03-24 16:54:37 +01:00
pdf_thumbnail_view.js Support adding pages, in addition to regular destinations, to the browser history and use it with thumbnails (issue 12440) 2020-10-18 16:04:00 +02:00
pdf_thumbnail_viewer.js [api-minor] Add support for toggling of Optional Content in the viewer (issue 12096) 2020-08-30 16:28:40 +02:00
pdf_viewer.component.js [api-minor] Deprecate getGlobalEventBus and update the "viewer components" examples accordingly 2020-02-27 14:44:48 +01:00
pdf_viewer.css Remove code-paths only relevant for IE 11/Edge (non-Chromium based) from the web/ folder 2020-09-05 17:18:15 +02:00
pdf_viewer.js Rename BaseViewer._setDocumentViewerElement to BaseViewer._viewerElement 2020-03-24 16:54:37 +01:00
pdfjs.js Enable auto-formatting of the entire code-base using Prettier (issue 11444) 2019-12-26 12:34:24 +01:00
preferences.js Remove the SystemJS dependency from the web/preferences.js file 2020-05-16 16:22:15 +02:00
secondary_toolbar.js Update Prettier to version 2.0 2020-04-14 12:28:14 +02:00
text_layer_builder.css Re-format all web/*.css files using Stylelint/Prettier 2020-08-30 21:49:08 +02:00
text_layer_builder.js Update Prettier to version 2.0 2020-04-14 12:28:14 +02:00
toolbar.js Update the zoom dropdown width calculation to work better in locales with long zoom-strings (PR 11077 follow-up) 2020-08-20 09:57:42 +02:00
ui_utils.js Merge pull request #12464 from baloone/Fix_getVisibleElements_in_rtl_direction 2020-10-24 17:03:57 +02:00
view_history.js Add a bit more validation in the ViewHistory constructor 2020-03-21 13:55:06 +01:00
viewer_compatibility.js Remove code-paths only relevant for IE 11/Edge (non-Chromium based) from the web/ folder 2020-09-05 17:18:15 +02:00
viewer-snippet-chrome-extension.html Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
viewer-snippet-chrome-overlays.html [CRX] Add file chooser as fallback (fixes #9411) 2018-03-21 18:21:46 +01:00
viewer-snippet-firefox-extension.html Stop bundling the ReadableStream polyfill in MOZCENTRAL builds (PR 10470 follow-up) 2019-01-23 20:33:20 +01:00
viewer-snippet-minified.html Remove XHTML leftovers from the viewer HTML files 2016-02-14 13:23:34 +01:00
viewer-snippet.html Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
viewer.css Let the loadingBar have the same width as the viewerContainer 2020-09-10 17:16:24 +02:00
viewer.html Let the loadingBar have the same width as the viewerContainer 2020-09-10 17:16:24 +02:00
viewer.js Use standard import statements when loading PDFViewerApplication/AppOptions in web/viewer 2020-10-11 14:06:47 +02:00