2bae8af96a
The current test fails intermittently only on Windows for unknown reasons: the code is correct and on Linux it always passes. However, we have already spent quite a lot of time on this test, so rather than spending even more time on it I figured we should look at what behavior the test is trying to check and find an alternative way to do it that can't trigger this intermittent issue anymore. This commit changes the test to use a term that only exists once in the entire document so we cannot accidentally highlight another match anymore. This doesn't change anything about the behavior that this test aims to check: we still test searching in the XFA layer, we still test that the original term is matched case-insensitively and we still test that that match is actually highlighted. Note that the only objective of the test is confirming that the search functionality covers the XFA layer, so the exact phrase/match is not the interesting bit.
109 lines
4.1 KiB
JavaScript
109 lines
4.1 KiB
JavaScript
/* Copyright 2021 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { closePages, loadAndWait } from "./test_utils.mjs";
|
|
|
|
function fuzzyMatch(a, b, browserName, pixelFuzz = 3) {
|
|
expect(a)
|
|
.withContext(`In ${browserName}`)
|
|
.toBeLessThan(b + pixelFuzz);
|
|
expect(a)
|
|
.withContext(`In ${browserName}`)
|
|
.toBeGreaterThan(b - pixelFuzz);
|
|
}
|
|
|
|
describe("find bar", () => {
|
|
describe("highlight all", () => {
|
|
let pages;
|
|
|
|
beforeAll(async () => {
|
|
pages = await loadAndWait("find_all.pdf#zoom=100", ".textLayer");
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must highlight text in the right position", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
await page.click("#viewFind");
|
|
await page.waitForSelector("#viewFind", { hidden: false });
|
|
await page.type("#findInput", "a");
|
|
await page.click("#findHighlightAll");
|
|
await page.waitForSelector(".textLayer .highlight");
|
|
// The PDF has the text "AB BA" in a monospace font.
|
|
// Make sure we have the right number of highlighted divs.
|
|
const highlights = await page.$$(".textLayer .highlight");
|
|
expect(highlights.length).withContext(`In ${browserName}`).toEqual(2);
|
|
const glyphWidth = 15.98; // From the PDF.
|
|
const pageDiv = await page.$(".page canvas");
|
|
const pageBox = await pageDiv.boundingBox();
|
|
const firstA = await highlights[0].boundingBox();
|
|
const secondA = await highlights[1].boundingBox();
|
|
// Subtract the page offset from the text bounding boxes;
|
|
firstA.x -= pageBox.x;
|
|
firstA.y -= pageBox.y;
|
|
secondA.x -= pageBox.x;
|
|
secondA.y -= pageBox.y;
|
|
// They should be on the same line.
|
|
expect(firstA.y).withContext(`In ${browserName}`).toEqual(secondA.y);
|
|
const fontSize = 26.66; // From the PDF.
|
|
// The highlighted text has more padding.
|
|
fuzzyMatch(firstA.height, fontSize + 5, browserName);
|
|
fuzzyMatch(secondA.height, fontSize + 5, browserName);
|
|
const expectedFirstAX = 28;
|
|
fuzzyMatch(firstA.x, expectedFirstAX, browserName);
|
|
// The second 'A' should be 4 glyphs widths from the first.
|
|
fuzzyMatch(secondA.x, expectedFirstAX + glyphWidth * 4, browserName);
|
|
})
|
|
);
|
|
});
|
|
});
|
|
describe("highlight all", () => {
|
|
let pages;
|
|
|
|
beforeAll(async () => {
|
|
pages = await loadAndWait("xfa_imm5257e.pdf#zoom=100", ".xfaLayer");
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await closePages(pages);
|
|
});
|
|
|
|
it("must search xfa correctly", async () => {
|
|
await Promise.all(
|
|
pages.map(async ([browserName, page]) => {
|
|
await page.click("#viewFind");
|
|
await page.waitForSelector("#viewFind", { hidden: false });
|
|
await page.type("#findInput", "preferences");
|
|
await page.waitForSelector("#findInput[data-status='']");
|
|
await page.waitForSelector(".xfaLayer .highlight");
|
|
const resultElement = await page.waitForSelector("#findResultsCount");
|
|
const resultText = await resultElement.evaluate(el => el.textContent);
|
|
expect(resultText).toEqual("1 of 1 match");
|
|
const selectedElement = await page.waitForSelector(
|
|
".highlight.selected"
|
|
);
|
|
const selectedText = await selectedElement.evaluate(
|
|
el => el.textContent
|
|
);
|
|
expect(selectedText).toEqual("Preferences");
|
|
})
|
|
);
|
|
});
|
|
});
|
|
});
|