5f77d3719b
Very short strings can narrowly miss the existing Bidi-detection threshold, leading to incorrect text-selection and copying behaviour. In my testing, neither Adobe Reader or PDFium seem to handle copying "correctly" for this document. Hence it's not entirely clear to me that we actually want to fix this, since tweaking these heuristics can *obviously* cause regressions elsewhere (and our test coverage for RTL-text isn't exactly great).
72 lines
2.3 KiB
JavaScript
72 lines
2.3 KiB
JavaScript
/* Copyright 2017 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import { bidi } from "../../src/core/bidi.js";
|
|
|
|
describe("bidi", function () {
|
|
it(
|
|
"should mark text as LTR if there's only LTR-characters, " +
|
|
"when the string is very short",
|
|
function () {
|
|
const str = "foo";
|
|
const bidiText = bidi(str, -1, false);
|
|
|
|
expect(bidiText.str).toEqual("foo");
|
|
expect(bidiText.dir).toEqual("ltr");
|
|
}
|
|
);
|
|
|
|
it("should mark text as LTR if there's only LTR-characters", function () {
|
|
const str = "Lorem ipsum dolor sit amet, consectetur adipisicing elit.";
|
|
const bidiText = bidi(str, -1, false);
|
|
|
|
expect(bidiText.str).toEqual(
|
|
"Lorem ipsum dolor sit amet, consectetur adipisicing elit."
|
|
);
|
|
expect(bidiText.dir).toEqual("ltr");
|
|
});
|
|
|
|
it("should mark text as RTL if more than 30% of text is RTL", function () {
|
|
// 33% of test text are RTL characters
|
|
const test = "\u0645\u0635\u0631 Egypt";
|
|
const result = "Egypt \u0631\u0635\u0645";
|
|
const bidiText = bidi(test, -1, false);
|
|
|
|
expect(bidiText.str).toEqual(result);
|
|
expect(bidiText.dir).toEqual("rtl");
|
|
});
|
|
|
|
it("should mark text as LTR if less than 30% of text is RTL", function () {
|
|
const test = "Egypt is known as \u0645\u0635\u0631 in Arabic.";
|
|
const result = "Egypt is known as \u0631\u0635\u0645 in Arabic.";
|
|
const bidiText = bidi(test, -1, false);
|
|
|
|
expect(bidiText.str).toEqual(result);
|
|
expect(bidiText.dir).toEqual("ltr");
|
|
});
|
|
|
|
it(
|
|
"should mark text as RTL if less than 30% of text is RTL, " +
|
|
"when the string is very short (issue 11656)",
|
|
function () {
|
|
const str = "()\u05d1("; // 25% of the string is RTL characters.
|
|
const bidiText = bidi(str, -1, false);
|
|
|
|
expect(bidiText.str).toEqual("(\u05d1)(");
|
|
expect(bidiText.dir).toEqual("rtl");
|
|
}
|
|
);
|
|
});
|