Commit Graph

8440 Commits

Author SHA1 Message Date
Yury Delendik
7f34d40faf Imports L10n. 2015-12-15 10:07:25 -06:00
Tim van der Meij
edce8daeac Implement annotation layer rendering and updating in src/display/annotation_layer.js 2015-12-15 17:00:01 +01:00
Tim van der Meij
b1937e7670 Remove superfluous comments in the annotation layer code 2015-12-15 16:27:35 +01:00
Tim van der Meij
a6ba210c19 Merge pull request #6757 from timvandermeij/annotation-types
Implement constants for all annotation types
2015-12-15 15:52:55 +01:00
Tim van der Meij
8d36aad30a Implement constants for all annotation types
Now we have a full list of all possible annotation types and the
numbering corresponds to the order in the specification. Not only is
this more consistent and complete, it also prevents having to add these
constants when a new annotation type is implemented.

Additionally fix an issue where a regular Widget annotation would not
have `data.annotationType` set. It was only set for a
TextWidgetAnnotation, but instead move it to the base Widget annotation
class to add it for all Widget annotations (since TextWidgetAnnotation
inherits from WidgetAnnotation it will have it too).
2015-12-15 15:23:55 +01:00
Tim van der Meij
f93a220736 Merge pull request #6684 from dsprenkels/issue-6296-radial-shading-size
shading-pattern: While drawing patterns, use transform to baseTransform first
2015-12-14 20:39:08 +01:00
Yury Delendik
f7ec866c39 Merge pull request #6747 from Snuffleupagus/issue-6742
Remove the superfluous `PDFJS.disableFontFace = false;` statement at the top of font_loader.js (issue 6742)
2015-12-12 12:53:56 -05:00
Yury Delendik
4485c79940 Merge pull request #6745 from Snuffleupagus/bug-1232071
Reset the `styleElement` when clearing out loaded fonts (bug 1232017)
2015-12-12 12:50:21 -05:00
Jonas Jenwald
12068490ed Remove the superfluous PDFJS.disableFontFace = false; statement at the top of font_loader.js (issue 6742)
Fixes 6742.
2015-12-12 12:39:56 +01:00
Jonas Jenwald
f0e4795302 Reset the styleElement when clearing out loaded fonts (bug 1232017)
*This is a follow-up to PR 6571.*

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1232071.
2015-12-12 11:33:43 +01:00
Tim van der Meij
4d6f3c85e0 Merge pull request #6743 from Snuffleupagus/travis-newer-node-version
Update the Node.js version used by Travis, to prevent deprecation warnings in the output
2015-12-10 21:45:37 +01:00
Tim van der Meij
c6e9be8b24 Merge pull request #6733 from Snuffleupagus/travis-lint-with-make
Let Travis lint using `node make lint`, instead of a hard-coded command
2015-12-10 21:40:10 +01:00
Brendan Dahl
91b27aae46 Merge pull request #6651 from yurydelendik/fix-chars-scaling
Fix chars scaling for standard fonts. (redo of #4908)
2015-12-10 14:18:48 -05:00
Jonas Jenwald
81e86c4e3d Update the Node.js version used by Travis, to prevent deprecation warnings in the output 2015-12-10 13:15:32 +01:00
Jonas Jenwald
d6c2ced9e6 Let Travis lint using node make lint, instead of a hard-coded command 2015-12-10 10:06:32 +01:00
Tim van der Meij
7b144c02d3 Merge pull request #6739 from Snuffleupagus/PDFLinkService_getDestinationHash-prevent-resource-url-in-firefox
[Firefox] Prevent internal links from displaying "resource://pdf.js/web/" on hover, by tweaking the fallback case in `PDFLinkService_getDestinationHash`
2015-12-09 22:25:21 +01:00
Jonas Jenwald
d2c58a4ccc [Firefox] Prevent internal links from displaying "resource://pdf.js/web/" on hover, by tweaking the fallback case in PDFLinkService_getDestinationHash
An example where this is happening is http://www.nyc.gov/html/dcp/pdf/zone/map8c.pdf, check the link just below "Effective Date(s) of Rezoning:" on the right middle of the page.
2015-12-09 10:07:39 +01:00
Tim van der Meij
bce3214105 Move link creation logic to src/display/annotation_layer.js
Additionally simplify the div creation logic (it needs to happen only
once, so it should not be in the for-loop) and remove/rename variables
for shorter code.
2015-12-08 23:56:17 +01:00
Tim van der Meij
a96602223f Merge pull request #6736 from Snuffleupagus/adjustWidths
Use `adjustWidths` for TrueType fonts if we handle them as OpenType (issue 5027, issue 5084, issue 6556, bug 1204903)
2015-12-08 14:01:35 +01:00
Jonas Jenwald
ee0d522187 Use adjustWidths for TrueType fonts if we handle them as OpenType (issue 5027, issue 5084, issue 6556, bug 1204903)
In `Font_checkAndRepair` we can decide that a font isn't TrueType, and instead parse it as CFF. In that case it's quite possible that the `fontMatrix` will be changed, and without calling `adjustWidths` we're failing to update the glyph widths correctly.

Fixes 5027.
Fixes 5084.
Fixes 6556.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1204903.
2015-12-08 00:49:22 +01:00
Jonas Jenwald
084bb8682f Merge pull request #6723 from yurydelendik/smask-transfer
Adds transfer function support for SMask.
2015-12-05 22:41:56 +01:00
Yury Delendik
5beb9a2e25 Merge pull request #6727 from yurydelendik/issue6726
Replaces test for #6720 to fix botio-linux slow script.
2015-12-05 13:43:51 -06:00
Yury Delendik
1bbe8f3fee Replaces test for #6720 to fix botio-linux slow script. 2015-12-05 12:33:25 -06:00
Yury Delendik
171f59c935 Merge pull request #6725 from Snuffleupagus/IdentityToUnicodeMap_charCodeOf
Fix the `charCodeOf` method in `IdentityToUnicodeMap` in order to prevent text selection from breaking
2015-12-05 06:47:05 -06:00
Jonas Jenwald
4810b7b8fc Fix the charCodeOf method in IdentityToUnicodeMap in order to prevent text selection from breaking
After PR 6590, `font.spaceWidth` is now called in more cases than before (in `PartialEvaluator_getTextContent`), which exposed an underlying issue with `IdentityToUnicodeMap_charCodeOf` throwing an error.
This breaks text-selection in some PDF files found in the wild, hence this patch replaces the `error` with an actual function instead (modelled after `IdentityCMap_charCodeOf`).
2015-12-05 13:15:55 +01:00
Yury Delendik
15c9969abe Adds transfer function support for SMask. 2015-12-04 12:52:45 -06:00
Jonas Jenwald
e2aca385c6 Merge pull request #6720 from yurydelendik/smask-state
Fixes canvas state after smask group ends.
2015-12-03 22:19:37 +01:00
Yury Delendik
d4843ebf6d Fixes canvas state after smask group ends. 2015-12-03 14:34:12 -06:00
Tim van der Meij
e180d01255 Merge pull request #6715 from brendandahl/remove-bad-glyph-ids
Remove glyph id's outside the range of valid glyphs.
2015-12-03 20:59:03 +01:00
Brendan Dahl
87762afec4 Remove glyph id's outside the range of valid glyphs.
OTS does not like invalid glyph ids in a camp table.
2015-12-03 11:53:06 -08:00
Tim van der Meij
2dc3ee38c0 Move most rendering logic to src/display/annotation_layer.js 2015-12-03 00:20:18 +01:00
Tim van der Meij
38567ac3a3 Rename initContainer(item) to getContainer(data)
Naming it this way makes more sense when compared to the core
annoatation code. That code also uses `data` for the annotation
properties.
2015-12-02 23:35:21 +01:00
Tim van der Meij
91274d6d2d Rename annotation_helper.js to annotation_layer.js 2015-12-02 23:30:28 +01:00
Yury Delendik
e93512f1eb Merge pull request #6712 from timvandermeij/text-layer-position
Use default line height for the text layer
2015-12-02 16:05:50 -06:00
Tim van der Meij
a2cac8fa71 Use default line height for the text layer
Fixes #6614.
2015-12-02 23:00:12 +01:00
Daan Sprenkels
a9081653fc shading-pattern: While drawing patterns, transform to the baseTransform first 2015-12-02 21:49:38 +01:00
Brendan Dahl
376788f2b2 Merge pull request #6698 from yurydelendik/rm-UnsupportedManager
[api-minor] Replaces UnsupportedManager with callback.
2015-12-02 10:57:44 -08:00
Jonas Jenwald
5f56a20b34 Merge pull request #6701 from timvandermeij/pdf-manager-inherit
Make use of `Util.inherit` in `src/core/pdf_manager.js`
2015-12-01 19:53:43 +01:00
Yury Delendik
4a82f2f5fd Merge pull request #6695 from Snuffleupagus/issue-6692
Ensure that `Lexer_getName` does not fail if a `Name` contains in invalid usage of the NUMBER SIGN (#) (issue 6692)
2015-12-01 10:25:57 -06:00
Jonas Jenwald
361fa83f3b Merge pull request #6699 from timvandermeij/annotation-refactoring
Improve code structure of the annotation code
2015-12-01 13:31:18 +01:00
Yury Delendik
c9cb6a3025 Replaces UnsupportedManager with callback. 2015-11-30 14:42:47 -06:00
Yury Delendik
84a47f8e53 Merge pull request #6700 from Snuffleupagus/mozcentral-remove-FontLoader-bindDOM
Replace `font.bindDOM()` with `font.createFontFaceRule()` in the `FontLoader` for MOZCENTRAL specific code (PR 6571 follow-up)
2015-11-28 21:33:38 -06:00
Tim van der Meij
0c41866433 Make use of Util.inherit in src/core/pdf_manager.js
While we are here, fix some incorrect function names.
2015-11-29 00:58:19 +01:00
Tim van der Meij
8b79becad6 Improve code structure of the annotation code
This patch improves the code structure of the annotation code.

- Create the annotation border style object in the `setBorderStyle` method instead of in the constructor. The behavior is the same as the `setBorderStyle` method is always called, thus a border style object is still always available.
- Put all data object manipulation lines in one block in the constructor. This improves readability and maintainability as it is more visible which properties are exposed.
- Simplify `appendToOperatorList` by removing the promise capability and removing an unused parameter.
- Remove some unnecessary newlines/spaces.
2015-11-29 00:04:21 +01:00
Jonas Jenwald
e8e79029b1 Replace font.bindDOM() with font.createFontFaceRule() in the FontLoader for MOZCENTRAL specific code (PR 6571 follow-up)
This is a follow-up to PR 6571, and fixes font loading in the `MOZCENTRAL` version.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1228603#c2.
2015-11-28 21:33:07 +01:00
Jonas Jenwald
995e1a45b8 Ensure that Lexer_getName does not fail if a Name contains in invalid usage of the NUMBER SIGN (#) (issue 6692)
*This is a regression from PR 3424.*

The PDF file in the referenced issue is using `Type3` fonts. In one of those, the `/CharProcs` dictionary contains an entry with the name `/#`. Before the changes to `Lexer_getName` in PR 3424, we were allowing certain invalid `Name` patterns containing the NUMBER SIGN (#).

It's unfortunate that this has been broken for close to two and a half years before the bug surfaced, but it should at least indicate that this is not a widespread issue.

Fixes 6692.
2015-11-28 11:59:09 +01:00
Tim van der Meij
a8279f7d60 Merge pull request #6697 from yurydelendik/type3loaderror
Set error font for Type3 if its loading failed.
2015-11-27 23:39:24 +01:00
Yury Delendik
e4e69e2f05 Set error font for Type3 if its loading failed. 2015-11-27 13:05:51 -06:00
Brendan Dahl
83dbdc1e09 Merge pull request #6693 from yurydelendik/workerwait
Worker shall wait for MessageHandler to be created at api side.
2015-11-25 16:51:01 -08:00
Yury Delendik
8dff301ce1 Worker shall wait for MessageHandler to be created at api side. 2015-11-25 18:21:23 -06:00