Jonas Jenwald
4046d67fde
Enable the no-else-return ESLint rule
...
Using `else` after `return` is not necessary, and can often lead to unnecessarily cluttered code. By using the `no-else-return` rule in ESLint we can avoid this pattern, see http://eslint.org/docs/rules/no-else-return .
2017-01-09 20:27:39 +01:00
Jonas Jenwald
9dc6463933
Ignore reserved commands when parsing operands in CFFParser_parseDict, instead of just rejecting the entire font (bug 1308536)
...
According to the CFF specification, see http://partners.adobe.com/public/developer/en/font/5176.CFF.pdf#page=11 , certain commands are currently reserved.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1308536 .
2016-11-03 12:50:40 +01:00
klemens
6f03f62327
trivial spelling fixes
2016-07-17 14:33:41 +02:00
Jonas Jenwald
6260fc09a3
Attempt to recover valid format 3 FDSelect data from broken CFF fonts (bug 1146106)
...
According to the CFF specification, see http://partners.adobe.com/public/developer/en/font/5176.CFF.pdf#G3.46884 , for `format 3` FDSelect data: "The first range must have a ‘first’ GID of 0".
Since the PDF file (attached in the bug) violates that part of the specification, this patch tries to recover valid FDSelect data to prevent OTS from rejecting the font.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1146106 .
2016-06-06 18:20:52 +02:00
Jonas Jenwald
c9b6de3b16
Prevent adding invalid values in CFFDict_setByKey (bug 1068432)
...
In the font in question, there are a couple of `topDict` entries that have invalid values (`0xF 0xF`, i.e. just eof markers without any actual numbers).
This causes the `parseFloatOperand` function, inside `CFFParser_parseDict`, to return `NaN`. Currently we pass this broken font onto the browser, which OTS unsurprisingly rejects.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1068432 .
2016-05-07 21:09:58 +02:00
Tim van der Meij
9c95d089de
Merge pull request #7281 from yurydelendik/static-warnings
...
Fixes some static analysis warnings and recommendations
2016-05-03 01:26:17 +02:00
Yury Delendik
32ce369d88
Fixes some static analysis warnings and recommendations
...
* Useless conditional
* Superfluous trailing arguments
* Useless assignment to local variable
* Misspelled identifier
* JSDoc tag for non-existent parameter
2016-05-02 17:34:58 -05:00
Yury Delendik
4cde9984f9
Fixes unneed conversion to array in CFF encodeInteger.
2016-05-02 15:24:16 -05:00
Jonas Jenwald
b961e1d21b
Extract CFFParser from fonts.js (issue 6777)
2016-04-01 22:32:39 +02:00
