Jonas Jenwald
ea1c348c67
Always prefer abbreviated keys, over full ones, when doing any dictionary lookups (issue 14256)
...
Note that issue 14256 was specifically about *inline* images, please refer to:
- https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G7.1852045
- https://www.pdfa.org/safedocs-unearths-pdf-inline-image-issue/
- https://pdf-issues.pdfa.org/32000-2-2020/clause08.html#H8.9.7
However, during review of the initial PR in https://github.com/mozilla/pdf.js/pull/14257#issuecomment-964469710 , it was suggested that we instead do this *unconditionally for all* dictionary lookups.
In addition to re-ordering the existing call-sites in the `src/core`-code, and adding non-PRODUCTION/TESTING asserts to catch future errors, for consistency a number of existing `if`/`switch`-blocks were re-factored to also check the abbreviated keys first.
2021-11-10 11:56:18 +01:00
Jonas Jenwald
99fae47c8e
[Regression] Move the super-call in the PredictorStream-constructor to prevent errors (PR 13303)
...
*My apologies for breaking this; thankfully PR 13303 hasn't reach mozilla-central yet.*
It's (obviously) necessary to initialize a `PredictorStream`-instance fully, since otherwise breakage may occur if there's errors during the actual stream parsing.
To reproduce this issue, try opening the PDF document from issue 13051 locally and observe the following message in the console:
```
Warning: Invalid stream: "ReferenceError: this hasn't been initialised - super() hasn't been called"
```
2021-05-05 13:24:12 +02:00
Jonas Jenwald
30a22a168d
Move the DecodeStream and StreamsSequenceStream from src/core/stream.js and into its own file
2021-04-28 10:16:51 +02:00
Jonas Jenwald
40c342ec6c
Convert src/core/predictor_stream.js to use standard classes
2021-04-28 10:16:51 +02:00
Jonas Jenwald
b08f9a8182
Enable the no-var rule in the src/core/predictor_stream.js file
2021-04-28 10:16:51 +02:00
Jonas Jenwald
66d9d83dcb
Move the PredictorStream from src/core/stream.js and into its own file
2021-04-28 10:16:51 +02:00
