Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9,970 Commits 1 Branch 80 Tags 254 MiB
09f04eccda
Commit Graph

9970 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonas Jenwald
223c429357 Fix inconsistent spacing and trailing commas in objects in web/ files, so we can enable the comma-dangle and object-curly-spacing ESLint rules later on 
http://eslint.org/docs/rules/comma-dangle
http://eslint.org/docs/rules/object-curly-spacing

Given that we currently have quite inconsistent object formatting, fixing this in in *one* big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead.

*Please note:* This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch.

```diff
diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js
index 002dbf29..1de4e530 100644
--- a/web/pdf_thumbnail_view.js
+++ b/web/pdf_thumbnail_view.js
@@ -420,8 +420,8 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() {
     setPageLabel: function PDFThumbnailView_setPageLabel(label) {
       this.pageLabel = (typeof label === 'string' ? label : null);

-      this.l10n.get('thumb_page_title', { page: this.pageId, }, 'Page {{page}}').
-          then((msg) => {
+      this.l10n.get('thumb_page_title', { page: this.pageId, },
+                    'Page {{page}}').then((msg) => {
         this.anchor.title = msg;
       });

diff --git a/web/secondary_toolbar.js b/web/secondary_toolbar.js
index 160e0410..6495fc5e 100644
--- a/web/secondary_toolbar.js
+++ b/web/secondary_toolbar.js
@@ -65,7 +65,8 @@ class SecondaryToolbar {
       { element: options.printButton, eventName: 'print', close: true, },
       { element: options.downloadButton, eventName: 'download', close: true, },
       { element: options.viewBookmarkButton, eventName: null, close: true, },
-      { element: options.firstPageButton, eventName: 'firstpage', close: true, },
+      { element: options.firstPageButton, eventName: 'firstpage',
+        close: true, },
       { element: options.lastPageButton, eventName: 'lastpage', close: true, },
       { element: options.pageRotateCwButton, eventName: 'rotatecw',
         close: false, },
@@ -76,7 +77,7 @@ class SecondaryToolbar {
       { element: options.cursorHandToolButton, eventName: 'switchcursortool',
         eventDetails: { tool: CursorTool.HAND, }, close: true, },
       { element: options.documentPropertiesButton,
-        eventName: 'documentproperties', close: true, }
+        eventName: 'documentproperties', close: true, },
     ];
     this.items = {
       firstPage: options.firstPageButton,
```
 2017-06-01 12:47:47 +02:00
Tim van der Meij
bb7e85c5ea Merge pull request #8466 from Snuffleupagus/app-DefaultExternalServices-createL10n 
Add a stub `createL10n` to `DefaultExternalServices` in app.js
 2017-05-31 23:13:06 +02:00
Jonas Jenwald
1d4e96b0b5 Add a stub createL10n to DefaultExternalServices in app.js 
It appears that this was simply forgotten in PR 8394.
 2017-05-31 18:45:01 +02:00
Jonas Jenwald
45933545f1 Merge pull request #8394 from yurydelendik/l10n 
Wraps mozL10n to async calls; splits firefox and generic l10n libs.
 2017-05-31 17:31:22 +02:00
Yury Delendik
5438ce9b98 Wraps mozL10n to async calls; splits firefox and generic l10n libs. 2017-05-31 09:22:25 -05:00
Yury Delendik
bd288df909 Merge pull request #8396 from mukulmishra18/streams-lib 
Adds streams-lib polyfill and exports ReadableStream from shared/util.
 2017-05-31 08:42:48 -05:00
Jonas Jenwald
09d46e94c6 Merge pull request #8463 from Snuffleupagus/PDFJS_NEXT-env 
Allow specifying the `PDFJS_NEXT` build flag via an environment variable when running the various `gulp` commands
 2017-05-31 14:59:10 +02:00
Jonas Jenwald
7d3a3252b5 Allow specifying the PDFJS_NEXT build flag via an environment variable when running the various gulp commands 
After PR 8459, the run-time of the various `gulp` test commands has regressed quite badly on Windows. For me, `gulp test` now takes approximately *twice* as long when run locally on Windows.
The problem seems to be the Babel transpilation step, which takes well over five minutes to run.[1]

For someone like me, who runs tests a lot locally, this slowdown is really hurting the overall development experience.
To get around this I tested setting `PDFJS_NEXT = true` in `gulpfile.js`, since the transpilation step isn't necessary when testing in a modern browser.

However, having to edit `gulpfile.js` every time that I need to run tests isn't very practical. Hence this patch, which adds an environment variable that allows you to disable the transpilation simply by using e.g. `PDFJS_NEXT=true gulp test`.

I hope that this can be considered an acceptable solution, such that I don't need to maintain this patch locally (or worse, edit `gulpfile.js` locally before testing).

---
[1] This can also be observed on the Windows bot, but it seems fine on Linux.
 2017-05-31 14:50:49 +02:00
Yury Delendik
1e6f49b129 Merge pull request #8462 from yurydelendik/rm=umd 
Removes last UMDs from the modules.
 2017-05-31 07:27:19 -05:00
Yury Delendik
66c8893815 Removes last UMDs from the modules. 2017-05-31 07:14:17 -05:00
Tim van der Meij
96377832e4 Merge pull request #8458 from Snuffleupagus/thumbnails-TempImageFactory 
Refactor the `getTempCanvas` function in `pdf_thumbnail_view.js` to a factory, in preparation for ES6 conversion of the thumbnail related code
 2017-05-31 01:06:28 +02:00
Tim van der Meij
6b098898d2 Merge pull request #8455 from timvandermeij/es6-page-view 
Convert the page view to ES6 syntax
 2017-05-31 00:55:36 +02:00
Tim van der Meij
6dfdff2f03
Convert the page view to ES6 syntax 2017-05-31 00:41:39 +02:00
Jonas Jenwald
92529e2b11 Refactor the getTempCanvas function in pdf_thumbnail_view.js to a factory, in preparation for ES6 conversion of the thumbnail related code 
This patch intends to simplify future ES6 refactoring of the thumbnail code, since the current code isn't going to work well together with proper `Class`es.
 2017-05-31 00:18:06 +02:00
Jonas Jenwald
e51718711b Merge pull request #8284 from Snuffleupagus/es6-modules-src 
Convert the files in the `/src/core` folder to ES6 modules
 2017-05-30 23:08:22 +02:00
Jonas Jenwald
982b6aa65b Convert the files in the /src/core folder to ES6 modules 
Please note that the `glyphlist.js` and `unicode.js` files are converted to CommonJS modules instead, since Babel cannot handle files that large and they are thus excluded from transpilation.
 2017-05-30 22:06:21 +02:00
Yury Delendik
b66b705ed7 Using pre-built code for testing. 2017-05-30 22:06:21 +02:00
Jonas Jenwald
263479fd6a Update l10n files 2017-05-29 09:59:26 +02:00
Tim van der Meij
63a0328f5f Merge pull request #8450 from timvandermeij/es6-overlay-manager 
Convert the overlay manager to ES6 syntax
 2017-05-28 21:25:59 +02:00
Tim van der Meij
e7a04fc82d
Convert the overlay manager to ES6 syntax 2017-05-28 21:18:18 +02:00
Tim van der Meij
ed661e7063 Merge pull request #8452 from FranckFreiburger/patch-1 
Update webpack.js to support browsers that do not have the Web Workers API
 2017-05-26 23:10:51 +02:00
Tim van der Meij
e801ab11c5 Merge pull request #8416 from Snuffleupagus/refactor-PDFLinkService-navigateTo 
Refactor and ES6-ify `PDFLinkService.navigateTo`
 2017-05-26 22:52:52 +02:00
Franck Freiburger
a0b7f84461 Update webpack.js to support browsers that do not have the Web Workers API 2017-05-26 22:02:07 +02:00
Jonas Jenwald
8d55e6a01d Merge pull request #8442 from Snuffleupagus/issue-8372 
Add different code-paths to `{CMap, ToUnicodeMap}.charCodeOf` depending on length, since `Array.prototype.indexOf` can be extremely inefficient for very large arrays (issue 8372)
 2017-05-24 21:05:04 +02:00
Jonas Jenwald
4ce5e520fb Add different code-paths to {CMap, ToUnicodeMap}.charCodeOf depending on length, since Array.prototype.indexOf can be extremely inefficient for very large arrays (issue 8372) 
Fixes 8372.
 2017-05-24 19:47:04 +02:00
Jonas Jenwald
ac942ac657 Merge pull request #8437 from yurydelendik/default-ctx 
Resets canvas 2d context to the default state.
 2017-05-23 23:31:57 +02:00
Yury Delendik
a67198895f Resets canvas 2d context to the default state. 2017-05-23 15:10:30 -05:00
Yury Delendik
ad797fa74d Merge pull request #8436 from Snuffleupagus/issue-8424 
Don't map glyphs to the HANGUL FILLER (0x3164) Unicode location (issue 8424)
 2017-05-23 11:11:42 -05:00
Jonas Jenwald
31c24ed631 Don't map glyphs to the HANGUL FILLER (0x3164) Unicode location (issue 8424) 
*This patch follows a similar pattern as previous ones, by skipping certain problematic Unicode locations.*

According to http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/gfx/harfbuzz/src/hb-unicode-private.hh#136, it seems that the HANGUL FILLER (0x3164) location is "special".

Fixes 8424.
 2017-05-23 16:12:45 +02:00
Tim van der Meij
f2161345e3 Merge pull request #8433 from Snuffleupagus/README-rm-compatibility 
Remove the reference to `compatibility.js` from the README, since it's included by default in `GENERIC` builds
 2017-05-22 23:02:31 +02:00
Brendan Dahl
5df0cccaa3 Merge pull request #8432 from Snuffleupagus/rm-nameddest-fallback 
Remove the special handling for `nameddest`s that look like standard pageNumbers
 2017-05-22 11:38:10 -07:00
Jonas Jenwald
cb0391f457 Remove the reference to compatibility.js from the README, since it's included by default in GENERIC builds 
Please note that the FAQ (in the Wiki) was already updated to mention that the standalone `compatibility.js` file isn't necessary anymore.
 2017-05-22 12:56:27 +02:00
Jonas Jenwald
b4c35857ff Merge pull request #7635 from Snuffleupagus/CursorTools 
Unify handling of various cursor tools, e.g. the current Hand Tool and a possible future Zoom Tool, in a new `PDFCursorTools` module
 2017-05-22 10:36:52 +02:00
Tim van der Meij
836695986c Add icons for the new "Select tool" button 
Also adds the Dutch localizations for the new select/hand tool buttons.
 2017-05-22 00:51:03 +02:00
Jonas Jenwald
36c2791296 Unify handling of various cursor tools, e.g. the current Hand Tool and a possible future Zoom Tool, in a new PDFCursorTools module 
With the current way that the `HandTool` is implemented, if someone would try to also add a Zoom tool (as issue 1260 asks for) that probably wouldn't work very well given that you'd then have two cursor tools which may not play nice together.
Hence this patch, which attempts to refactor things so that it should be simpler to add e.g. a Zoom tool as well (given that that issue is marked as "good-beginner-bug", and I'm not sure if that really applies considering the current state of the code).

Note that I personally have no interest in implementing a Zoom tool (similar to Adobe Reader) since I wouldn't use it, but I figured that it can't hurt to make this code a bit more future proof.
 2017-05-22 00:51:01 +02:00
Jonas Jenwald
0ddf52aca5 Remove the special handling for nameddests that look like standard pageNumbers 
PR 7341 added special handling for `nameddest`s that look like pageNumbers, to prevent issues since we previously *incorrectly* supported specifying a pageNumber directly in the hash; i.e. `#10` versus the correct `#page=10` format.

Since this behaviour wasn't correct, PR 7757 fixed and deprecated the old format, which means that we no longer need to maintain the `nameddest` hack in multiple files.
 2017-05-20 11:29:29 +02:00
Tim van der Meij
8d2ae20fdd Merge pull request #8431 from Snuffleupagus/rm-make-references 
Replace a couple of leftover `make.js` references with `gulpfile.js` in docs/comments
 2017-05-19 23:50:33 +02:00
Jonas Jenwald
957dc40ddf Replace a couple of leftover make.js references with gulpfile.js in docs/comments 
Also updates a `console.log` statement in the `gulp importl10n` command (since I forgot it in a previous patch, and it didn't seem necessary with a separate patch for it).
 2017-05-19 23:45:54 +02:00
Yury Delendik
7b365b9372 Merge pull request #8366 from yurydelendik/rm-shelljs 
Removes shelljs
 2017-05-19 15:08:04 -05:00
Mukul Mishra
c9f44f30e5 Adds streams-lib polyfill and exports ReadableStream from shared/util. 
Added test for ReadableStream.

Adds ref-implementation license-header in streams-lib
and change gulp task to copy external/streams/ in build/
external/streams/ and build/dist/external/streams folder.

Adds README.md and LICENSE.md
 2017-05-20 00:26:34 +05:30
Yury Delendik
c0a1ff0b32 Removes CRLF checker 2017-05-19 07:53:34 -05:00
Yury Delendik
65a1e836cf Removes shelljs 2017-05-19 07:53:05 -05:00
Yury Delendik
32bb0e8c0e Merge pull request #8421 from Snuffleupagus/importl10n-nightly 
Change the `importl10n` script to use the Nightly channel
 2017-05-18 15:48:35 -05:00
Jonas Jenwald
95660a2ab3 Update l10n files 2017-05-18 12:41:01 +02:00
Jonas Jenwald
044a115d6e Change the importl10n script to use the Nightly channel 
It seems that PR 8323 unfortunately didn't pick the right channel for pulling translations from, according to the information in:
 - https://groups.google.com/forum/#!topic/mozilla.dev.l10n/vzmbHLPo3rg
 - https://github.com/mozilla-l10n/localizer-documentation/blob/master/misc/aurora_faqs.md

My apologies for the unnecessary churn in this code!
 2017-05-18 12:35:05 +02:00
Jonas Jenwald
658fb03db1 Merge pull request #8420 from mozilla/revert-8390-bug-1319111 
Revert "Upstream changes from: Bug 1319111 - Expose result principal URL ("final channel URL") on LoadInfo, convert current consumers of LOAD_REPLACE"
 2017-05-18 12:22:02 +02:00
Jonas Jenwald
cbba74f474 Revert "Upstream changes from: Bug 1319111 - Expose result principal URL ("final channel URL") on LoadInfo, convert current consumers of LOAD_REPLACE" 2017-05-18 12:08:05 +02:00
Yury Delendik
5dc8dcdc0f Merge pull request #8388 from Snuffleupagus/issue-8380 
Cache JPEG images, just as we do for other image formats, in `evaluator.js` (issue 8380)
 2017-05-17 17:25:51 -05:00
Jonas Jenwald
5958dafd8c Merge pull request #8413 from MRMBRAND/set-canvas-background-color 
Adds additional parameter so background color of canvas can be set
 2017-05-18 00:18:25 +02:00
chris.greening
cfc2f36f5c Adds additional parameter so background color of canvas can be set 2017-05-17 17:06:44 +01:00