Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid setting incorrect document URLs, in IE 11, when the browser history is updated (PR 10423 follow-up)

Browse Source 
Apparently in IE 11 when `history.{pushState, replaceState}` is called, there's actually a difference between not providing the *third* argument vs providing it set implicitly to `undefined`. It appears that in IE 11 it's actually being stringified, rather than ignored, which seems completely wrong (obviously other browsers aren't affected, so no surprises there).

This is yet another reason why I think the feature itself was a really bad idea, since it now requires extra/duplicated code just to prevent weird/incorrect URL behaviour in crappy browsers.
This commit is contained in:
Jonas Jenwald 2019-01-16 19:26:44 +01:00
parent 5cb00b7967
commit ffe798137f
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/pdf_history.js
View File

@ -306,10 +306,18 @@ class PDFHistory {
} }
} }
if (shouldReplace) { if (shouldReplace) {
window.history.replaceState(newState, '', newUrl); if (newUrl) {
window.history.replaceState(newState, '', newUrl);
} else {
window.history.replaceState(newState, '');
}
} else { } else {
this._maxUid = this._uid; this._maxUid = this._uid;
window.history.pushState(newState, '', newUrl); if (newUrl) {
window.history.pushState(newState, '', newUrl);
} else {
window.history.pushState(newState, '');
}
} }
if (typeof PDFJSDev !== 'undefined' && PDFJSDev.test('CHROME') && if (typeof PDFJSDev !== 'undefined' && PDFJSDev.test('CHROME') &&