Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-factor the glyph-cache lookup in the Font._charToGlyph method

Browse Source 
With the changes in the previous patch we can move the glyph-cache lookup to the top of the method and thus avoid a bunch of, in *almost* every case, completely unnecessary re-parsing for every `charCode`.
This commit is contained in:
Jonas Jenwald 2022-10-18 17:20:25 +02:00
parent 3e391aaed9
commit fd35cda8bc
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/core/fonts.js
View File

@ -3225,6 +3225,12 @@ class Font {
* @private * @private
*/ */
_charToGlyph(charcode, isSpace = false) { _charToGlyph(charcode, isSpace = false) {
let glyph = this._glyphCache[charcode];
// All `Glyph`-properties, except `isSpace` in multi-byte strings,
// depend indirectly on the `charcode`.
if (glyph && glyph.isSpace === isSpace) {
return glyph;
}
let fontCharCode, width, operatorListId; let fontCharCode, width, operatorListId;
let widthCode = charcode; let widthCode = charcode;
@ -3289,10 +3295,6 @@ class Font {
} }
} }
let glyph = this._glyphCache[charcode];
// All `Glyph`-properties, except `isSpace` in multi-byte strings,
// depend indirectly on the `charcode`.
if (!glyph || glyph.isSpace !== isSpace) {
glyph = new Glyph( glyph = new Glyph(
charcode, charcode,
fontChar, fontChar,
@ -3304,9 +3306,7 @@ class Font {
isSpace, isSpace,
isInFont isInFont
); );
this._glyphCache[charcode] = glyph; return (this._glyphCache[charcode] = glyph);
}
return glyph;
} }
charsToGlyphs(chars) { charsToGlyphs(chars) {