Merge pull request #17781 from calixteman/stamp_altext_button_cp

[Editor] Make sure the alt-text button is there when pasting an image from an other tab
This commit is contained in:
calixteman 2024-03-07 21:44:53 +01:00 committed by GitHub
commit fb9e438442
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 37 additions and 1 deletions

View File

@ -265,6 +265,8 @@ class StampEditor extends AnnotationEditor {
super.render();
this.div.hidden = true;
this.addAltTextButton();
if (this.#bitmap) {
this.#createCanvas();
} else {
@ -329,7 +331,6 @@ class StampEditor extends AnnotationEditor {
this._reportTelemetry({
action: "inserted_image",
});
this.addAltTextButton();
if (this.#bitmapFileName) {
canvas.setAttribute("aria-label", this.#bitmapFileName);
}

View File

@ -21,6 +21,7 @@ import {
getFirstSerialized,
kbBigMoveDown,
kbBigMoveRight,
kbCopy,
kbPaste,
kbSelectAll,
loadAndWait,
@ -570,4 +571,38 @@ describe("Stamp Editor", () => {
);
});
});
describe("Copy/paste from a tab to an other", () => {
let pages1, pages2;
beforeAll(async () => {
pages1 = await loadAndWait("empty.pdf", ".annotationEditorLayer");
pages2 = await loadAndWait("empty.pdf", ".annotationEditorLayer");
});
afterAll(async () => {
await closePages(pages1);
await closePages(pages2);
});
it("must check that the alt-text button is here when pasting in the second tab", async () => {
for (let i = 0; i < pages1.length; i++) {
const [, page1] = pages1[i];
page1.bringToFront();
await page1.click("#editorStamp");
await copyImage(page1, "../images/firefox_logo.png", 0);
await kbCopy(page1);
const [, page2] = pages2[i];
page2.bringToFront();
await page2.click("#editorStamp");
await kbPaste(page2);
await waitForImage(page2, getEditorSelector(0));
await page2.waitForSelector(`${getEditorSelector(0)} .altText`);
}
});
});
});