From fb6c807ba2d5718fb2ca100a738d3df9ca95e402 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sat, 2 Oct 2021 11:24:29 +0200
Subject: [PATCH] Reduce unnecessary duplication in
 `PDFRenderingQueue.getHighestPriority`

---
 web/pdf_rendering_queue.js | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/web/pdf_rendering_queue.js b/web/pdf_rendering_queue.js
index 7e96c9d2c..1057f3e70 100644
--- a/web/pdf_rendering_queue.js
+++ b/web/pdf_rendering_queue.js
@@ -126,21 +126,15 @@ class PDFRenderingQueue {
       }
     }
 
-    // All the visible views have rendered; try to render next/previous pages.
-    if (scrolledDown) {
-      const nextPageIndex = visible.last.id;
-      // IDs start at 1, so no need to add 1.
-      if (views[nextPageIndex] && !this.isViewFinished(views[nextPageIndex])) {
-        return views[nextPageIndex];
-      }
-    } else {
-      const previousPageIndex = visible.first.id - 2;
-      if (
-        views[previousPageIndex] &&
-        !this.isViewFinished(views[previousPageIndex])
-      ) {
-        return views[previousPageIndex];
-      }
+    // All the visible views have rendered; try to render next/previous page.
+    // (IDs start at 1, so no need to add 1 when `scrolledDown === true`.)
+    const preRenderIndex = scrolledDown
+      ? visible.last.id
+      : visible.first.id - 2;
+    const preRenderView = views[preRenderIndex];
+
+    if (preRenderView && !this.isViewFinished(preRenderView)) {
+      return preRenderView;
     }
     // Everything that needs to be rendered has been.
     return null;