Modernize the rewriteWebArchiveUrl test helper function

This commit changes the code to use a template string and to use `const`
instead of `var`. Combined with the previous commits this allows for
enabling the ESLint `no-var` rule for this file now.
This commit is contained in:
Tim van der Meij 2023-12-17 20:37:58 +01:00
parent 0a10a7b57b
commit f9a0d4efe8
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762

View File

@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* eslint-disable no-var */
import crypto from "crypto"; import crypto from "crypto";
import fs from "fs"; import fs from "fs";
@ -25,11 +24,11 @@ function rewriteWebArchiveUrl(url) {
// Web Archive URLs need to be transformed to add `if_` after the ID. // Web Archive URLs need to be transformed to add `if_` after the ID.
// Without this, an HTML page containing an iframe with the PDF file // Without this, an HTML page containing an iframe with the PDF file
// will be served instead (issue 8920). // will be served instead (issue 8920).
var webArchiveRegex = const webArchiveRegex =
/(^https?:\/\/web\.archive\.org\/web\/)(\d+)(\/https?:\/\/.+)/g; /(^https?:\/\/web\.archive\.org\/web\/)(\d+)(\/https?:\/\/.+)/g;
var urlParts = webArchiveRegex.exec(url); const urlParts = webArchiveRegex.exec(url);
if (urlParts) { if (urlParts) {
return urlParts[1] + (urlParts[2] + "if_") + urlParts[3]; return `${urlParts[1]}${urlParts[2]}if_${urlParts[3]}`;
} }
return url; return url;
} }