From 9748d3eb85c16d67a3173f289c366c6ba74f98fc Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Fri, 24 Jun 2022 20:12:50 +0200
Subject: [PATCH] Remove element `id`s from the layersView in the sidebar

Similar to other recent patches, see e.g. PR 15057, we don't want to add these kind of `id`s to DOM-elements since they shouldn't become "linkable" through the URL hash.

*Please note:* This patch can be tested, in the viewer, with e.g. `bug1737260.pdf` from the test-suite.
---
 web/pdf_layer_viewer.js | 5 ++---
 web/viewer.css          | 6 +++++-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/web/pdf_layer_viewer.js b/web/pdf_layer_viewer.js
index 3851008b5..d068224c6 100644
--- a/web/pdf_layer_viewer.js
+++ b/web/pdf_layer_viewer.js
@@ -153,14 +153,13 @@ class PDFLayerViewer extends BaseTreeViewer {
           const input = document.createElement("input");
           this._bindLink(element, { groupId, input });
           input.type = "checkbox";
-          input.id = groupId;
           input.checked = group.visible;
 
           const label = document.createElement("label");
-          label.setAttribute("for", groupId);
           label.textContent = this._normalizeTextContent(group.name);
 
-          element.append(input, label);
+          label.append(input);
+          element.append(label);
           layersCount++;
         }
 
diff --git a/web/viewer.css b/web/viewer.css
index f5bc4176f..f269a3e56 100644
--- a/web/viewer.css
+++ b/web/viewer.css
@@ -1156,12 +1156,16 @@ a:focus > .thumbnail > .thumbnailSelectionRing,
   cursor: pointer;
 }
 
-#layersView .treeItem > a > * {
+#layersView .treeItem > a * {
   cursor: pointer;
 }
 #layersView .treeItem > a > label {
   padding-inline-start: 4px;
 }
+#layersView .treeItem > a > label > input {
+  float: inline-start;
+  margin-top: 1px;
+}
 
 .treeItemToggler {
   position: relative;